518859 - Lightweight theme not applied to titlebar

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Johnathan Nightingale [:johnath]]

Attachment: Screenshot of grey titlebar on applied persona

I'm seeing behaviour on Mac where applying a lightweight theme shows all the graphic elements properly, but doesn't change the titlebar colour appropriately.

Might be a problem with the test page I'm using (see URL field)?

Comment 1

[Dão Gottwald [:dao]]

Does the root element have the following attributes? And what are their values?
activetitlebarcolor, originalactivetitlebarcolor, inactivetitlebarcolor, originalinactivetitlebarcolor

Comment 2

[Johnathan Nightingale [:johnath]]

(In reply to comment #1)
> Does the root element have the following attributes? And what are their values?
> activetitlebarcolor, originalactivetitlebarcolor, inactivetitlebarcolor,
> originalinactivetitlebarcolor

#main-window has none of those four attributes (though it does have the various lightweighttheme* and lwtheme* attributes).

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

I assumed that we still set the (in)activetitlebarcolor by default, but we don't.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

navigator is not available in the module...

Comment 5

[Neil Deakin]

Comment on attachment 403230 [details] [diff] [review]
patch v2

Looks ok but nothing needs to be set on non-Mac?

Comment 6

[Dão Gottwald [:dao]]

accentcolor is also used for the root element's background color regardless of the platform, but activetitlebarcolor is Mac-only (<https://developer.mozilla.org/en/XUL:Attribute:activetitlebarcolor>).

Comment 7

[Johnathan Nightingale [:johnath]]

Dao - we wouldn't block beta for this (hence the P2 designation) but I'd really like it if the first exposure Mac users had to the feature included this fix. Will you be able to land it before Monday's code freeze?

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/24d3ef55e542

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/266837b801f0

Comment 10

[Dave Townsend [:mossop]]

Wouldn't it be better to ifdef this code out on non-mac rather than adding the test?

Comment 11

[Dão Gottwald [:dao]]

This file isn't preprocessed.

Comment 12

[Dave Townsend [:mossop]]

Not right now no, nothing stopping it being preprocessed though.

Comment 13

[Dão Gottwald [:dao]]

Ok, I didn't know there was a way to do that.

Comment 14

[Dave Townsend [:mossop]]

(In reply to comment #13)
> Ok, I didn't know there was a way to do that.

EXTRA_PP_JS_MODULES in Makefile.in will preprocess js modules into place rather than just copying them.

Comment 15

[Dão Gottwald [:dao]]

Attachment: follow-up

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 404408 [details] [diff] [review]
follow-up

http://hg.mozilla.org/mozilla-central/rev/9871bc47451f
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4c1a63fce358

Comment 17

[Marcia Knous [:marcia]]

This is a bit difficult to verify since some personas don't seem to have the theme applied to the title bar - such as Firefox Robot. I am using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1.

Comment 18

[Johnathan Nightingale [:johnath]]

(In reply to comment #17)
> This is a bit difficult to verify since some personas don't seem to have the
> theme applied to the title bar - such as Firefox Robot. 

I recommend using Sean Martell's personas to test: http://www.getpersonas.com/en-US/gallery/designer/Sean.Martell

He tends to choose titlebar colours that blend well, and ones where the default gray would look wrong.