Closed Bug 518859 Opened 11 years ago Closed 11 years ago

Lightweight theme not applied to titlebar

Categories

(Toolkit :: XUL Widgets, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: johnath, Assigned: dao)

References

()

Details

Attachments

(3 files, 1 obsolete file)

I'm seeing behaviour on Mac where applying a lightweight theme shows all the graphic elements properly, but doesn't change the titlebar colour appropriately.

Might be a problem with the test page I'm using (see URL field)?
Blocks: 511104
Does the root element have the following attributes? And what are their values?
activetitlebarcolor, originalactivetitlebarcolor, inactivetitlebarcolor, originalinactivetitlebarcolor
(In reply to comment #1)
> Does the root element have the following attributes? And what are their values?
> activetitlebarcolor, originalactivetitlebarcolor, inactivetitlebarcolor,
> originalinactivetitlebarcolor

#main-window has none of those four attributes (though it does have the various lightweighttheme* and lwtheme* attributes).
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Assignee: nobody → dao
Attached patch patch (obsolete) — Splinter Review
I assumed that we still set the (in)activetitlebarcolor by default, but we don't.
Attachment #403228 - Flags: review?(enndeakin)
Attached patch patch v2Splinter Review
navigator is not available in the module...
Attachment #403228 - Attachment is obsolete: true
Attachment #403230 - Flags: review?(enndeakin)
Attachment #403228 - Flags: review?(enndeakin)
Flags: blocking1.9.2?
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P2
Attachment #403230 - Flags: review?(enndeakin) → review+
Comment on attachment 403230 [details] [diff] [review]
patch v2

Looks ok but nothing needs to be set on non-Mac?
accentcolor is also used for the root element's background color regardless of the platform, but activetitlebarcolor is Mac-only (<https://developer.mozilla.org/en/XUL:Attribute:activetitlebarcolor>).
Dao - we wouldn't block beta for this (hence the P2 designation) but I'd really like it if the first exposure Mac users had to the feature included this fix. Will you be able to land it before Monday's code freeze?
http://hg.mozilla.org/mozilla-central/rev/24d3ef55e542
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Wouldn't it be better to ifdef this code out on non-mac rather than adding the test?
This file isn't preprocessed.
Not right now no, nothing stopping it being preprocessed though.
Ok, I didn't know there was a way to do that.
(In reply to comment #13)
> Ok, I didn't know there was a way to do that.

EXTRA_PP_JS_MODULES in Makefile.in will preprocess js modules into place rather than just copying them.
Attached patch follow-upSplinter Review
Attachment #404408 - Flags: review?(dtownsend)
Attachment #404408 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
Keywords: checkin-needed
This is a bit difficult to verify since some personas don't seem to have the theme applied to the title bar - such as Firefox Robot. I am using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1.
(In reply to comment #17)
> This is a bit difficult to verify since some personas don't seem to have the
> theme applied to the title bar - such as Firefox Robot. 

I recommend using Sean Martell's personas to test: http://www.getpersonas.com/en-US/gallery/designer/Sean.Martell

He tends to choose titlebar colours that blend well, and ones where the default gray would look wrong.
You need to log in before you can comment on or make changes to this bug.