Closed Bug 518941 Opened 12 years ago Closed 12 years ago

Update libvorbis to pick up fix for some files encoded with libvorbis beta1

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed
status1.9.1 --- .4-fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

()

Details

(Keywords: verified1.9.1)

Attachments

(2 obsolete files)

SVN r16552 includes a fix to libvorbis that prevents the decoder from rejecting some valid files produced with the beta4 encoder.  These may not be particularly common files, but we should pick this simple fix up anyway.
Flags: wanted1.9.2?
Attached patch patch v0 (obsolete) — Splinter Review
Update libvorbis to SVN r16552.

This needs a test, but I don't have a file which is fixed by this patch handy.
It's actually the beta1 encoder.  Test file in URL.  Unfortunately it doesn't play on trunk *or* with the patch applied.  Haven't investigated why yet.
Summary: Update libvorbis to pick up fix for some files encoded with libvorbis beta4 → Update libvorbis to pick up fix for some files encoded with libvorbis beta1
Flags: wanted1.9.2? → wanted1.9.2+
Attached patch patch v1 (obsolete) — Splinter Review
Same, but with a test.  This also fixes the comments above gPlayTests, which should've been above gErrorTests (I messed them up in bug 481057).

Included test file does not play on current trunk, but does play with patch applied (comment 2 is out of date--suspect that was fixed by oggplay updates).  Note that the test does not fail every time when the patch is not applied, but I can't work out why.
Attachment #402938 - Attachment is obsolete: true
We took the broken libvorbis update on 1.9.1 for 1.9.1.4, so we should take this fix to ensure we don't regress anything.

Also see bug 507167 comment 16.
status1.9.1: --- → ?
Attachment #404185 - Attachment is patch: true
Attachment #404185 - Attachment mime type: application/octet-stream → text/plain
Posted the libvorbis update to bug 507167.  Includes the test from this bug.  Marking this as depending on that.
Depends on: 507167
http://hg.mozilla.org/mozilla-central/rev/196956e36ed2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #404185 - Attachment is obsolete: true
Fixed on 1.9.2 by checkin of bug 507167.
Checked in to 1.9.1 too.
Do we have sample rejected files somewhere that can be used to verify this fix for Firefox 3.5.4?
There's one in the bug URL.  I don't have any others to test with.
Er, I missed the url. Sorry about that.

I verified that it doesn't play in 1.9.1.3 on OS X but does play on 1.9.1.4 (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4) so this looks good.
Keywords: verified1.9.1
You need to log in before you can comment on or make changes to this bug.