If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Linux ARM tries to building ctypes because OS_TEST is armv71

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
js-ctypes
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla1.9.3a1
ARM
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
uname -m returns "armv71" on Ubuntu 9.04 with i.MX51.  So, OS_TEST becomes armv71.

But http://mxr.mozilla.org/mozilla-central/source/configure.in#7629,

7632 AC_SUBST(BUILD_CTYPES)
7633 if test "$OS_TEST" != "arm"; then
7634   BUILD_CTYPES=1
7635   AC_DEFINE(BUILD_CTYPES)
7636 fi

So we don't compare just "arm" for OS_TEST whether ARM or not.
(Assignee)

Comment 1

8 years ago
Created attachment 403172 [details] [diff] [review]
patch v1
(Assignee)

Updated

8 years ago
Attachment #403172 - Flags: review?(ted.mielczarek)
I think this would probably be better as an explicit whitelist of architectures we support. What happens when someone compiles for Sparc or some other weirdo arch?

Comment 3

8 years ago
In theory, we do support sparc, and all the other weird arches - libffi is supposed to handle them fine (as long as they have gcc), which is why I went with a blacklist. And if it's broken on a certain arch, having people file bugs is useful, too - in the powerpc case, for example, just pulling in an upstream patch fixed it. If you think we should go with a whitelist, though, I'm fine with it.

|ls| in js/ctypes/libffi/src indicates that it has at least some degree of support for:

alpha
arm
cris
frv
ia64
m32r
m68k
mips
pa
powerpc
s390
sh
sh64
sparc
x86

Comment 4

8 years ago
(It does support arm, by the way, I just turned it off for now because it's slightly broken. It won't be that hard to fix.)
Comment on attachment 403172 [details] [diff] [review]
patch v1

Ok, that's a pretty big list. I guess we might as well do it this way and if someone finds it's broken they can either fix it or add it to the blacklist.

I note your list contains arm, do we have a followup on fixing the ctypes arm support?
Attachment #403172 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → m_kato

Comment 6

8 years ago
Checked in on trunk (http://hg.mozilla.org/mozilla-central/rev/f95f9da863bb). Will land on branch as well.

(In reply to comment #5)
> I note your list contains arm, do we have a followup on fixing the ctypes arm
> support?

Not yet! Will file.

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 7

8 years ago
Landed on 1.9.2 per bug 513783.
status1.9.2: --- → beta1-fixed
Component: js-ctypes → js-ctypes
Product: Other Applications → Core
Version: Trunk → unspecified
Blocks: 535231
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
Flags: in-testsuite-
Blocks: 527363
Depends on: 513783
You need to log in before you can comment on or make changes to this bug.