519196 - No symbols in stack trace on tests of debug builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Initial report here: https://bugzilla.mozilla.org/show_bug.cgi?id=518634#c3

We're not getting symbols on stack traces of debug builds.

Comment 1

[(not currently active) Ted Mielczarek]

Unsure if this has the same root cause as bug 519194, we should look and see.

Comment 2

[(not currently active) Ted Mielczarek]

Now that the debug builds are uploaded to a separate path, it's easy to look and see that the symbols.zip is only 230 bytes:
http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux-debug/
(see the contents of any subdir there)

Comment 3

[(not currently active) Ted Mielczarek]

From the build log:
Processing file: ./dist/bin/libxul.so
Stab section not found.
Failed to write symbol file.

And from a random compile:
/tools/gcc-4.3.3/installed/bin/g++ -o nsDependentString.o -c -I../../../dist/system_wrappers -include /builds/moz2_slave/mozilla-central-linux-debug/build/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.18-53.1.19\" -DOSARCH=Linux -D_IMPL_NS_COM  -I/builds/moz2_slave/mozilla-central-linux-debug/build/xpcom/string/src -I. -I../../../dist/include -I../../../dist/include/nsprpub  -I/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/include/nspr -I/builds/moz2_slave/mozilla-central-linux-debug/build/obj-firefox/dist/include/nss       -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_cltbld -DTRACING -g -fno-inline   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsDependentString.pp /builds/moz2_slave/mozilla-central-linux-debug/build/xpcom/string/src/nsDependentString.cpp

We're building with -g, which is going to give us stabs by default. We need to do
--enable-debug="-gstabs+"
to fix this.

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: --enable-debug="-gstabs+"

This should do it, but I haven't tested it.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 407757 [details] [diff] [review]
--enable-debug="-gstabs+"

Feel free to land this whenever, but please update the Maintenance page when you do (https://wiki.mozilla.org/ReleaseEngineering:Maintenance).

Comment 6

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/build/buildbot-configs/rev/bbeb0a56b830

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Are we going to need that change on m-1.9.2 (and possibly elsewhere) if unit-on-debug is enabled there ?

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Also, we have to remember to check what the disk space implications are of changes like this. We burned a number of builds until bug 522719 caught up with it.

Comment 9

[(not currently active) Ted Mielczarek]

Yeah, if we want debug unittests there we'll probably want this.