519194 - No symbols in stack trace on tests of optimized builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

From initial report here: https://bugzilla.mozilla.org/show_bug.cgi?id=518634#c0

Unittests on an optimized Linux builds crashed.  We got a stack trace, but without symbols.

Comment 1

[(not currently active) Ted Mielczarek]

I suggested that we should grab one of these builds + associated symbols, unpack them somewhere, run the browser, kill it to get a minidump, and try running minidump_stackwalk with that dump + the symbols to sanity check that it works.

Comment 2

[(not currently active) Ted Mielczarek]

I tried this locally and the stack trace came out with symbols. I grabbed the build + symbols from this build:
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox-Unittest&errorparser=unittest&logfile=1254150797.1254152377.1343.gz&buildtime=1254150797&buildname=Linux%20mozilla-central%20test%20opt%20mochitests&fulltext=1

Which had a crash and displayed a stack trace without symbols. It looks like the symbols are unpacked in the right place, and the runtests.py commandline references them properly. I'm not sure what's going on here.

Comment 3

[(not currently active) Ted Mielczarek]

I'm seeing this on regular unittest builds too:
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox-Unittest&errorparser=unittest&logfile=1254313915.1254316010.3374.gz&buildtime=1254313915&buildname=Linux%20mozilla-central%20test%20everythingelse&fulltext=1

I think there's a deeper problem here.

Comment 6

[(not currently active) Ted Mielczarek]

I'm not sure how this ever worked, honestly, but I pushed a fix:
http://hg.mozilla.org/mozilla-central/rev/0f0239688a76
(I also left in some extra debug output in there, to give more info in case MINIDUMP_STACKWALK isn't set.)

I was able to reproduce the problem locally using a build+packaged tests, and this patch fixed it.

Comment 7

[(not currently active) Ted Mielczarek]

Landed on 1.9.2 and 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/262f3b625565
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/09373c9dbce9