Closed Bug 519682 Opened 12 years ago Closed 12 years ago

Build process support for multi-locale builds on maemo

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

(Whiteboard: [fennec l10n])

Attachments

(3 files)

We need some Makefile support to build multi-locale builds for fennec on maemo.

We don't want the regular development builds to be multi-locale, this is only for nightlies and release builds.

The makefile foo is supposed to merely add the l10n jar stuff to the regular dist/bin/chrome distinations.

This requires some tweaks in toolkit/locales/Makefile.in, as its libs-% target messes with the update locale file, which we don't want, and it stages in dist/xpi-stage/locale-%. I propose to add a chrome-% target there, to keep the directory logic next to each other, that just calls into the sub chrome targets.

On the mobile side, we need a new target that calls into chrome-%, and chrome's up mobile and branding.

Follow up bugs should handle bookmarks preprocessing, and search. Another follow up bug will go to releng to actually use this target and a maemo-locales file to put the selected locales into the multi-locale builds.
Blocks: 519684
Whiteboard: [fennec l10n]
Blocks: 519685
Blocks: 519686
tracking-fennec: --- → ?
This is the toolkit patch. We'd need this on both central and 1.9.2.

I just copied and modded the lines in libs-%, and for the sake of safety, didn't attempt to factor anything  between the two targets.

Not taking this bug as I won't really have cycles to push it to production in the next week or so, help welcome.
Attachment #403755 - Flags: review?(ted.mielczarek)
Pretty much the same thing as for toolkit, just calling in to a few targets to get our stuff into shape.
Attachment #403756 - Flags: review?(ted.mielczarek)
Filed bug 519696 on the locales list.
(In reply to comment #1)
> Not taking this bug as I won't really have cycles to push it to production in
> the next week or so, help welcome.

urgh. Ted, I *think* this is a requirement for Fennec1.0, so would you be right person to take this if Axel doesnt have time? 

(nominating this bug to get confirmation from beltzner/stuart)
Flags: wanted-fennec1.0?
I don't actually know how any of our l10n stuff works, so I really don't think I'm the right person to do this. I'm happy to do reviews, as usual, even though I will admit to trusting Axel's judgement on most l10n build stuff.
Comment on attachment 403755 [details] [diff] [review]
add chrome-% to toolkit

+	@$(MAKE) -C ../../netwerk/locales/ chrome AB_CD=$*

Do you want to use $(DEPTH) there for clarity?
Attachment #403755 - Flags: review?(ted.mielczarek) → review+
Attachment #403756 - Flags: review?(ted.mielczarek) → review+
Switched to $(DEPTH), but only for the chrome targets to not affect the fx build.

Landed on mobile, central, and 1.9.2 (as npotb),
http://hg.mozilla.org/mobile-browser/rev/3e87438ce25f
http://hg.mozilla.org/mozilla-central/rev/ee06be6166bc
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a9c8b8c0b9a0

(unsetting 1.0 triage flags as this is FIXED)
Status: NEW → RESOLVED
tracking-fennec: ? → ---
Closed: 12 years ago
Flags: wanted-fennec1.0?
Resolution: --- → FIXED
Reopening, I forgot a patch for mobile/makefiles.sh. Coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I forgot a patch that actually makes us create the toolkit locales/Makefile's we need in the mobile app.
Attachment #406073 - Flags: review?(mark.finkle)
Attachment #406073 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/baed480f8617, marking FIXED again.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
verified via ftp site :)
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
QA Contact: maemo-linux → general
Hardware: All → ARM
You need to log in before you can comment on or make changes to this bug.