Closed Bug 519769 Opened 10 years ago Closed 9 years ago

Open shared/unshared connections with options instead of setting shared state always

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b5

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

()

Details

Attachments

(1 file, 1 obsolete file)

As of SQLite 3.6.18, we can use two constants to open with the shared cache or without.  This means we can stop enabling/disabling the shared cache like we currently do.

Constants to use:
SQLITE_OPEN_SHAREDCACHE
SQLITE_OPEN_PRIVATECACHE
No longer depends on: 519270
Depends on: SQLite3.6.20
Blocks: 583882
Attached patch v1.0 (obsolete) — Splinter Review
This is OK for NSS too because they only use one connection so they never depended on us having the shared cache turned on.
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #462216 - Flags: review?(bugmail)
Whiteboard: [needs review asuth]
Attachment #462216 - Flags: review?(bugmail) → review+
Whiteboard: [needs review asuth] → [needs approval]
Attachment #462216 - Flags: approval2.0?
What's the risk/reward tradeoff like here?
I don't really think there is much risk here.  We are doing the same thing that the SQLite API was doing, but now without acquiring a mutex (so less contention).  Also, simpler code.
Attachment #462216 - Flags: approval2.0? → approval2.0+
Whiteboard: [needs approval] → [can land]
Attached patch v1.0 for checkinSplinter Review
With proper commit message
Attachment #462216 - Attachment is obsolete: true
Keywords: dev-doc-needed
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/88be5af389ed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla2.0b5
You need to log in before you can comment on or make changes to this bug.