519819 - "You can now nominate your add-on for public" when add-on is already nominated

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Milos Dinic [:Milos]]

On the https://addons.mozilla.org/en-US/developers/addon/status/11135 (for my add-on), it says:


Add-on Status: In Sandbox; Public Nomination

Your add-on is currently nominated to become Public and is awaiting editor review. There are currently 429 other add-ons in the nomination queue.
Public Nomination Criteria

    * At least one preview image required for extensions and themes.
    * Add-on is not marked as pre-release.

You may now nominate your add-on for Public by clicking the button below.

------------------------------------

But, my add-on is already nominated, so there is no button. We should remove last line if the bug is in the public queue.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: fix

Fix, and also found several _() statements that were never being echoed (?!)

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 408057 [details] [diff] [review]
fix

I think the patch is good, but now that we are adding another status (listed) I am thinking we might have to enumerate the specific statuses here in the if clause instead of the < .

If you disagree, let me know.

Comment 3

[Wil Clouser [:clouserw]]

Attachment: the same thing

I don't think it has anything to do with my patch, it's existing code.  But here is a change.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 408131 [details] [diff] [review]
the same thing

teh awesome.

Comment 5

[Wil Clouser [:clouserw]]

r54225

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Milos: is this now fixed on https://preview.addons.mozilla.org/en-US/developers/addon/status/11135?  Can you confirm?  Thanks!

Comment 7

[Milos Dinic [:Milos]]

Verified on https://preview.addons.mozilla.org/en-US/developers/addon/status/11135

Thanks.