519833 - remove find bar from fennec for 1.0

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Madhava Enros [:madhava]]

We've cut the find (find in page) bar for 1.0, but CTRL-F still brings it up.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm going to remove the CTRL+F shortcut, which is the only way to make it visible. But I am leaving the code since we seem to want Find-on-Page for a later release.

I even have some contributor patches to land for Find.

Comment 2

[Madhava Enros [:madhava]]

Yeah - that's better.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch removes the <command>s and <key>s to open the Findbar

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (every last drop)

This patch removes all traces of findbar

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/552ff7259a9b

hg qref -m fail

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091020
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091020
Fennec/1.0b5pre

Comment 7

[Aakash Desai [:aakashd]]

Litmus testcases:

https://litmus.mozilla.org/show_test.cgi?id=7353
https://litmus.mozilla.org/show_test.cgi?id=7213
https://litmus.mozilla.org/show_test.cgi?id=7231
https://litmus.mozilla.org/show_test.cgi?id=7377

all were deleted.