519937 - Remove "Back", "Forward" and "Home" from History menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[eyal gruss]

To quote from the similar bug 513168:
These seem not-so-useful and are accessible from other parts of the UI.

Comment 1

[u88484]

Looks to not be used very often at all

http://blog.mozilla.com/metrics/2010/04/14/menu-item-usage-study-an-update-to-the-initial-analysis/

Comment 2

[Michael Kohler [:mkohler]]

Attachment: Patch v1 (trivial)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 456125 [details] [diff] [review]
Patch v1 (trivial)

Similar to bug 513168...
The items are needed for exposing the keyboard shortcuts.

Comment 4

[Michael Kohler [:mkohler]]

(In reply to comment #3)
> (From update of attachment 456125 [details] [diff] [review])
> Similar to bug 513168...
> The items are needed for exposing the keyboard shortcuts.

What if we fix bug 519921? That would make a lot cleaner in UI.

Comment 5

[Tyler Downer [He/Him]]

Seem to be gone...

Comment 6

[:Margaret Leibovic]

(In reply to comment #5)
> Seem to be gone...

They are still there:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-menubar.inc#357

They're visible on OSX, but they won't show up on Windows because of bug 607224.

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 779692 [details] [diff] [review]
patch

Review of attachment 779692 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/linux/browser.css
@@ +416,4 @@
>  #context-back:-moz-locale-dir(rtl) {
>    list-style-image: url("moz-icon://stock/gtk-go-back-rtl?size=menu");
>  }
> +g

looks like a typo.

Comment 9

[Asaf Romano (gone)]

Years ago, these items (along with Tools->Web Search, for example) were added for accessibility: there's no way to figure the keyboard shortcut for them without the menu items, and the toolbar is not accessible for keyboard-only users.

What changed?

Comment 10

[Asaf Romano (gone)]

Sorry, I just read about the new Help menu item.

Comment 11

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1dfeded92d67

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1dfeded92d67