513168 - Remove "Stop" and "Reload" from View menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Justin Dolske [:Dolske]]

These seem not-so-useful and are accessible from other parts of the UI.

Comment 1

[Jo Hermans]

It serves as a reminder for the keyboard shortcuts (esc/ctrl-r)

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Menu items as keyboard command reminders aren't really all that helpful. We can add the keyboard shortcuts to the tooltips.

Comment 3

[Simon Bünzli]

(In reply to comment #2)
> Menu items as keyboard command reminders aren't really all that helpful. We can
> add the keyboard shortcuts to the tooltips.

Which a mouse-less user won't be able to discover, though. One "Help -> Keyboard Shortcuts" item should be able to replace all such menu items in a sec508 compatible manner, though.

Comment 4

[eyal gruss]

suggesting to include in this discussion also "back" "forward" and "home" from the history menu, which stand on similar footing

Comment 5

[u88484]

eyal, you should probably file a new bug on that since they are in a different menu and would have a slighty different discussion on why or why not they are useful.

Comment 6

[(no longer active)]

Attachment: Patch (v1)

Based on my patch in bug 519921, and the suggestion in comment 2.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 403985 [details] [diff] [review]
Patch (v1)

I don't see how tooltips solve the a11y issue. Comment 3 makes more sense to me.

Comment 8

[(no longer active)]

Attachment: Patch (v2)

With the new Keyboard Shortcuts Help menu item.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 403992 [details] [diff] [review]
Patch (v2)

>--- a/browser/base/content/baseMenuOverlay.xul
>+++ b/browser/base/content/baseMenuOverlay.xul
>@@ -86,16 +86,20 @@
>                   key="key_openHelp"/>
> #endif
> # Show IE Users menu item on Windows only
> #ifdef XP_WIN
>         <menuitem label="&helpForIEUsers.label;"
>                   accesskey="&helpForIEUsers.accesskey;"
>                   oncommand="openHelpLink('ieusers');"/>
> #endif
>+        <menuitem id="keyboardShortcuts"
>+                  accesskey="&helpKeyboardShortcuts.accesskey;"
>+                  label="&helpKeyboardShortcuts.label;"
>+                  oncommand="openHelpLink('keyboard-shortcuts')"/>

I'd probably add this above the "For IE Users" item.

>+                     tooltipkey="key_reload"

Is this still worthwhile?

Comment 10

[eyal gruss]

filed Bug 519937 per comment #4

Comment 11

[(no longer active)]

Updating to reality: I won't have the time to work on this for the foreseeable future!

Comment 12

[u88484]

Looks to not be used very often at all

http://blog.mozilla.com/metrics/2010/04/14/menu-item-usage-study-an-update-to-the-initial-analysis/

Comment 14

[Tyler Downer [He/Him]]

appears to be gone now

Comment 15

[[:Aleksej]]

An opposite bug: bug 737015.

Comment 16

[Dão Gottwald [:dao]]

Attachment: patch

Comment 17

[Marco Bonardo [:mak]]

Should we get accessibility review on these changes? may the removal cause any issues to our blind users?
My understanding is that regardless they have other ways to access the same functionality, as well as reach the new shortcuts menuitem in the Help menu.
But may be good to get them in the loop for a confirmation.

Comment 18

[Marco Zehe (:MarcoZ)]

Comment on attachment 779694 [details] [diff] [review]
patch

As long as we have an up-to-date shortcuts list handy from the help menu, i don't see a problem with removing the menu items. The shortcuts (ctrl+r for reload, escape for stop, both on Windows) are unaffected by this, and they are probably being used way more often than the View menu options. I personally don't remember ever using the View menu for this. ;-) f=me.

Comment 19

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/711c00277568

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/711c00277568