520141 - fix source server support to work with pdb compression

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

The fix for bug 385792 broke the work done in bug 440001, because it compresses the pdb before we get a chance to insert the source server info. Commenting out the lines that do the compression fixes this, but I don't want to lose the compression. We'll have to swap things around to get both.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Do source server indexing before copying and compressing pdb

This seems to work, but this is a pain to test locally, since I'm testing with an mq patch applied, and that means my local revision doesn't exist on hg.mozilla.org. I've pushed it to try, which should actually work, since the revision will be on the try repo. Will test again when that finishes.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 404231 [details] [diff] [review]
Do source server indexing before copying and compressing pdb

Of course, that doesn't work either due to bug 506702. Ok, whatever, I'm just going to try to get this landed.

Comment 3

[Johnny Stenback (:jst)]

We should do what we can to get this in for 3.5.4 IMO.

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, it's a pretty small patch, I think we can do that. Need to get this landed, then bug 506702, then spin a nightly to sanity check that everything works.

Comment 5

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/96b2fb480110

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 404231 [details] [diff] [review]
Do source server indexing before copying and compressing pdb

I verified that this works on today's trunk nightly. We'll need to get this onto branches and then get the rest of bug 506702 landed to make this work.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 404231 [details] [diff] [review]
Do source server indexing before copying and compressing pdb

Approved for 1.9.1.4, a=dveditz for release-drivers

This needs to land today, Oct 5, so we can build tomorrow.

Comment 8

[(not currently active) Ted Mielczarek]

Pushed to 192 and 191
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/57965eaf6945
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f7bcca52e1f9

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good on trunk with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091005 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091005045052

Any chance QA can verify it without having the fix on bug 440001 for 1.9.2 and 1.9.1?

Comment 10

[(not currently active) Ted Mielczarek]

That fix landed before 1.9.2 branched, so today's 1.9.2 nightly should work in the same way. I forgot that bug 440001 never landed on branch, so it won't work there yet. :-/

Comment 11

[(not currently active) Ted Mielczarek]

(never landed on the 1.9.1 branch, I mean)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works like a charm on 1.9.2 too. Tested with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091006 Namoroka/3.6b1pre (.NET CLR 3.5.30729) ID:20091006045110

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on 1.9.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091007 Firefox/3.5.4 (.NET CLR 3.5.30729) ID:20091007001339