520152 - [Collector Extension] Handle plurals in Added string in add-on listing (TB2)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P1)

Description

[Brian King [:kinger]]

This temp code explains it the best:

if (!Bandwagon.Util.isTB2())
{
  Components.utils.import("resource://gre/modules/PluralForm.jsm");
  let [get, numForms] = PluralForm.makeGetter(this.stringBundle.GetStringFromName("bandwagon.addon.pluralRule"));
  datestr = get(sbVal, this.stringBundle.formatStringFromName(sbString, [sbVal], 1));
}
els{
  datestr = "Added";
}

The let statement is problematic, but the most important thing here is that PluralForm.jsm is not available to us here.

Comment 1

[Axel Hecht [:Pike]]

I guess this predates the hallway conversation between Brian and I, you should probably just ship PluralForm.js as part of collector and use that.

Either conditionally or not.

Comment 2

[David McNamara [:mackers]]

Tried in vain to get PluralForm.jsm imported (via C.u.import and mozIJSSubScriptLoader), but without success.

Finally, I backported the guts of the PluralForm stuff to a BW module "Bandwagon.Util.PluralForm" that is used when the env. is TB2.

Working fine for English. By extension should work for other languages.

r53260.