520237 - Help>Migration Assistant from windows other than 3pane throws error document.getElementById("tabmail") is null

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Help>Migration Assistant from windows other than 3pane throws 

Error: document.getElementById("tabmail") is null
Source File: chrome://communicator/content/utilityOverlay.js
Line: 333

20091001 build

Comment 1

[David Ascher (:davida)]

This should be fairly trivial to fix.  Sid, can you whip up a patch?

Comment 2

[Mark Banner (:standard8)]

Hint: about dialog already does what we want. Maybe even Help -> What's New does - though if it doesn't we should fix that as well.

Comment 3

[David Ascher (:davida)]

Attachment: patch v1

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 404645 [details] [diff] [review]
patch v1

>+  let url = "chrome://messenger/content/featureConfigurator.xhtml";

Should be a const - we're not going to change it.

>+  if (mail3PaneWindow) {
>+    tabmail = mail3PaneWindow.document.getElementById("tabmail");
>+    mail3PaneWindow.focus();
>+    let tabmail = mail3PaneWindow.document.getElementById("tabmail");
>+    tabmail.openTab("chromeTab", {chromePage: url});

tabmail is "defined twice" but doesn't need defining at all as it is just an intermediate variable.

Comment 5

[Mark Banner (:standard8)]

Attachment: patch v2

I've addressed the comments and checked it in:

http://hg.mozilla.org/comm-central/rev/71684616d1dc