Closed Bug 520364 Opened 11 years ago Closed 10 years ago

Make about:memory themeable

Categories

(Toolkit :: Themes, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: spitfire.kuden, Assigned: philor)

References

Details

Attachments

(2 files)

Attached image Screenshot
http://hg.mozilla.org/mozilla-central/annotate/ed8c714d33ad/toolkit/components/aboutmemory/content/aboutMemory.xhtml#l44

- <link rel="stylesheet" href="chrome://global/content/aboutMemory.css" type="text/css"/>
+ <link rel="stylesheet" href="chrome://global/skin/aboutMemory.css" type="text/css"/>

chrome://global/content/aboutMemory.css is moved to chrome://global/skin/aboutMemory.css.
Component: IPC → Themes
Product: Core → Toolkit
QA Contact: ipc → themes
Summary: Themes cannot give about:memory an original design → aboutMemory.css belongs in toolkit/themes/
It really doesn't, at least not yet; it'll probably undergo heavy changes, and so no themes should ever really build on it/replace it any time soon.
Attached patch Fix v.1Splinter Review
While it doesn't actually seem to have gotten all that much churn (zero additional changes and shipped with one Fx release in the last four months), conveniently we have patterns for "I don't really want to theme it differently on different platforms" (just add it to winstripe, which gets everything but pinstripe, and have pinstripe jar it from ../../winstripe) and for "I don't really want to change even just one theme file, I want to change the one that's right in front of me in content" (just make the skin file @import the content file), so you can have it third-party (and embedder, since it was Camino's desire to theme it that made me notice) themeable without even noticing that anything changed.

Well, except that the xhtml had DOS line-endings, and since I was touching every line for that I wrapped the long lines, but the actual change there is just s/content/skin/.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #427072 - Flags: review?(dao)
Attachment #427072 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/830268d73761
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Summary: aboutMemory.css belongs in toolkit/themes/ → Make about:memory themeable
Target Milestone: --- → mozilla1.9.3a2
Blocks: 547458
Will this patch also land on branch?
No.
(In reply to comment #1)
> It really doesn't, at least not yet; it'll probably undergo heavy changes, and
> so no themes should ever really build on it/replace it any time soon.
Well, I guess that explains why it isn't quite about: style yet ;-)
You need to log in before you can comment on or make changes to this bug.