520364 - Make about:memory themeable

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot

http://hg.mozilla.org/mozilla-central/annotate/ed8c714d33ad/toolkit/components/aboutmemory/content/aboutMemory.xhtml#l44

- <link rel="stylesheet" href="chrome://global/content/aboutMemory.css" type="text/css"/>
+ <link rel="stylesheet" href="chrome://global/skin/aboutMemory.css" type="text/css"/>

chrome://global/content/aboutMemory.css is moved to chrome://global/skin/aboutMemory.css.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It really doesn't, at least not yet; it'll probably undergo heavy changes, and so no themes should ever really build on it/replace it any time soon.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

While it doesn't actually seem to have gotten all that much churn (zero additional changes and shipped with one Fx release in the last four months), conveniently we have patterns for "I don't really want to theme it differently on different platforms" (just add it to winstripe, which gets everything but pinstripe, and have pinstripe jar it from ../../winstripe) and for "I don't really want to change even just one theme file, I want to change the one that's right in front of me in content" (just make the skin file @import the content file), so you can have it third-party (and embedder, since it was Camino's desire to theme it that made me notice) themeable without even noticing that anything changed.

Well, except that the xhtml had DOS line-endings, and since I was touching every line for that I wrapped the long lines, but the actual change there is just s/content/skin/.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/830268d73761

Comment 4

[Pardal Freudenthal (:ShareBird)]

Will this patch also land on branch?

Comment 5

[Dão Gottwald [:dao]]

No.

Comment 6

[[e-mail]]

(In reply to comment #1)
> It really doesn't, at least not yet; it'll probably undergo heavy changes, and
> so no themes should ever really build on it/replace it any time soon.
Well, I guess that explains why it isn't quite about: style yet ;-)