Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Make about:memory themeable

RESOLVED FIXED in mozilla1.9.3a2

Status

()

Toolkit
Themes
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: AKIHIRO Misaki (a.k.a Kuden), Assigned: philor)

Tracking

Trunk
mozilla1.9.3a2
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 404417 [details]
 Screenshot

http://hg.mozilla.org/mozilla-central/annotate/ed8c714d33ad/toolkit/components/aboutmemory/content/aboutMemory.xhtml#l44

- <link rel="stylesheet" href="chrome://global/content/aboutMemory.css" type="text/css"/>
+ <link rel="stylesheet" href="chrome://global/skin/aboutMemory.css" type="text/css"/>

chrome://global/content/aboutMemory.css is moved to chrome://global/skin/aboutMemory.css.

Updated

8 years ago
Component: IPC → Themes
Product: Core → Toolkit
QA Contact: ipc → themes
Summary: Themes cannot give about:memory an original design → aboutMemory.css belongs in toolkit/themes/
It really doesn't, at least not yet; it'll probably undergo heavy changes, and so no themes should ever really build on it/replace it any time soon.
Created attachment 427072 [details] [diff] [review]
Fix v.1

While it doesn't actually seem to have gotten all that much churn (zero additional changes and shipped with one Fx release in the last four months), conveniently we have patterns for "I don't really want to theme it differently on different platforms" (just add it to winstripe, which gets everything but pinstripe, and have pinstripe jar it from ../../winstripe) and for "I don't really want to change even just one theme file, I want to change the one that's right in front of me in content" (just make the skin file @import the content file), so you can have it third-party (and embedder, since it was Camino's desire to theme it that made me notice) themeable without even noticing that anything changed.

Well, except that the xhtml had DOS line-endings, and since I was touching every line for that I wrapped the long lines, but the actual change there is just s/content/skin/.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #427072 - Flags: review?(dao)

Updated

8 years ago
Attachment #427072 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/830268d73761
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Hardware: x86 → All
Resolution: --- → FIXED
Summary: aboutMemory.css belongs in toolkit/themes/ → Make about:memory themeable
Target Milestone: --- → mozilla1.9.3a2

Updated

8 years ago
Blocks: 547458
Will this patch also land on branch?
No.

Comment 6

7 years ago
(In reply to comment #1)
> It really doesn't, at least not yet; it'll probably undergo heavy changes, and
> so no themes should ever really build on it/replace it any time soon.
Well, I guess that explains why it isn't quite about: style yet ;-)
You need to log in before you can comment on or make changes to this bug.