Modern theme needs CSS for about:memory

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Themes
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: InvisibleSmiley)

Tracking

({modern})

Trunk
seamonkey2.1a1
modern

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Bug 520364 made it possible for themes to style about:memory
(Assignee)

Comment 1

7 years ago
Created attachment 441614 [details] [diff] [review]
patch

I mostly just copy-pasted from mozilla/toolkit/components/aboutmemory/content/aboutMemory.css and Modern's about.css. I'm not a Modern expert.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #441614 - Flags: review?(neil)
(Reporter)

Updated

7 years ago
Attachment #441614 - Flags: review?(neil) → review+
(Reporter)

Comment 2

7 years ago
Comment on attachment 441614 [details] [diff] [review]
patch

r=me with a couple of nits fixed.

>+h1 {
>+  font-weight: bold;
>+  font-size: x-large;
>+}
Probably unnecessary; see below.

>+h2 {
>+  margin-top: 0;
>+  font-weight: bold;
>+  font-size: large;
>+}
The font-weight is of course unnecessary, since all headers default to bold. I don't see any advantage in changing the default sizes either. We probably need to keep the zero top margin though.

>+.memOverview table {
>+  font-size: 120%;
>+}
about.css uses 110% for something similar.
(Reporter)

Comment 3

7 years ago
Comment on attachment 441614 [details] [diff] [review]
patch

>+.memOverview table {
.memOverview > table
(Assignee)

Comment 4

7 years ago
Created attachment 443202 [details] [diff] [review]
patch v2 [Checkin: comment 5]
Attachment #441614 - Attachment is obsolete: true
Attachment #443202 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: helpwanted
(Assignee)

Comment 5

7 years ago
Comment on attachment 443202 [details] [diff] [review]
patch v2 [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/475ee6344218
Attachment #443202 - Attachment description: patch v2 → patch v2 [Checkin: comment 5]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
You need to log in before you can comment on or make changes to this bug.