Closed Bug 520476 Opened 10 years ago Closed 10 years ago

Pick up latest LDAP c-sdk fixes

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 520401 (Work around Mac ppc/gcc 4.2 compiler hang in ufn.c) means comm-central is going to need to pick up a newer LDAP c-sdk release.

At the same time, as long as there are no big changes I think we may as well pick up the latest LDAP c-sdk for Thunderbird 3.
Current changes in LDAP c-sdk not in comm-central version:

* added support for MozillaBuild using msys (no bug)
* Bug 485690: LDAP SSL connections with clientauth sometimes use wrong credentials
* Bug 436981: LDAP c-sdk: configure detects x86_64 linux as x86.
* Bug 500001: fix compiler warnings in c-sdk/ldap
** This is mainly just fixes to debug printfs etc or NULL -> 0 or unused variable warnings.
* Bug 511817 Malformed Packet appears in network trace of SASL binding.
(In reply to comment #1)
> Current changes in LDAP c-sdk not in comm-central version:
> 
> * added support for MozillaBuild using msys (no bug)

Unfortunately our try server showed that this change is suspect. I therefore backed it out before I tagged the LDAP c-sdk.

I will file a follow up bug later.

These bugs will be incorporated:

> * Bug 485690: LDAP SSL connections with clientauth sometimes use wrong
> credentials
> * Bug 436981: LDAP c-sdk: configure detects x86_64 linux as x86.
> * Bug 500001: fix compiler warnings in c-sdk/ldap
> ** This is mainly just fixes to debug printfs etc or NULL -> 0 or unused
> variable warnings.
> * Bug 511817 Malformed Packet appears in network trace of SASL binding.

as will

* Bug 520401 Work around Mac ppc/gcc 4.2 compiler hang in ufn.c

The tag is LDAPCSDK_6_0_6C_MOZILLA_RTM.
Patch which updates the tag. All the changes have been reviewed by the LDAP C-sdk team, therefore r/sr=me for the upgrade.

a=me as there isn't anything large in the changes that could cause significant regressions, and I believe we've got enough ldap users that we would find issues before final.
Attachment #404904 - Flags: superreview+
Attachment #404904 - Flags: review+
Attachment #404904 - Flags: approval-thunderbird3+
I ended up having to take a bustage fix for some incorrect non-c-style comments. So we ended up with the tag: LDAPCSDK_6_0_6D_MOZILLA_RTM

http://hg.mozilla.org/comm-central/rev/e2154e9d6b01

This bug is now fixed. I'm currently doing a try server build with LDAP c-sdk HEAD to see about the issue with "added support for MozillaBuild using msys", if that fails again I'll raise an appropriate bug.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.