520706 - Attachment checker doesn't work with CJK keyword

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Makoto Kato [:m_kato]]

- Step
1. Open [Options] - [General] - [Keywords...]
2. Fill CJK word such as "添付", and [OK]
3. Turned on [Check for missing attachments], and [OK]
4. Open compose window and input CJK such as 2.'s word

- Result
Alert bar disappear.  If keyword is ASCII, it works find.

- Expected Result
Work fine even if CJK.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 404754 [details] [diff] [review]
patch v1


>+function IsCJKWord(aWord)
>+{
>+  for (i = 0; i < aWord.length; i++)

var i

>+    if (aWord.charCodeAt(i) >= 0x2000)
>+      return true;

Hm, this looks to be too wide. 
For instance xåäöy will be interpreted as a cjkword, which it's not.

Looks like the MDC example might be helpful, 
https://developer.mozilla.org/En/Core_JavaScript_1.5_Reference/Global_Objects/String/CharCodeAt

Comment 4

[Makoto Kato [:m_kato]]

Attachment: patch v2

Comment 5

[Magnus Melin [:mkmelin]]

V2 doesn't work, the attachment worker doesn't like "let". I don't know if we ever figured out exactly why.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: patch v2.1

oops.  I mistake attached patch.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 405975 [details] [diff] [review]
patch v2.1

Thanks for the patch! r=mkmelin

Comment 8

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/comm-central/rev/df3840aff5bf

Comment 9

[Philip Chee]

> +      // Hiragana, Katakana and Kanaji
Hmm? "Kanaji" should be Kanji, no? (感[じ])

Comment 10

[Ludovic Hirlimann [:Usul]]

Could we get a unit test for this ?

Comment 11

[Makoto Kato [:m_kato]]

(In reply to comment #9)
> Hmm? "Kanaji" should be Kanji, no? (感[じ])

Ahh, this is typo of Kanji.

(In reply to comment #10)
> Could we get a unit test for this ?

Is there unit test of attachment checker??

Comment 12

[Magnus Melin [:mkmelin]]

No it doesn't have any test yet. If you're up to it it would be nice to have though.