520797 - In compose message, missing "Display Name" for accounts' from-identities in Sender dropdown

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[[:Aureliano Buendía]]

Attachment: screenshot

I have create a new account because my provider has changed pop3 and smtp parameters and I cannot connect with the old even if I have changed server settings.

In this "new" account (the old with new server settings) I have migrate all my old mails: all work fine.

I see that in my "new" account when I open compose window, I have only 

<[e-mail]><Account Name> 

and not as in the old

<Your Name><[e-mail]><Account Name> 

attached a screenshot for detail.

Comment 1

[Ludovic Hirlimann [:Usul]]

This WFM , but I skipped the "migration" phase. 
Aureliano, anything in the Error Console that might be related ?
Can you also double check your identities in your account's settings ?

Comment 2

[[:Aureliano Buendía]]

Attachment: identity screenshot

(In reply to comment #1)
> This WFM , but I skipped the "migration" phase. 
> Aureliano, anything in the Error Console that might be related ?
Nothing

> Can you also double check your identities in your account's settings ?
attached screenshot about identity window

Comment 3

[Thomas D. (:thomas8)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091007 Shredder/3.0pre

I am seeing the same: Sender dropdown in tb3.0pre has only
<[e-mail]> /Account name/
Ludovic, you still don't see this in tb3.0pre?

And it's a regression from TB2, where we show all from-identities in sender-dropdown of compose window like this:

User Name <[e-mail]> /Account name/

As email addresses can be cryptic, and identities can have all sorts of funny display names, surely we do want to include the sender's display name for each indentity as we do in TB2.

Comment 4

[Thomas D. (:thomas8)]

Aurelio, it's a bit unfortunate that you use angle brackets <> for "display name", which is confusing because they are usually used for <email@addresses>. The missing part here really is the "Your Name" display name as specified in Account's identities.

Comment 5

[Thomas D. (:thomas8)]

Which file should we be looking at to patch this? (mxr-link wanted!)

Though it's not hurting or breaking, it's in a kinda exposed UI position and many people will feel insecure when they don't know if their "real name" gets sent and how.

Comment 6

[Thomas D. (:thomas8)]

This happens on a clean install with fresh profile.
Can you post an mxr link for this?

Small as it may be, IMO this is another one with potential for embarassement. We're regressing on one of the very basic mail features here: Wysiwyg composition - show the sender's display name as it will appear in the mail. Each time when composing, I'm now feeling insecure (and the newbie user even more so) - will it send with my display name or just my cryptic email address?

Current: From field in composition shows: <[e-mail]> /account name/
Expected: From field should show: Tom Durban <[e-mail]> /account name/
This affects only the account's primary identity.

Unfortunately I can't ask for blocking 3.1 (since it's disabled), so for the meantime I'll have no choice but do the right thing and ask for blocking 3.0. ;)
And btw devs, don't get me wrong:

*****All of you are doing a great job and thanks for fighting to get our babe out the door while wrestling with bugs and time.*****

Comment 7

[Thomas D. (:thomas8)]

(In reply to comment #6)

> And btw devs: ... 
> *****All of you are doing a great job and thanks for fighting to get our babe
> out the door while wrestling with bugs and time...
... and me! 8-)) *eg*

Comment 8

[Mark Banner (:standard8)]

Attachment: The fix

I took a look at this and found that the new account wizard is setting the identityName attribute on the identity to the email address.

Taking a look at the rest of the code [1] we don't ever set the identityName except within the import code. If you get the identity name without it having previously been set, then you'll get "Full Name <email>" back, which is what we want.

So we clearly want to remove the extra setting. I don't think we can do anything for those that have already created accounts, but we can stop things getting worse.

[1] http://mxr.mozilla.org/comm-central/search?string=identityName&find=/mail

Comment 9

[Mark Banner (:standard8)]

Checked into trunk:
http://hg.mozilla.org/comm-central/rev/2bc973ade85c

For those people affected by this, it can be "fixed" by removing the mail.identity.*.identityName preference via about:config or other method (this will revert to using "Full Name <email>".

Comment 10

[Mark Banner (:standard8)]

(oh I'm leaving this open for the blocking? status as its easier to track for now).

Comment 11

[Mark Banner (:standard8)]

This will land for build 3 in a while.

Comment 12

[Mark Banner (:standard8)]

Checked into 1.9.1:

(default): http://hg.mozilla.org/releases/comm-1.9.1/rev/c7e876a749ab
(relbranch): http://hg.mozilla.org/releases/comm-1.9.1/rev/0590a6e1d026

Comment 13

[Ludovic Hirlimann [:Usul]]

Aureliano Thomas could you check that Build 3 fixes that. I never even saw the issue.

Comment 14

[[:Aureliano Buendía]]

I have already apllied the workaround in comment #9 :-( (work fine)

Comment 15

[Thomas D. (:thomas8)]

(In reply to comment #14)
> I have already apllied the workaround in comment #9 :-( (work fine)
Same for me :-(   Where can we download build3?

Comment 16

[Ludovic Hirlimann [:Usul]]

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/3.0rc1-candidates/build3/

Comment 17

[Phil Lacy]

I noticed this when working on OE import(1). Can I resolve dupe bug 470587 or do we want to make one or more of the changes I suggested there(2).

(1) http://mxr.mozilla.org/comm-central/source/mailnews/import/oexpress/nsOESettings.cpp#776
(2) http://mxr.mozilla.org/comm-central/source/mailnews/base/util/nsMsgIdentity.cpp#102

Comment 18

[Ludovic Hirlimann [:Usul]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.7) Gecko/20100107 Shredder/3.0.1pre

And Next time I'll see the issue. I just need to read the description properly.