520899 - Switch application/x-javascript to application/javascript, MailNews Core part

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Serge Gautherie (:sgautherie)]

"Found 214 matching lines in 72 files",
but these include some "/suite/mailnews/*".

Hint: use a tool.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) All .xul files [Checkin: Comment 4]

Used a tool to replace
|<script type="application/x-javascript"|
by
|<script type="application/javascript"|

*.xul: 138 occurrences.


"approval-thunderbird3=?":
no risk, nice little cleanup/improvement.

Comment 2

[Phil Ringnalda (:philor)]

Note that the reason the bug this blocks exists is to switch over consumers and then change the ordering in nsXULContentSink.cpp, because it's currently (microscopically) slower to use application/javascript than to use application/x-javascript. So a more accurate approval risk/reward statement would be "absolutely no benefit whatsoever, risk that something we do oddly in an obscure corner of the UI will break unnoticed, risk that the absolutely certain decrease in performance will actually be noticeable/measurable."

Comment 3

[Mark Banner (:standard8)]

Based on comment 2 I'm not going to look at this until sometime after we branch. Would be good if nsXULContentSink.cpp was fixed on trunk and/or 1.9.2 around the time we land this.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 405058 [details] [diff] [review]
(Av1) All .xul files
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/344cc299f519

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) A couple related nits in .xul files [Checkin: Comment 6]

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 415850 [details] [diff] [review]
(Bv1) A couple related nits in .xul files
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/fa23a691726d

Comment 7

[Serge Gautherie (:sgautherie)]

What's left:
[
/mailnews/test/data/bug132340
    * line 17 -- Content-Type: application/x-javascript
/mailnews/compose/src/nsMsgCompUtils.cpp
    * line 1500 -- "application/x-javascript",
]
The former is test data: it can stay as is. (unless you want me to update it.)
The latter is a list item: the list might need some update, but the item can stay as is wrt this bug.