Closed Bug 520899 Opened 10 years ago Closed 10 years ago

Switch application/x-javascript to application/javascript, MailNews Core part

Categories

(MailNews Core :: Backend, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

"Found 214 matching lines in 72 files",
but these include some "/suite/mailnews/*".

Hint: use a tool.
Flags: in-testsuite-
Whiteboard: [good first bug]
Used a tool to replace
|<script type="application/x-javascript"|
by
|<script type="application/javascript"|

*.xul: 138 occurrences.


"approval-thunderbird3=?":
no risk, nice little cleanup/improvement.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #405058 - Flags: superreview?(bugzilla)
Attachment #405058 - Flags: review?(bugzilla)
Attachment #405058 - Flags: approval-thunderbird3?
Attachment #405058 - Flags: approval-thunderbird3?
Note that the reason the bug this blocks exists is to switch over consumers and then change the ordering in nsXULContentSink.cpp, because it's currently (microscopically) slower to use application/javascript than to use application/x-javascript. So a more accurate approval risk/reward statement would be "absolutely no benefit whatsoever, risk that something we do oddly in an obscure corner of the UI will break unnoticed, risk that the absolutely certain decrease in performance will actually be noticeable/measurable."
Based on comment 2 I'm not going to look at this until sometime after we branch. Would be good if nsXULContentSink.cpp was fixed on trunk and/or 1.9.2 around the time we land this.
Whiteboard: [good first bug] → [needs branch]
Attachment #405058 - Flags: superreview?(bugzilla)
Attachment #405058 - Flags: superreview+
Attachment #405058 - Flags: review?(bugzilla)
Attachment #405058 - Flags: review+
Whiteboard: [needs branch]
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 405058 [details] [diff] [review]
(Av1) All .xul files
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/344cc299f519
Attachment #405058 - Attachment description: (Av1) All .xul files → (Av1) All .xul files [Checkin: Comment 4]
Attachment #415850 - Flags: superreview?(bugzilla)
Attachment #415850 - Flags: review?(bugzilla)
Attachment #415850 - Flags: superreview?(bugzilla)
Attachment #415850 - Flags: superreview+
Attachment #415850 - Flags: review?(bugzilla)
Attachment #415850 - Flags: review+
Comment on attachment 415850 [details] [diff] [review]
(Bv1) A couple related nits in .xul files
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/fa23a691726d
Attachment #415850 - Attachment description: (Bv1) A couple related nits in .xul files → (Bv1) A couple related nits in .xul files [Checkin: Comment 6]
What's left:
[
/mailnews/test/data/bug132340
    * line 17 -- Content-Type: application/x-javascript
/mailnews/compose/src/nsMsgCompUtils.cpp
    * line 1500 -- "application/x-javascript",
]
The former is test data: it can stay as is. (unless you want me to update it.)
The latter is a list item: the list might need some update, but the item can stay as is wrt this bug.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.