381467 - [meta] Switch application/x-javascript to application/javascript

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

For lack of a better product/component...

I'll be filing and fixing bugs for the various parts of our tree.  We need to then fix http://lxr.mozilla.org/mozilla/source/content/xul/document/src/nsXULContentSink.cpp#1018 so that it's in a more sensible order.

Comment 1

[Nickolay_Ponomarev]

Do we absolutely have to have multiple bugs/patches for this?

Comment 2

[Nickolay_Ponomarev]

And for the reference - from bug 380250:

--- Comment #39 from Christian Biesinger (:bi) <[e-mail]>  2007-05-21 09:33:14 PDT ---
(In reply to comment #37)
> Is application/javascript preferred over application/x-javascript now? Why? The
> x-javascript version is the de-facto standard in moz code - see

application/javascript has been registered recentlyish,
http://www.rfc-editor.org/rfc/rfc4329.txt

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Do we absolutely have to have multiple bugs/patches for this?

Well, mxr/lxr searches get too many results fast, so that's a big reason why I'm splitting it up.  Also, it's easier to get reviewed with bugs in specific areas.

Comment 4

[Shawn Wilsher :sdwilsh]

For clarification purposes, everything in our backend ought to be using the same thing, so we can fix nsXULContentSink.cpp such that it is optimized properly (right now it's application/x-javascript, but we have places in the code base that use application/javascript).

Comment 5

[Shawn Wilsher :sdwilsh]

Assigning this to myself to keep it on my radar.

Comment 6

[Serge Gautherie (:sgautherie)]

Current status:
Found 537 matching lines in 211 files

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) /security/manager/pki/* [Checkin: Comment 9]

Used a tool to replace
|<script type="application/x-javascript"|
by
|<script type="application/javascript"|

"Found 71 matching lines in 27 files"

Comment 8

[Honza Bambas (:mayhemer)]

Comment on attachment 406012 [details] [diff] [review]
(Av1) /security/manager/pki/*
[Checkin: Comment 9]

r=honzab

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 406012 [details] [diff] [review]
(Av1) /security/manager/pki/*
[Checkin: Comment 9]


http://hg.mozilla.org/mozilla-central/rev/3a42ae54a001

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) /tools/performance/* [Checkin: Comment 12]

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 407409 [details] [diff] [review]
(Bv1) /tools/performance/*
[Checkin: Comment 12]

Was there a reason you prefer application/javascript to application/ecmascript or one of the other types?

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 407409 [details] [diff] [review]
(Bv1) /tools/performance/*
[Checkin: Comment 12]


http://hg.mozilla.org/mozilla-central/rev/6810cc6dc5db


(In reply to comment #11)
> Was there a reason you prefer application/javascript to application/ecmascript
> or one of the other types?

That was not my choice, but iiuc the rfc,
{
3.  Deployed Scripting Media Types and Compatibility
  The media types,
      * application/javascript
      * application/ecmascript
   which are also defined in this document, are intended for common use
   and should be used instead.

8.2.  application/ecmascript
      File extension(s):           .es
}
and ecmascript is "normalized" whereas javascript has new versions...

Comment 13

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) /docshell/resources/content/netError.xhtml [Checkin: Comment 21]

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) /layout/*, Fix some nits too

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 413329 [details] [diff] [review]
(Dv1) /layout/*, Fix some nits too

If you're going to do directory-wide cleanups for things like this, separate them by what you're cleaning up.  It's not worth my time to review a mix of whitespace changes and all sorts of other things.

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) /layout/base/crashtests/123946-1.html, EOL/whitespace fix (only) [Checkin: Comment 17]

Per your comment 15.

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 415063 [details] [diff] [review]
(Ev1) /layout/base/crashtests/123946-1.html, EOL/whitespace fix (only)
[Checkin: Comment 17]


http://hg.mozilla.org/mozilla-central/rev/091a108677ad

Comment 18

[Serge Gautherie (:sgautherie)]

Attachment: (Dv2) /layout/* and fix some related nits too

Per your comment 15.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 415068 [details] [diff] [review]
(Dv2) /layout/* and fix some related nits too

I think we want our tests to have the variation in types that reflects the real Web rather than making all of our tests switch to one thing.  The non-test changes (i.e., layout/tools) look fine, though.

Comment 20

[Serge Gautherie (:sgautherie)]

Attachment: (Dv3) /layout/tools/* [Checkin: Comment 23]

Per your comment 19.

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 413306 [details] [diff] [review]
(Cv1) /docshell/resources/content/netError.xhtml
[Checkin: Comment 21]


http://hg.mozilla.org/mozilla-central/rev/2337f12e8e9c

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 415875 [details] [diff] [review]
(Dv3) /layout/tools/*
[Checkin: Comment 23]

r=dbaron, if you remove "and fix some related nits too." from the description of the patch

Comment 23

[Serge Gautherie (:sgautherie)]

Comment on attachment 415875 [details] [diff] [review]
(Dv3) /layout/tools/*
[Checkin: Comment 23]


http://hg.mozilla.org/mozilla-central/rev/29224597307a

Comment 24

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) /layout/*, tests part

Comment 25

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 429994 [details] [diff] [review]
(Ev1) /layout/*, tests part

We should have a variety of approaches in our tests rather than switching everything to one, so we shouldn't do this.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:overholt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 27

[Andrew McCreight [:mccr8]]

Some patches landed here, so I think this can be marked fixed.