520902 - Missing nightly build for 1.9.1 on Windows (091006) - make buildsymbols bustage

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

While trying to upgrade from yesterdays Shiretoko build to get the todays version I didn't get an update offer. There has been not build created on Windows. Only builds for OS X and Linux are available.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/10/2009-10-06-03-mozilla-1.9.1/

As Nick said there was a bustage from bug 440001 which has been backed-out already.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I was little hasty. Bug 520141 landed before the nightly
  http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f7bcca52e1f9
which broke with 
/d/mozilla-build/python25/python /e/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py \
	  -c -i --vcs-info                                          \
	  -s /e/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build               \
	  /e/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/win32/dump_syms.exe                                                \
	  ./dist/crashreporter-symbols                                   \
	  . >                                        \
	  ./dist/crashreporter-symbols/firefox-3.5.4pre-WINNT-20091006044124-symbols.txt
Processing file: .\accessible\public\ia2\IA2Marshal.pdb
Unexpected error:  <type 'exceptions.NameError'>
Traceback (most recent call last):
  File "e:/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py", line 756, in <module>
    main()
  File "e:/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py", line 752, in main
    dumper.Process(arg)
  File "e:/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py", line 463, in Process
    return self.ProcessDir(file_or_dir)
  File "e:/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py", line 480, in ProcessDir
    if not self.ProcessFile(fullpath):
  File "e:/builds/moz2_slave/mozilla-1.9.1-win32-nightly/build/toolkit/crashreporter/tools/symbolstore.py", line 549, in ProcessFile
    self.SourceServerIndexing(file, guid, sourceFileStream, vcs_root)
NameError: global name 'vcs_root' is not defined
make: *** [buildsymbols] Error 1

Bug 4400001 landed after the nightly and was backed out, without apparently causing any bustage.

Setting blocking1.9.1? because this prevents us getting symbols for 3.5.4 builds. Should just be a backout to fix it but need to check all the details.

Comment 2

[(not currently active) Ted Mielczarek]

I think I backed out the wrong thing, actually. I think my *first* landing was a bad merge, and the second one actually fixed it, but then I backed that out because I thought that one broke things.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Ted's fix:
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=40e2100dcefe&tochange=09522dd1776e
Backs out the first set of changes, then relands the two fixes in the opposite order.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Dep and nightly builds succeeded on rev 09522dd1776e.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good. Update succeeded: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091006 Shiretoko/3.5.4pre (.NET CLR 3.5.30729) ID:20091006192334