52105 - [FIX]Use stylesheet disables @imported style if this uses another stylesheet [AltSS]

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Tobias Burnus]

This is with 2000-09-08-21/Linux.

Assume this:

1. One stylesheet foo (default or alternate)
2. Another stylesheet bar (not default, only alternate), which imports foo

The result is: If you select bar (via Use stylesheet), the values from foo ar
not applyed.

If you use bar as default, everything works as expected.

This should depend on bug 47760 (body text color persists longer than stylesheet
that set it)

For alternate stylesheets in general, see bug 6782 ([RFE] UI for alternate and
user stylesheets [IMPORT])

Comment 1

[Tobias Burnus]

Attachment: Test-case using Screen (default) and Print (alternate)

Comment 2

[Tobias Burnus]

Testing showed an workaround (in the webpage). If one uses:

* stylesheet "screen.css" title="screen"
* stylesheet "screen.css" media="all" title="screen"
* alternate stylesheet "print.css" media="all" title="print"

Then switching between screen and print works (none and others work as well).
The extra first line fixes not only mozilla's problem with importing screen in
print, but also netscape 4.x since it doesn't like media. (Testcase:
http://www.physik.fu-berlin.de/~fsi/ )

Comment 3

[Hixie (not reading bugmail)]

(marking alternate style sheet bugs for easy tracking...)

Comment 4

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 5

[Pierre Saslawsky]

The problem only happens when an alternate stylesheet imports another alternate 
stylesheet.  It works if it imports the default stylesheet.

Comment 6

[Pierre Saslawsky]

Attachment: sheet0.css

Comment 7

[Pierre Saslawsky]

Attachment: sheet1.css

Comment 8

[Pierre Saslawsky]

Attachment: sheet2.css

Comment 9

[Pierre Saslawsky]

Attachment: sheet3.css

Comment 10

[Pierre Saslawsky]

Attachment: sheet2.css (updated)

Comment 11

[Pierre Saslawsky]

Attachment: sheet3.css (updated)

Comment 12

[Pierre Saslawsky]

Attachment: testcase

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to fix

What happened here was that we would call InsertSheetInDoc on the top-level
sheet and set it to be disabled.  Then we walked down the SheetLoadData list
and cloned the sheet for the next insertion.  So the child sheet we added was
added already disabled.

All the patch does is to make sure InsertChildSheet enables the sheet (since I
can't think of any reason child sheets would start out disabled by default).

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 71167 [details] [diff] [review]
Patch to fix

r=dbaron

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->bzbarsky

Comment 16

[Marc Attinasi]

Comment on attachment 71167 [details] [diff] [review]
Patch to fix

sr=attinasi

Comment 17

[Mike Shaver (:shaver emeritus)]

Comment on attachment 71167 [details] [diff] [review]
Patch to fix

a=shaver for 0.9.9

Comment 18

[Boris Zbarsky [:bzbarsky]]

Checked in on trunk for 0.9.9

Comment 19

[Madhur Bhatia]

verified