Closed Bug 521134 Opened 16 years ago Closed 16 years ago

pendingRemoval flag set by autosync constraints, but not cleared

Categories

(MailNews Core :: Backend, defect)

x86
Windows NT
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

(Whiteboard: [no l10n impact])

Attachments

(1 file)

If you restrict the age of imap messages we'll download, or keep in the offline store, and we mark messages for pending removal, we won't clear the pending removal if you remove or relax the age restriction, so we'll keep purging those existing messages. I'm marking blocking because this has been biting me, and it can cause a lot of repeated downloads, and the fix is easy.
Flags: blocking-thunderbird3+
Whiteboard: [no l10n impact]
Attached patch proposed fixSplinter Review
This handles the case where the user had set an age constraint for offline imap messages, but then increased or removed it. Prior to this patch, the pendingRemoval property would stay on the msg hdr, and subsequent compacts would remove the offline msg. Most of the time, the code in ApplyRentionSettings will fix this, except if the user completely removes the age constraint, in which case, the code in the folder compactor will fix it going forward.
Attachment #405264 - Flags: superreview?(neil)
Attachment #405264 - Flags: review?(neil)
Whiteboard: [no l10n impact] → [no l10n impact][has patch for r/sr neil]
Attachment #405264 - Flags: superreview?(neil)
Attachment #405264 - Flags: superreview+
Attachment #405264 - Flags: review?(neil)
Attachment #405264 - Flags: review+
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [no l10n impact][has patch for r/sr neil] → [no l10n impact]
Depends on: 522357
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: