test_compactOfflineStore.js hangs for a long time - Not enough arguments [nsIMsgImapMailFolder.markPendingRemoval]

RESOLVED FIXED in Thunderbird 3.0rc1

Status

MailNews Core
Backend
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({fixed-seamonkey2.0.1})

Trunk
Thunderbird 3.0rc1
fixed-seamonkey2.0.1
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 406318 [details] [diff] [review]
The fix

I noticed this testing some patches earlier, test_compactOfflineStore.js hangs (0% cpu) for a long time (I'd actually thought a patch had broken it).

I ran it in interactive mode and found at the point it hangs:

[Exception... "Not enough arguments [nsIMsgImapMailFolder.markPendingRemoval]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/test_imap/unit/test_compactOfflineStore.js :: testPendingRemoval :: line 101"  data: no]

This is fallout from bug 521134.

The attached patch fixes the hang by providing the right number of arguments. It also changes the dump of an exception to a do_throw ensuring that the exception is actually handled as a failure rather than absorbing and hiding it.
Attachment #406318 - Flags: review?(bienvenu)

Comment 1

8 years ago
Comment on attachment 406318 [details] [diff] [review]
The fix

oops, thx, Mark.
Attachment #406318 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/1026c6a5c5d6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

Updated

8 years ago
Keywords: fixed-seamonkey2.0.1
You need to log in before you can comment on or make changes to this bug.