522357 - test_compactOfflineStore.js hangs for a long time - Not enough arguments [nsIMsgImapMailFolder.markPendingRemoval]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I noticed this testing some patches earlier, test_compactOfflineStore.js hangs (0% cpu) for a long time (I'd actually thought a patch had broken it).

I ran it in interactive mode and found at the point it hangs:

[Exception... "Not enough arguments [nsIMsgImapMailFolder.markPendingRemoval]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/test_imap/unit/test_compactOfflineStore.js :: testPendingRemoval :: line 101"  data: no]

This is fallout from bug 521134.

The attached patch fixes the hang by providing the right number of arguments. It also changes the dump of an exception to a do_throw ensuring that the exception is actually handled as a failure rather than absorbing and hiding it.

Comment 1

[David :Bienvenu]

Comment on attachment 406318 [details] [diff] [review]
The fix

oops, thx, Mark.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/1026c6a5c5d6