Closed Bug 521415 Opened 11 years ago Closed 11 years ago

[smtabmail] Lightning tab icons (calendar, tasks) don't show up in tabmail.

Categories

(SeaMonkey :: MailNews: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file)

SeaMonkeys tab icon image uses a class of tab-icon while Thunderbird uses tab-icon-image (isn't "-image" redundant here?). While both XBL implementations use inherits so that a list style image applied to the tab is used for the image, Thunderbird doesn't take advantage of this preferring to apply their CSS directly on the .tab-icon-image. And of course Lightning follows this convention.

To allow the Lightning tab icons to show up in SeaMonkey we should add the "tab-icon-image" class to your tabmail implementation. Nothing else in suite uses this so it should be safe.
One line patch, since it's unlikely that Calender or Thunderbird would change their CSS to suite us.
Attachment #405471 - Flags: superreview?(neil)
Attachment #405471 - Flags: review?(mnyromyr)
Comment on attachment 405471 [details] [diff] [review]
Patch v1.0 Add tab-icon-image class [Checkin: Comment 3]

Yeah, Firefox's tabbrowser initiated this oddity in bug 345466.
Attachment #405471 - Flags: superreview?(neil) → superreview+
Attachment #405471 - Flags: review?(mnyromyr)
Attachment #405471 - Flags: review+
Attachment #405471 - Flags: approval-seamonkey2.0+
Keywords: checkin-needed
Comment on attachment 405471 [details] [diff] [review]
Patch v1.0 Add tab-icon-image class [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/8a1125835a2e
Attachment #405471 - Attachment description: Patch v1.0 Add tab-icon-image class → Patch v1.0 Add tab-icon-image class [Checkin: Comment 3]
Severity: enhancement → normal
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
You need to log in before you can comment on or make changes to this bug.