345466 - Main Window Icon Replacement

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Michael Glenn]

Update of the icon set for the main window.

Comment 1

[Michael Glenn]

Attachment: Modifications to toolbar layout and styling for Winstripe

Patch contains changes to toolbar layout and styling changes to Winstripe theme. The address bar go button has been moved inside the address bar to move them together and the search button has been moved outside the textbox for styling.

Comment 2

[Michael Glenn]

Attachment: Update to bookmark icon

Comment 3

[Michael Glenn]

Attachment: Address bar Go button (RTL)

Comment 4

[Michael Glenn]

Attachment: Address bar Go button

Comment 5

[Michael Glenn]

Attachment: Page report button

Comment 6

[Michael Glenn]

Attachment: Search bar button replacement

Comment 7

[Michael Glenn]

Attachment: Search icon

Comment 8

[Michael Glenn]

Attachment: Search bar button replacement

Comment 9

[Michael Glenn]

Attachment: Main toolbar icon set, small size. (browser/themes/winstripe/browser/Toolbar-small.png)

Comment 10

[Michael Glenn]

Attachment: Main toolbar icon set (browser/themes/winstripe/browser/Toolbar.png)

Comment 11

[Dave Townsend [:mossop]]

Regarding the go button and search button, what happens when a user is using large fonts? Presumably the address bar and search bar get taller to accommodate the larger text. How will these buttons look then?

Comment 12

[Michael Glenn]

Attachment: Safe Browsing close button (browser/themes/winstripe/browser/safebrowsing/close16x16.png)

Comment 13

[Michael Glenn]

Attachment: Safe Browsing dimming overlay (browser/themes/winstripe/browser/safebrowsing/dim.png)

Comment 14

[Michael Glenn]

Attachment: Safe Browsing popup tail (browser/themes/winstripe/browser/safebrowsing/tail.png)

Comment 15

[Michael Glenn]

Attachment: Safe Browsing warning icon (small) (browser/themes/winstripe/browser/safebrowsing/warning16x16.png)

Comment 16

[Michael Glenn]

Attachment: Safe Browsing warning icon (large) browser/themes/winstripe/browser/safebrowsing/warning24x24.png

Comment 17

[Michael Glenn]

Attachment: Global error icon. (toolkit/themes/winstripe/global/icons/Error.png)

Comment 18

[Michael Glenn]

Attachment: Global landscape icon (toolkit/themes/winstripe/global/icons/Landscape.png)

Comment 19

[Michael Glenn]

Attachment: Global portrait icon (toolkit/themes/winstripe/global/icons/Portrait.png)

Comment 20

[Michael Glenn]

Attachment: Global print preview icon (toolkit/themes/winstripe/global/icons/Print-preview.png)

Comment 21

[Michael Glenn]

Attachment: Global question bubble icon (toolkit/themes/winstripe/global/icons/Question.png)

Comment 22

[Michael Glenn]

Attachment: Global warning icon (toolkit/themes/winstripe/global/icons/Warning.png)

Comment 23

[Michael Glenn]

Attachment: Global close icon (toolkit/themes/winstripe/global/icons/close.png)

Comment 24

[Michael Glenn]

Attachment: Global find icon (toolkit/themes/winstripe/global/icons/find.png)

Comment 25

[Michael Glenn]

Attachment: Global folder-item icon replacement

Comment 26

[Michael Glenn]

Attachment: Global not found icon (toolkit/themes/winstripe/global/icons/notfound.png)

Comment 27

[Michael Glenn]

Attachment: Global warning (large) icon (toolkit/themes/winstripe/global/icons/warning-large.png)

Comment 28

[Michael Glenn]

Attachment: Global wrap icon (toolkit/themes/winstripe/global/icons/wrap.png)

Comment 29

[Michael Glenn]

Attachment: Global file picker (toolkit/themes/winstripe/global/filepicker/Filepicker.png)

Comment 30

[Dão Gottwald [:dao]]

(In reply to comment #10)
> Created an attachment (id=230939) [edit]
> Main toolbar icon set (browser/themes/winstripe/browser/Toolbar.png)

The reload button does not look clean to me, because the color trespasses the dark edge.
I've already noticed this with the mockup. But, well, I thought would be just a mockup.

Comment 31

[Michael Glenn]

Attachment: Drop nav icon for forward and back buttons (browser/themes/winstripe/browser/dropmark-nav.png)

Comment 32

[Michael Glenn]

Attachment: Drop mark icon for forward and back button (small) (browser/themes/winstripe/browser/dropmark-nav-small.png)

Comment 33

[Mike Connor [:mconnor]]

Comment on attachment 230917 [details] [diff] [review]
Modifications to toolbar layout and styling for Winstripe

Waiting on a patch that handles RTL a lot better.

Comment 34

[Jonathan Haas]

> Created an attachment (id=230917) [edit]

>  .searchbar-textbox {
> +  height: 22px;

I believe, this causes problems on larger text sizes.

(In reply to comment #11)
> Regarding the go button and search button, what happens when a user is using
> large fonts? Presumably the address bar and search bar get taller to
> accommodate the larger text. How will these buttons look then?

This is a similar problem...

Comment 35

[Dave Townsend [:mossop]]

Comment on attachment 230917 [details] [diff] [review]
Modifications to toolbar layout and styling for Winstripe

>+	skin/classic/browser/Search-provider-bkgnd.png

This is this files only mention in the patch and the file itself is not attached here. Is this needed?

Comment 36

[Michael Bodalski]

Attachment: Pinstripe Icon Replacement

Comment 37

[Michael Bodalski]

Attachment: Mozilla > browser > themes > pinstripe > browser contents a-m

Comment 38

[Michael Bodalski]

Attachment: Mozilla > browser > themes > pinstripe > browser contents n-z

Comment 39

[Michael Bodalski]

Attachment: Dropmark graphic for pinstripe theme with small icons

Replace the dropmark-nav-small.png in the previous attachment (zip file) with this file.

Comment 40

[Michael Bodalski]

Attachment: Toolbar graphic for pinstripe theme with small icons

Replace the Toolbar-small.png in the previous attachment (zip file) with this file. File should be in Mozilla > browser > themes > pinstripe > browser.

Comment 41

[Michael Bodalski]

Attachment: Pinstripe Icon Replacement - Updated

Updated diff to replace patch posted at 11:32 PDT 2006-08-01. Incorporates the updated "small icon" graphics posted previously.

Comment 42

[Mike Connor [:mconnor]]

Comment on attachment 231621 [details] [diff] [review]
Pinstripe Icon Replacement

waiting for updates, there were a few issues here

Comment 43

[Jackie Liu]

I have two suggestions: 

By what I see at http://wiki.mozilla.org/FX2_Visual_Update/Default_Theme_Update, I have two suggestions.  

1. The RSS thing should be left alone from previous versions and only come up when there is a RSS feed detected, instead of living in the bar and lighting up when there's a feed as proposed.
2. The round "loading" icon should where it in previous versions by default, up there with the menus.  I know it's movable, but yeah.

Otherwise, it looks great!

Comment 44

[Jackie Liu]

One more thing.  I think that the user should have a choice of the current theme or the new theme when upgrading/installing and/or both themes should be in the Add-ons>Themes window for the users choice.

Comment 45

[Jay Goldman]

Attachment: Pinstripe: theme for the tabstrip

Comment 46

[Jay Goldman]

Attachment: Pinstripe: images for tabstrip theme

Images should be placed in mozilla/toolkit/themes/pinstripe/global/

Comment 47

[Joe Hughes]

Attachment: WIP Winstripe changes (just an un-bitrotting update)

Comment 48

[Michael Bodalski]

Attachment: Update of all changes made to Winstripe theme

I tried a few times to set up .cvsignore files that would filter out some of the extra files with no luck. This file will be proceeded by zip files containing all the most current artwork.

Comment 49

[Reed Loden [:reed]]

Comment on attachment 231885 [details] [diff] [review]
Update of all changes made to Winstripe theme

Please post unified diffs (diff -u). :)

Comment 50

[Michael Bodalski]

Attachment: Part 1 of 2 content of : mozilla > browser > themes > winstripe > browser

Comment 51

[Michael Bodalski]

Attachment: Part 2 of 2 content of : mozilla > browser > themes > winstripe > browser

Comment 52

[Mike Connor [:mconnor]]

Attachment: previous winstripe patch, with context

Comment 53

[Jay Goldman]

Attachment: Pinstripe: theme for the tabstrip v2

Replaces the previous patch with a more up to date one, removing mentions in jar.mn of unused files and including all of the correct images in the associated .zip file (see next attachment).

Comment 54

[Jay Goldman]

Attachment: Pinstripe: images for tabstrip theme v2

Replaces the previously uploaded set of images with a more correct one that actually includes all the right files.

Comment 55

[Jay Goldman]

Attachment: Pinstripe: images for tabstrip theme v2

Replaces the previously uploaded set of images with a more correct one that actually includes all the right files.

Comment 56

[Joe Hughes]

Attachment: WIP winstripe searchbar changes

Comment 57

[Joe Hughes]

Attachment: winstripe searchbar patch

Comment 58

[u88484]

Joe Hughes, the lanscape icon is wrong. The person in the icon shouldn't be on the side...only the paper.

https://bugzilla.mozilla.org/attachment.cgi?id=230953

It's wrong in the current theme also.

Comment 59

[Jay Goldman]

Attachment: Winstripe tabstrip patch.

Patch to style winstripe tabstrip

Comment 60

[Jay Goldman]

Attachment: Winstripe tabstrip icons for patch

Icons to go along with the winstripe tabstrip patch.

Comment 61

[Jay Goldman]

Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

A couple of minor CSS tweaks still required:

- Hover state for alltabs-box
- alltabs-box is a few pixels off the right edge of the window when in overflow
- 1 px gap appears in background tabs only with some number of tabs open
- RTL may require some small tweaks

Comment 62

[Asaf Romano (gone)]

Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

please get rif of the change for spaces to hard tabs.

Comment 63

[Asaf Romano (gone)]

Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 


>Index: toolkit/content/widgets/tabbrowser.xml
>===================================================================

>   <binding id="tabbrowser-tab" display="xul:box"
>            extends="chrome://global/content/bindings/tabbox.xml#tab">
>     <content chromedir="&locale.dir;"
>              closetabtext="&closeTab.label;">
>+      <xul:hbox class="tab-left" xbl:inherits="selected"/>
>       <xul:hbox class="tab-middle box-inherit" xbl:inherits="align,dir,pack,orient,selected" flex="1">
>         <xul:image class="tab-icon" xbl:inherits="validate,src=image"/>
>         <xul:label class="tab-text" xbl:inherits="value=label,accesskey,crop,disabled" flex="1"/>
>       </xul:hbox>
>       <xul:image anonid="close-button-placeholder" class="tab-close-button-placeholder"/>
>       <xul:toolbarbutton anonid="close-button" class="tab-close-button"/>
>+      <xul:hbox class="tab-right" xbl:inherits="selected"/>
>     </content>
> 

The overriding binding of Pinstripe should be updated in parallel (even if you're not going to use these as selectos in Pinstripe)

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/globalBindings.xml#15

Comment 64

[Jay Goldman]

(In reply to comment #63)

> The overriding binding of Pinstripe should be updated in parallel (even if
> you're not going to use these as selectos in Pinstripe)

I agree - I'd actually like to see the Pinstripe selectors change from tab-image-left, tab-image-middle, and tab-image-right to just tab-left, tab-middle, and tab-right as the hbox with class tab-image-middle actually contains the icon, text, and close button (not just an image). Thoughts?

Comment 65

[Peter Weilbacher]

Is it possible that the checkins for some of the files in at least browser/themes/winstripe/browser/ got messed up on the 1.8 branch (binary option forgotten)? I cannot get any good checkouts of these files:
   browser/themes/winstripe/browser/dropmark-nav-rtl-small.png
   browser/themes/winstripe/browser/dropmark-nav-rtl.png
   browser/themes/winstripe/browser/dropmark-nav-small.png
   browser/themes/winstripe/browser/dropmark-nav.png
   browser/themes/winstripe/browser/Search-provider-bkgnd.png
   browser/themes/winstripe/browser/Search-rtl.png
   browser/themes/winstripe/browser/Toolbar-rtl-small.png
   browser/themes/winstripe/browser/Toolbar-rtl.png

Comment 66

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #65)
> Is it possible that the checkins for some of the files in at least
> browser/themes/winstripe/browser/ got messed up on the 1.8 branch (binary
> option forgotten)?

Ah, indeed, I forgot to mark them as binary.  I just attempted a fix - can you retry?

Comment 67

[Peter Weilbacher]

Yes, thanks. Now it works.

Comment 68

[Mike Connor [:mconnor]]

Will be testing/landing the winstripe stuff here later this evening.

Comment 69

[ronin.achilles]

(In reply to comment #68)
> Will be testing/landing the winstripe stuff here later this evening.
> 

Any indication as to when the Tabstrip patch for Winstripe will land on Branch? so that we can get some time to test for possible regressions.

Comment 70

[Pam Greene]

Comment on attachment 232037 [details] [diff] [review]
winstripe searchbar patch

Marking Joe's winstripe searchbox patch obsolete, since it's been de-bitrotted and rolled into the patch for bug 347400.

Comment 71

[Mike Connor [:mconnor]]

Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

So, as discussed, what we want to do here is use the same approach as Pinstripe and not hack the main binding structure.

Comment 72

[Mike Connor [:mconnor]]

Comment on attachment 231981 [details] [diff] [review]
Pinstripe: theme for the tabstrip v2

this was already landed

Comment 73

[Jay Goldman]

Attachment: Pinstripe image replacements (new home, new reload, tinted disabled states)

This update to the Pinstripe icons fixes:

1) New Home button with a more colourful door
2) New Reload button without the back of the arrows
3) Tinted disabled states throughout the theme to better match OS X

Files need to be distributed as per the enclosed folder structure.

Comment 74

[Jay Goldman]

Attachment: Winstripe image replacements (New Home button, New Reload button)

Comment 75

[Jay Goldman]

Attachment: Winstripe image replacements (New Home button, New Reload button with improved small icon)

Tweaked the small version of reload to sharpen the arrowheads and make them more visibly arrowheads and less visibly blobs.

Comment 76

[Jay Goldman]

Attachment: Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)

(replaces previously uploaded Pinstripe image replacements)

Update to the Pinstripe images for the Toolbar, including:

1- New Home icon with different door
2- New Reload icon without the back of the arrows
3- Tinted disabled states to match OS X
4- Modified dropmarkers for Back/Forward to better match the colours of the dropmarker background to the actual Back/Forward buttons in hover and active states

Note: you'll also need to apply the "Pinstripe Back/Forward Dropmark Position" patch, which follows.

Comment 77

[Jay Goldman]

Attachment: Pinstripe Patch for Back/Forward Dropmark Position

Requires the previously uploaded "Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)"

Comment 78

[Jay Goldman]

Attachment: Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)

Wrong file last time :)

Comment 79

[Peter Kasting]

(In reply to comment #75)
> Created an attachment (id=233500) [edit]
> Winstripe image replacements (New Home button, New Reload button with improved
> small icon)
> 
> Tweaked the small version of reload to sharpen the arrowheads and make them
> more visibly arrowheads and less visibly blobs.

It looks like the upper arrow on the small reload icons has one or two light-grey pixels to the left of the head for some reason.

Comment 80

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060813 BonEcho/2.0b1 ID:2006081323

icons on Add-ons Manager is not changed to new icons.
still "blue" home button.

Comment 81

[Mike Connor [:mconnor]]

Attachment: winstripe tabstrip, rolls up other tabbrowser fixes for branch

Whee, Winstripe tabstrip is done-ish.

Also fixes the following issues on branch:

1) Seth's fix for bug #347783:  Tab listing bar loses styling after tab overflow background animation
2) Seth's fix for bug #348293: hover state on alltabs box doesn't work.  Hover should also work over the scrollbutton-down in the tabstrip for both winstripe and pinstripe
3) asaf's fix for bug #345257 (all tabs tooltip)
4) asaf's fix for bug #348362 (don't focus on a tab when mousing down on it's close button)

Known issues: 
RTL might suck (will follow up before freeze-time)

Comment 82

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234099 [details] [diff] [review]
winstripe tabstrip, rolls up other tabbrowser fixes for branch

a=beltzner on behalf of drivers, for landing on the MOZILLA_1_8_BRANCH. Please mark fixed1.8.1 when it lands.

Comment 83

[Mike Connor [:mconnor]]

landed on branch.  Please file bugs on anything theme-related in a new bug, this bug is done. Thanks!

Comment 84

[Mike Connor [:mconnor]]

I just commited the /toolkit/themes/winstripe/global/icons images that were missed during the initial commit on Windows.