Main Window Icon Replacement

VERIFIED FIXED in Firefox 2 beta2

Status

()

VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: mglenn, Assigned: jgoldman)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta2
fixed1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change], URL)

Attachments

(46 attachments, 11 obsolete attachments)

513 bytes, image/png
mconnor
: review+
Details
2.26 KB, image/png
Details
2.25 KB, image/png
Details
539 bytes, image/png
Details
2.78 KB, image/png
Details
657 bytes, image/png
Details
2.78 KB, image/png
Details
27.42 KB, image/png
Details
52.74 KB, image/png
Details
797 bytes, image/png
Details
2.13 KB, image/png
Details
759 bytes, image/png
Details
735 bytes, image/png
Details
1.26 KB, image/png
Details
1.55 KB, image/png
Details
793 bytes, image/png
Details
739 bytes, image/png
Details
896 bytes, image/png
Details
1.40 KB, image/png
Details
1.47 KB, image/png
Details
1.85 KB, image/png
Details
3.02 KB, image/png
Details
1.93 KB, image/png
Details
696 bytes, image/png
Details
2.32 KB, image/png
Details
684 bytes, image/png
Details
6.08 KB, image/png
Details
3.37 KB, image/png
Details
3.19 KB, image/png
Details
33.25 KB, patch
Details | Diff | Splinter Review
123.66 KB, application/octet-stream
Details
254.65 KB, application/octet-stream
Details
3.17 KB, image/png
Details
31.50 KB, image/png
Details
35.22 KB, patch
Details | Diff | Splinter Review
74.56 KB, application/octet-stream
Details
266.21 KB, application/octet-stream
Details
47.17 KB, patch
Details | Diff | Splinter Review
19.00 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
11.88 KB, application/octet-stream
Details
23.43 KB, patch
mconnor
: review-
Details | Diff | Splinter Review
11.07 KB, application/octet-stream
Details
92.74 KB, application/octet-stream
Details
25.12 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
175.56 KB, application/octet-stream
mconnor
: review+
mconnor
: approval1.8.1+
Details
41.35 KB, patch
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
Update of the icon set for the main window.
Flags: blocking-firefox2+
(Reporter)

Comment 1

12 years ago
Created attachment 230917 [details] [diff] [review]
Modifications to toolbar layout and styling for Winstripe

Patch contains changes to toolbar layout and styling changes to Winstripe theme. The address bar go button has been moved inside the address bar to move them together and the search button has been moved outside the textbox for styling.
Attachment #230917 - Flags: review?(mconnor)
(Reporter)

Comment 2

12 years ago
Created attachment 230922 [details]
Update to bookmark icon
Attachment #230922 - Flags: review?(mconnor)
(Reporter)

Comment 3

12 years ago
Created attachment 230925 [details]
Address bar Go button (RTL)
Attachment #230925 - Flags: review?(mconnor)
(Reporter)

Comment 4

12 years ago
Created attachment 230927 [details]
Address bar Go button
Attachment #230927 - Flags: review?(mconnor)
(Reporter)

Comment 5

12 years ago
Created attachment 230930 [details]
Page report button
Attachment #230930 - Flags: review?(mconnor)
(Reporter)

Comment 6

12 years ago
Created attachment 230931 [details]
Search bar button replacement
Attachment #230931 - Flags: review?(mconnor)
(Reporter)

Comment 7

12 years ago
Created attachment 230933 [details]
Search icon
Attachment #230933 - Flags: review?(mconnor)
(Reporter)

Comment 8

12 years ago
Created attachment 230934 [details]
Search bar button replacement
Attachment #230934 - Flags: review?(mconnor)
(Reporter)

Comment 9

12 years ago
Created attachment 230937 [details]
Main toolbar icon set, small size. (browser/themes/winstripe/browser/Toolbar-small.png)
Attachment #230937 - Flags: review?(mconnor)
(Reporter)

Comment 10

12 years ago
Created attachment 230939 [details]
Main toolbar icon set (browser/themes/winstripe/browser/Toolbar.png)
Attachment #230939 - Flags: review?(mconnor)
Regarding the go button and search button, what happens when a user is using large fonts? Presumably the address bar and search bar get taller to accommodate the larger text. How will these buttons look then?
(Reporter)

Comment 12

12 years ago
Created attachment 230946 [details]
Safe Browsing  close button (browser/themes/winstripe/browser/safebrowsing/close16x16.png)
Attachment #230946 - Flags: review?(mconnor)
(Reporter)

Comment 13

12 years ago
Created attachment 230947 [details]
Safe Browsing dimming overlay (browser/themes/winstripe/browser/safebrowsing/dim.png)
Attachment #230947 - Flags: review?(mconnor)
(Reporter)

Comment 14

12 years ago
Created attachment 230948 [details]
Safe Browsing popup tail (browser/themes/winstripe/browser/safebrowsing/tail.png)
Attachment #230948 - Flags: review?(mconnor)
(Reporter)

Comment 15

12 years ago
Created attachment 230950 [details]
Safe Browsing warning icon (small)  (browser/themes/winstripe/browser/safebrowsing/warning16x16.png)
Attachment #230950 - Flags: review?(mconnor)
(Reporter)

Comment 16

12 years ago
Created attachment 230951 [details]
Safe Browsing warning icon (large) browser/themes/winstripe/browser/safebrowsing/warning24x24.png
Attachment #230951 - Flags: review?(mconnor)
(Reporter)

Comment 17

12 years ago
Created attachment 230952 [details]
Global error icon. (toolkit/themes/winstripe/global/icons/Error.png)
Attachment #230952 - Flags: review?(mconnor)
(Reporter)

Comment 18

12 years ago
Created attachment 230953 [details]
Global landscape icon (toolkit/themes/winstripe/global/icons/Landscape.png)
Attachment #230953 - Flags: review?(mconnor)
(Reporter)

Comment 19

12 years ago
Created attachment 230954 [details]
Global portrait icon (toolkit/themes/winstripe/global/icons/Portrait.png)
Attachment #230954 - Flags: review?(mconnor)
(Reporter)

Comment 20

12 years ago
Created attachment 230955 [details]
Global print preview icon (toolkit/themes/winstripe/global/icons/Print-preview.png)
Attachment #230955 - Flags: review?(mconnor)
(Reporter)

Comment 21

12 years ago
Created attachment 230957 [details]
Global question bubble icon (toolkit/themes/winstripe/global/icons/Question.png)
Attachment #230957 - Flags: review?(mconnor)
(Reporter)

Comment 22

12 years ago
Created attachment 230958 [details]
Global warning icon (toolkit/themes/winstripe/global/icons/Warning.png)
Attachment #230958 - Flags: review?(mconnor)
(Reporter)

Comment 23

12 years ago
Created attachment 230959 [details]
Global close icon (toolkit/themes/winstripe/global/icons/close.png)
Attachment #230959 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230958 - Attachment mime type: text/plain → image/png
(Reporter)

Comment 24

12 years ago
Created attachment 230960 [details]
Global find icon (toolkit/themes/winstripe/global/icons/find.png)
(Reporter)

Comment 25

12 years ago
Created attachment 230961 [details]
Global folder-item icon replacement
(Reporter)

Comment 26

12 years ago
Created attachment 230962 [details]
Global not found icon (toolkit/themes/winstripe/global/icons/notfound.png)
(Reporter)

Comment 27

12 years ago
Created attachment 230963 [details]
Global warning (large) icon (toolkit/themes/winstripe/global/icons/warning-large.png)
(Reporter)

Comment 28

12 years ago
Created attachment 230964 [details]
Global wrap icon (toolkit/themes/winstripe/global/icons/wrap.png)
(Reporter)

Comment 29

12 years ago
Created attachment 230965 [details]
Global file picker (toolkit/themes/winstripe/global/filepicker/Filepicker.png)
(In reply to comment #10)
> Created an attachment (id=230939) [edit]
> Main toolbar icon set (browser/themes/winstripe/browser/Toolbar.png)

The reload button does not look clean to me, because the color trespasses the dark edge.
I've already noticed this with the mockup. But, well, I thought would be just a mockup.
(Reporter)

Comment 31

12 years ago
Created attachment 230967 [details]
Drop nav icon for forward and back buttons (browser/themes/winstripe/browser/dropmark-nav.png)
(Reporter)

Comment 32

12 years ago
Created attachment 230968 [details]
Drop mark icon for forward and back button (small) (browser/themes/winstripe/browser/dropmark-nav-small.png)

Updated

12 years ago
Attachment #230922 - Flags: review?(mconnor) → review+

Updated

12 years ago
Attachment #230925 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230927 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230930 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230931 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230933 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230934 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230937 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230939 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230946 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230947 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230948 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230950 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230951 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230952 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230953 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230954 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230955 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230957 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230958 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #230959 - Flags: review?(mconnor)
Comment on attachment 230917 [details] [diff] [review]
Modifications to toolbar layout and styling for Winstripe

Waiting on a patch that handles RTL a lot better.
Attachment #230917 - Flags: review?(mconnor)

Comment 34

12 years ago
> Created an attachment (id=230917) [edit]

>  .searchbar-textbox {
> +  height: 22px;

I believe, this causes problems on larger text sizes.

(In reply to comment #11)
> Regarding the go button and search button, what happens when a user is using
> large fonts? Presumably the address bar and search bar get taller to
> accommodate the larger text. How will these buttons look then?

This is a similar problem...
Comment on attachment 230917 [details] [diff] [review]
Modifications to toolbar layout and styling for Winstripe

>+	skin/classic/browser/Search-provider-bkgnd.png

This is this files only mention in the patch and the file itself is not attached here. Is this needed?

Comment 36

12 years ago
Created attachment 231621 [details] [diff] [review]
Pinstripe Icon Replacement
Attachment #231621 - Flags: review?(mconnor)

Comment 37

12 years ago
Created attachment 231622 [details]
Mozilla > browser > themes > pinstripe > browser contents a-m
Attachment #231622 - Flags: review?(mconnor)

Comment 38

12 years ago
Created attachment 231624 [details]
Mozilla > browser > themes > pinstripe > browser contents n-z
Attachment #231624 - Flags: review?(mconnor)

Comment 39

12 years ago
Created attachment 231643 [details]
Dropmark graphic for pinstripe theme with small icons

Replace the dropmark-nav-small.png in the previous attachment (zip file) with this file.
Attachment #231643 - Flags: review?(mconnor)

Comment 40

12 years ago
Created attachment 231647 [details]
Toolbar graphic for pinstripe theme with small icons

Replace the Toolbar-small.png in the previous attachment (zip file) with this file. File should be in Mozilla > browser > themes > pinstripe > browser.
Attachment #231647 - Flags: review?(mconnor)

Comment 41

12 years ago
Created attachment 231651 [details] [diff] [review]
Pinstripe Icon Replacement - Updated

Updated diff to replace patch posted at 11:32 PDT 2006-08-01. Incorporates the updated "small icon" graphics posted previously.
Attachment #231651 - Flags: review?(mconnor)
Comment on attachment 231621 [details] [diff] [review]
Pinstripe Icon Replacement

waiting for updates, there were a few issues here
Attachment #231621 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231622 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231624 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231643 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231647 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231651 - Flags: review?(mconnor)

Comment 43

12 years ago
I have two suggestions: 

By what I see at http://wiki.mozilla.org/FX2_Visual_Update/Default_Theme_Update, I have two suggestions.  

1. The RSS thing should be left alone from previous versions and only come up when there is a RSS feed detected, instead of living in the bar and lighting up when there's a feed as proposed.
2. The round "loading" icon should where it in previous versions by default, up there with the menus.  I know it's movable, but yeah.

Otherwise, it looks great!

Comment 44

12 years ago
One more thing.  I think that the user should have a choice of the current theme or the new theme when upgrading/installing and/or both themes should be in the Add-ons>Themes window for the users choice.
(Assignee)

Comment 45

12 years ago
Created attachment 231822 [details] [diff] [review]
Pinstripe: theme for the tabstrip
Attachment #231822 - Flags: review?(mconnor)
(Assignee)

Comment 46

12 years ago
Created attachment 231823 [details]
Pinstripe: images for tabstrip theme

Images should be placed in mozilla/toolkit/themes/pinstripe/global/
Attachment #231823 - Flags: review?(mconnor)

Comment 47

12 years ago
Created attachment 231883 [details] [diff] [review]
WIP Winstripe changes (just an un-bitrotting update)
Attachment #230917 - Attachment is obsolete: true

Comment 48

12 years ago
Created attachment 231885 [details] [diff] [review]
Update of all changes made to Winstripe theme

I tried a few times to set up .cvsignore files that would filter out some of the extra files with no luck. This file will be proceeded by zip files containing all the most current artwork.
Attachment #231885 - Flags: review?(mconnor)
Comment on attachment 231885 [details] [diff] [review]
Update of all changes made to Winstripe theme

Please post unified diffs (diff -u). :)

Comment 50

12 years ago
Created attachment 231886 [details]
Part 1 of 2 content of : mozilla > browser > themes > winstripe > browser
Attachment #231886 - Flags: review?(mconnor)

Comment 51

12 years ago
Created attachment 231887 [details]
Part 2 of 2 content of : mozilla > browser > themes > winstripe > browser
Attachment #231887 - Flags: review?(mconnor)

Updated

12 years ago
Attachment #231883 - Attachment is obsolete: true
Created attachment 231950 [details] [diff] [review]
previous winstripe patch, with context
Attachment #231885 - Attachment is obsolete: true
Attachment #231885 - Flags: review?(mconnor)
(Assignee)

Comment 53

12 years ago
Created attachment 231981 [details] [diff] [review]
Pinstripe: theme for the tabstrip v2

Replaces the previous patch with a more up to date one, removing mentions in jar.mn of unused files and including all of the correct images in the associated .zip file (see next attachment).
Attachment #231822 - Attachment is obsolete: true
Attachment #231981 - Flags: review?(mconnor)
Attachment #231822 - Flags: review?(mconnor)
(Assignee)

Comment 54

12 years ago
Created attachment 231982 [details]
Pinstripe: images for tabstrip theme v2

Replaces the previously uploaded set of images with a more correct one that actually includes all the right files.
Attachment #231823 - Attachment is obsolete: true
Attachment #231982 - Flags: review?(mconnor)
Attachment #231823 - Flags: review?(mconnor)
(Assignee)

Comment 55

12 years ago
Created attachment 231983 [details]
Pinstripe: images for tabstrip theme v2

Replaces the previously uploaded set of images with a more correct one that actually includes all the right files.
(Assignee)

Updated

12 years ago
Attachment #231982 - Attachment is obsolete: true
Attachment #231982 - Flags: review?(mconnor)

Comment 56

12 years ago
Created attachment 232017 [details] [diff] [review]
WIP winstripe searchbar changes

Comment 57

12 years ago
Created attachment 232037 [details] [diff] [review]
winstripe searchbar patch
Attachment #232017 - Attachment is obsolete: true

Updated

12 years ago
Depends on: 347399

Comment 58

12 years ago
Joe Hughes, the lanscape icon is wrong. The person in the icon shouldn't be on the side...only the paper.

https://bugzilla.mozilla.org/attachment.cgi?id=230953

It's wrong in the current theme also.
No longer depends on: 347399
(Assignee)

Comment 59

12 years ago
Created attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

Patch to style winstripe tabstrip
Attachment #232276 - Flags: review?(mconnor)
(Assignee)

Comment 60

12 years ago
Created attachment 232277 [details]
Winstripe tabstrip icons for patch

Icons to go along with the winstripe tabstrip patch.
(Assignee)

Updated

12 years ago
Attachment #232276 - Attachment description: Winstripe tabstrip patch → Winstripe tabstrip patch. A couple of minor CSS tweaks still required: - Hover state for alltabs-box - alltabs-box is a few pixels off the right edge of the window when in overflow - 1 px gap appears in background tabs only with some number of tabs o
(Assignee)

Comment 61

12 years ago
Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

A couple of minor CSS tweaks still required:

- Hover state for alltabs-box
- alltabs-box is a few pixels off the right edge of the window when in overflow
- 1 px gap appears in background tabs only with some number of tabs open
- RTL may require some small tweaks
Attachment #232276 - Attachment description: Winstripe tabstrip patch. A couple of minor CSS tweaks still required: - Hover state for alltabs-box - alltabs-box is a few pixels off the right edge of the window when in overflow - 1 px gap appears in background tabs only with some number of tabs o → Winstripe tabstrip patch.
Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

please get rif of the change for spaces to hard tabs.
Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 


>Index: toolkit/content/widgets/tabbrowser.xml
>===================================================================

>   <binding id="tabbrowser-tab" display="xul:box"
>            extends="chrome://global/content/bindings/tabbox.xml#tab">
>     <content chromedir="&locale.dir;"
>              closetabtext="&closeTab.label;">
>+      <xul:hbox class="tab-left" xbl:inherits="selected"/>
>       <xul:hbox class="tab-middle box-inherit" xbl:inherits="align,dir,pack,orient,selected" flex="1">
>         <xul:image class="tab-icon" xbl:inherits="validate,src=image"/>
>         <xul:label class="tab-text" xbl:inherits="value=label,accesskey,crop,disabled" flex="1"/>
>       </xul:hbox>
>       <xul:image anonid="close-button-placeholder" class="tab-close-button-placeholder"/>
>       <xul:toolbarbutton anonid="close-button" class="tab-close-button"/>
>+      <xul:hbox class="tab-right" xbl:inherits="selected"/>
>     </content>
> 

The overriding binding of Pinstripe should be updated in parallel (even if you're not going to use these as selectos in Pinstripe)

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/globalBindings.xml#15
(Assignee)

Comment 64

12 years ago
(In reply to comment #63)

> The overriding binding of Pinstripe should be updated in parallel (even if
> you're not going to use these as selectos in Pinstripe)

I agree - I'd actually like to see the Pinstripe selectors change from tab-image-left, tab-image-middle, and tab-image-right to just tab-left, tab-middle, and tab-right as the hbox with class tab-image-middle actually contains the icon, text, and close button (not just an image). Thoughts?

Comment 65

12 years ago
Is it possible that the checkins for some of the files in at least browser/themes/winstripe/browser/ got messed up on the 1.8 branch (binary option forgotten)? I cannot get any good checkouts of these files:
   browser/themes/winstripe/browser/dropmark-nav-rtl-small.png
   browser/themes/winstripe/browser/dropmark-nav-rtl.png
   browser/themes/winstripe/browser/dropmark-nav-small.png
   browser/themes/winstripe/browser/dropmark-nav.png
   browser/themes/winstripe/browser/Search-provider-bkgnd.png
   browser/themes/winstripe/browser/Search-rtl.png
   browser/themes/winstripe/browser/Toolbar-rtl-small.png
   browser/themes/winstripe/browser/Toolbar-rtl.png
(In reply to comment #65)
> Is it possible that the checkins for some of the files in at least
> browser/themes/winstripe/browser/ got messed up on the 1.8 branch (binary
> option forgotten)?

Ah, indeed, I forgot to mark them as binary.  I just attempted a fix - can you retry?

Comment 67

12 years ago
Yes, thanks. Now it works.
Will be testing/landing the winstripe stuff here later this evening.
Status: NEW → ASSIGNED
Whiteboard: [Fx2 theme change]
(Assignee)

Updated

12 years ago
Assignee: mglenn → jgoldman
Status: ASSIGNED → NEW

Updated

12 years ago
Attachment #231886 - Flags: review?(mconnor)

Comment 69

12 years ago
(In reply to comment #68)
> Will be testing/landing the winstripe stuff here later this evening.
> 

Any indication as to when the Tabstrip patch for Winstripe will land on Branch? so that we can get some time to test for possible regressions.

Comment 70

12 years ago
Comment on attachment 232037 [details] [diff] [review]
winstripe searchbar patch

Marking Joe's winstripe searchbox patch obsolete, since it's been de-bitrotted and rolled into the patch for bug 347400.
Attachment #232037 - Attachment is obsolete: true
Comment on attachment 232276 [details] [diff] [review]
Winstripe tabstrip patch. 

So, as discussed, what we want to do here is use the same approach as Pinstripe and not hack the main binding structure.
Attachment #232276 - Flags: review?(mconnor) → review-

Updated

12 years ago
Attachment #231887 - Flags: review?(mconnor)
Comment on attachment 231981 [details] [diff] [review]
Pinstripe: theme for the tabstrip v2

this was already landed
Attachment #231981 - Flags: review?(mconnor) → review+
(Assignee)

Updated

12 years ago
Blocks: 347602
(Assignee)

Updated

12 years ago
Blocks: 347467
(Assignee)

Comment 73

12 years ago
Created attachment 233487 [details]
Pinstripe image replacements (new home, new reload, tinted disabled states)

This update to the Pinstripe icons fixes:

1) New Home button with a more colourful door
2) New Reload button without the back of the arrows
3) Tinted disabled states throughout the theme to better match OS X

Files need to be distributed as per the enclosed folder structure.
Attachment #233487 - Flags: review?(mconnor)
(Assignee)

Comment 74

12 years ago
Created attachment 233488 [details]
Winstripe image replacements (New Home button, New Reload button)
(Assignee)

Comment 75

12 years ago
Created attachment 233500 [details]
Winstripe image replacements (New Home button, New Reload button with improved small icon)

Tweaked the small version of reload to sharpen the arrowheads and make them more visibly arrowheads and less visibly blobs.
Attachment #233488 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Blocks: 347401
(Assignee)

Updated

12 years ago
Blocks: 347398
(Assignee)

Comment 76

12 years ago
Created attachment 233513 [details]
Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)

(replaces previously uploaded Pinstripe image replacements)

Update to the Pinstripe images for the Toolbar, including:

1- New Home icon with different door
2- New Reload icon without the back of the arrows
3- Tinted disabled states to match OS X
4- Modified dropmarkers for Back/Forward to better match the colours of the dropmarker background to the actual Back/Forward buttons in hover and active states

Note: you'll also need to apply the "Pinstripe Back/Forward Dropmark Position" patch, which follows.
Attachment #233487 - Attachment is obsolete: true
Attachment #233513 - Flags: review?(mconnor)
Attachment #233487 - Flags: review?(mconnor)
(Assignee)

Comment 77

12 years ago
Created attachment 233514 [details] [diff] [review]
Pinstripe Patch for Back/Forward Dropmark Position

Requires the previously uploaded "Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)"
Attachment #233514 - Flags: review?(mconnor)
(Assignee)

Comment 78

12 years ago
Created attachment 233516 [details]
Pinstripe image replacements (home, reload, tinted disable, back/forward dropmarks)

Wrong file last time :)
Attachment #233513 - Attachment is obsolete: true
Attachment #233516 - Flags: review?(mconnor)
Attachment #233513 - Flags: review?(mconnor)

Comment 79

12 years ago
(In reply to comment #75)
> Created an attachment (id=233500) [edit]
> Winstripe image replacements (New Home button, New Reload button with improved
> small icon)
> 
> Tweaked the small version of reload to sharpen the arrowheads and make them
> more visibly arrowheads and less visibly blobs.

It looks like the upper arrow on the small reload icons has one or two light-grey pixels to the left of the head for some reason.

Updated

12 years ago
Attachment #233514 - Flags: review?(mconnor)
Attachment #233514 - Flags: review+
Attachment #233514 - Flags: approval1.8.1+

Updated

12 years ago
Attachment #233516 - Flags: review?(mconnor)
Attachment #233516 - Flags: review+
Attachment #233516 - Flags: approval1.8.1+

Comment 80

12 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060813 BonEcho/2.0b1 ID:2006081323

icons on Add-ons Manager is not changed to new icons.
still "blue" home button.
Created attachment 234099 [details] [diff] [review]
winstripe tabstrip, rolls up other tabbrowser fixes for branch

Whee, Winstripe tabstrip is done-ish.

Also fixes the following issues on branch:

1) Seth's fix for bug #347783:  Tab listing bar loses styling after tab overflow background animation
2) Seth's fix for bug #348293: hover state on alltabs box doesn't work.  Hover should also work over the scrollbutton-down in the tabstrip for both winstripe and pinstripe
3) asaf's fix for bug #345257 (all tabs tooltip)
4) asaf's fix for bug #348362 (don't focus on a tab when mousing down on it's close button)

Known issues: 
RTL might suck (will follow up before freeze-time)
Attachment #234099 - Flags: approval1.8.1?
Comment on attachment 234099 [details] [diff] [review]
winstripe tabstrip, rolls up other tabbrowser fixes for branch

a=beltzner on behalf of drivers, for landing on the MOZILLA_1_8_BRANCH. Please mark fixed1.8.1 when it lands.
Attachment #234099 - Flags: approval1.8.1? → approval1.8.1+
landed on branch.  Please file bugs on anything theme-related in a new bug, this bug is done. Thanks!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

Updated

12 years ago
Depends on: 348929

Updated

12 years ago
Depends on: 348932

Updated

12 years ago
Depends on: 348934

Updated

12 years ago
Depends on: 348935

Updated

12 years ago
Depends on: 348937

Updated

12 years ago
Depends on: 348939

Updated

12 years ago
Depends on: 348942

Updated

12 years ago
Depends on: 348943

Updated

12 years ago
Depends on: 348967

Updated

12 years ago
Depends on: 348975
I just commited the /toolkit/themes/winstripe/global/icons images that were missed during the initial commit on Windows.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.