521659 - Main menu doesn't have hover/pressed state when using lightweight theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Vlado Valastiak [:wladow]]

Attachment: comparison screenshot

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091004 Minefield/3.7a1pre

Main menu doesn't have hover/pressed state when using lightweight theme, see screenshot.

Comment 1

[pino_sb]

Also the menubar is slightly higher (1 or 2 pixels), which results in the page moving when switching from normal theme to light-weight theme and vice versa. This does function correctly when using the Personas extension.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Dao, can you take a look at this?

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/36f210ede2e0

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e12ff214eb6c

Comment 6

[[not reading bugmail]]

Dao, I'm not able to verify this is fixed on Windows 7.  I've tried latest builds m-c and branch, new profiles and various personas and the STR from comment 1, but I am still getting the same as the screenshot.

Comment 7

[[not reading bugmail]]

I retested with newer hourlies, not sure why it took so long to show up in the build.  It's also really hard to see the hover pressed state with many dark themes, but now I see it on both trunk and branch and verifying fixed.

Comment 8

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.3a1pre) Gecko/20091107 Minefield/3.7a1pre