521936 - "Add-on Collector" v. 1.0.4 does not work in greek (el) firefox v. 3.5.3

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[olorou]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3

"Add-on Collector" v. 1.0.4 does not work in the greek (el) edition of firefox v. 3.5.3.
More particularly one cannot sign in one's mozilla account through this add-on, in order to browse one's add-on collections.


Reproducible: Always

Steps to Reproduce:
1. Go to: https://addons.mozilla.org/el/firefox/pages/collector (add-on collector download page).
2. Click: Add to Firefox.
3. Add-ons window pop-up.
4. Click: Install now.
5. Restart Firefox to install new add-on.
6. In Add-ons window > Tab: Add-ons.
7. Click: Settings of Add-on Collector.
8. Add-on Collector window > Tab: General Settings
9. Click: Log in button. 


Actual Results:  
The button is clicked but does not function. No "log in", "password" input boxes in the Subscriptions Tab of the Add-ons window.


Expected Results:  
One ought to be able to sign in to one's account and browse one's addon collections.

This happens only in the greek version of firefox 3.5.3. The english (en-us) version works fine.

Comment 1

[Kostas Papadimas]

Hmmmm. Confirmed with Greek 3.5.4 on linux and Add-on collector 1.0.4. Login button does not work at. Probably a l10n bug?. I'll try to have a look on it

Comment 2

[Kostas Papadimas]

English version of add-on Collector works fine with Greek Firefox versions. Seems that there is a problem with the Greek version of this add-on. Assigned to me

Comment 3

[Kostas Papadimas]

<!ENTITY manage.collection.label in extensionsOverlay.dtd    was missing from the Greek locale of Add-on Collector 1.0.4. Attached is the updated extensionsOverlay.dtd with the added entity, and a change in a translated string in order to avoid horizontal scrolling in Subscriptions window

Comment 4

[Kostas Papadimas]

Attachment: updated extensionsOverlay.dtd

Comment 5

[George Fiotakis]

It looks like more locales are missing that string (it, pl, for example) while though i can't be sure, most locales (if not all) still have the english string (fa definitely has it for example). Something must have gone wrong since i can't remember getting a notification for the string change either.

Comment 6

[Brian King [:kinger]]

Looks like el-GR and it has it now, but pl still missing.

Comment 7

[Leszek Zyczkowski]

(In reply to comment #6)
> Looks like el-GR and it has it now, but pl still missing.

Polish locale is after update, and corrections – ready to use. :)
rev.56692

Comment 8

[Brian King [:kinger]]

The original bug as described here is fixed and will be in the next release.

However, I found missing strings in el-GR and pl, both from settings.properties.

el-GR
auto.create.invalid.parameters
autoleadin.label

pl
autoleadin.label

For now I have checked in the English strings. Please translate, and then we can close off this bug.

Comment 9

[Leszek Zyczkowski]

(In reply to comment #8)
> The original bug as described here is fixed and will be in the next release.
> 
> However, I found missing strings in el-GR and pl, both from
> settings.properties.
> 
> el-GR
> auto.create.invalid.parameters
> autoleadin.label
> 
> pl
> autoleadin.label
> 
> For now I have checked in the English strings. Please translate, and then we
> can close off this bug.

pl Done.

Comment 10

[George Fiotakis]

Committed revision 56878 for el-GR.

I think it was revision 51212 that created the problem for all locales. I hope we'll get a notification in the mailing list next time we get an update.

Comment 11

[Brian King [:kinger]]

Thanks for the updates.

(In reply to comment #10)
> I think it was revision 51212 that created the problem for all locales. I hope
> we'll get a notification in the mailing list next time we get an update.

Yes, apologies for that. A while back we were putting in a lot of changes and we forgot to inform localisers. We'll be sure to give some notice and time for another pass at the strings before the next release.