Closed Bug 522014 Opened 14 years ago Closed 14 years ago

clear icon is windows style

Categories

(Thunderbird :: Search, defect, P3)

Product:
Thunderbird
Component:
Search
Platform:
All
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0rc1

People

(Reporter: andreasn, Assigned: andreasn)

Details

(Keywords: polish, Whiteboard: [no l10n impact])

Attachments

(2 files, 1 obsolete file)

screenshot of patch in action
2.96 KB, image/png
Details
updated patch
1.92 KB, patch
mkmelin
: review+
clarkbw
: ui-review+
Details | Diff | Splinter Review
Attached patch patch to fix the issue (obsolete) — — Splinter Review 
Originated from http://identi.ca/notice/11942230
The current clear icon on Linux is windows style, should make use of the gtk+ stock icon here.
Comment on attachment 406006 [details] [diff] [review]
patch to fix the issue

looks like this icon isn't used elsewhere so we probably want to drop it altogether (rm icon, removed from jar.mn).

http://mxr.mozilla.org/comm-central/search?find=%2Fmail%2Fthemes%2Fgnomestripe%2F&string=quick-search-clear.png
This looks like a good polish bug, marking P3 as it's simple and I wouldn't block the release for this beyond an hour.
Flags: blocking-thunderbird3+
Keywords: polish
Priority: -- → P3
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0rc1
Assignee: nobody → nisses.mail
Attached patch updated patch — — Splinter Review 
Here is a updated patch with the old icon removed.
Attachment #406006 - Attachment is obsolete: true
Attachment #406208 - Flags: ui-review?(clarkbw)
Attachment #406208 - Flags: review?(mkmelin+mozilla)
Attachment #406208 - Attachment is patch: true
Attachment #406208 - Attachment mime type: application/octet-stream → text/plain
Attachment #406208 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 406208 [details] [diff] [review]
updated patch

Great! r=mkmelin
Comment on attachment 406208 [details] [diff] [review]
updated patch

nice work!
Attachment #406208 - Flags: ui-review?(clarkbw) → ui-review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [no l10n impact]
http://hg.mozilla.org/comm-central/rev/60e1b4a992d8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.