Closed
Bug 522014
Opened 15 years ago
Closed 15 years ago
clear icon is windows style
Categories
(Thunderbird :: Search, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: andreasn, Assigned: andreasn)
Details
(Keywords: polish, Whiteboard: [no l10n impact])
Attachments
(2 files, 1 obsolete file)
|
2.96 KB,
image/png
|
Details | |
|
1.92 KB,
patch
|
mkmelin
:
review+
clarkbw
:
ui-review+
|
Details | Diff | Splinter Review |
screenshot of patch in action
Originated from http://identi.ca/notice/11942230 The current clear icon on Linux is windows style, should make use of the gtk+ stock icon here.
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Comment 2•15 years ago
|
||
Comment on attachment 406006 [details] [diff] [review] patch to fix the issue looks like this icon isn't used elsewhere so we probably want to drop it altogether (rm icon, removed from jar.mn). http://mxr.mozilla.org/comm-central/search?find=%2Fmail%2Fthemes%2Fgnomestripe%2F&string=quick-search-clear.png
|
|
||
Comment 3•15 years ago
|
||
This looks like a good polish bug, marking P3 as it's simple and I wouldn't block the release for this beyond an hour.
Flags: blocking-thunderbird3+
Keywords: polish
Priority: -- → P3
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0rc1
|
||
Updated•15 years ago
|
Assignee: nobody → nisses.mail
|
|
Assignee | |
Comment 4•15 years ago
|
||
Here is a updated patch with the old icon removed.
Attachment #406006 -
Attachment is obsolete: true
Attachment #406208 -
Flags: ui-review?(clarkbw)
Attachment #406208 -
Flags: review?(mkmelin+mozilla)
|
||
Updated•15 years ago
|
Attachment #406208 -
Attachment is patch: true
Attachment #406208 -
Attachment mime type: application/octet-stream → text/plain
Attachment #406208 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 406208 [details] [diff] [review] updated patch Great! r=mkmelin
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 406208 [details] [diff] [review] updated patch nice work!
Attachment #406208 -
Flags: ui-review?(clarkbw) → ui-review+
|
|
||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Updated•15 years ago
|
Whiteboard: [no l10n impact]
|
||
Comment 7•15 years ago
|
||
http://hg.mozilla.org/comm-central/rev/60e1b4a992d8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•