Closed Bug 522252 Opened 15 years ago Closed 15 years ago

make archiving of read-only folders do a copy, not a move

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Whiteboard: [no l10n impact])

Attachments

(1 file)

proposed fix
1.05 KB, patch
davida
: review+
Details | Diff | Splinter Review 
Archiving of news messages attempts to do a move to the archive folder, which only half succeeds (the copy part succeeds, the delete after fails). This leaves the destination folder locked. We should make archive of newsgroups or other folders that don't allow deleting of messages to do a copy, not a move.

Marking blocking because it's easy to reproduce and easy to fix.
Flags: blocking-thunderbird3+
OS: Windows NT → All
Hardware: x86 → All
Attached patch proposed fix — — Splinter Review 

        Attachment #406285 -
        Flags: review?(david.ascher)

    
    

    
  
I guess the alternative is disabling archive in this case...
Status: NEW → ASSIGNED
Summary: archiving newsgroup messages doesn't clear folder lock → mark archiving of read-only folders do a copy, not a move

    
  
Whiteboard: [has patch for review davida]
Summary: mark archiving of read-only folders do a copy, not a move → make archiving of read-only folders do a copy, not a move
Whiteboard: [has patch for review davida] → [no l10n impact][has patch for review davida]

        Attachment #406285 -
        Flags: review?(david.ascher) → review+

    
    

    
  
Comment on attachment 406285 [details] [diff] [review]
proposed fix

The code is fine-- I wonder if we want to somehow document the behavior -- relnote, user docs somewher?

    
    

    
  
Yes, I've added the relnote keyword, though I think user doc is probably more appropriate; When this page is updated for 3.0, the section on the archive command should reflect this - http://www.mozilla.org/support/thunderbird/menu
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: relnote
Resolution: --- → FIXED
Whiteboard: [no l10n impact][has patch for review davida] → [no l10n impact]
Keywords: relnote

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: