Closed Bug 522352 Opened 10 years ago Closed 10 years ago

[e10s] make nsSubDocumentFrame not assume that the subdocument has a docshell

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

x86
Windows NT
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(2 files)

Currently there's a fair bit of stuff in nsSubDocumentFrame which assumes that the subdocument is going to have a docshell; bits like nsSubDocumentFrame::ShowDocShell (which creates the view/widget as a side effect). It seems to me that most of this logic should forward back to the frameloader: bz does that make sense, or is there another way to refactor this?
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #406748 - Flags: review?(bzbarsky)
Comment on attachment 406748 [details] [diff] [review]
Refactor the docshell stuff from nsSubDocumentFrame to nsFrameLoader, rev. 1

Please document the frameloader methods, and either file a followup bug to have a sane way of getting an nsFrameLoader* from a node or put the new stuff on nsIFrameLoader (preferably the former, I think).

Looks good other than that, at least insofar as it should be doing the same thing as before...

Is it worth trying to land the non-e10s parts of this on m-c to ease merging?  Seems like it might be...
Attachment #406748 - Flags: review?(bzbarsky) → review+
Depends on: 523438
This is the mozilla-central version which I'll commit when the tree is less tortured.
http://hg.mozilla.org/mozilla-central/rev/79f7ceab9437
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
See Also: → 775965, 997255
Err, wrong window, sorry. Meant to put this in bug 1368852.
See Also: 775965, 997255
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.