522352 - [e10s] make nsSubDocumentFrame not assume that the subdocument has a docshell

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Benjamin Smedberg]

Currently there's a fair bit of stuff in nsSubDocumentFrame which assumes that the subdocument is going to have a docshell; bits like nsSubDocumentFrame::ShowDocShell (which creates the view/widget as a side effect). It seems to me that most of this logic should forward back to the frameloader: bz does that make sense, or is there another way to refactor this?

Comment 1

[Benjamin Smedberg]

Attachment: Refactor the docshell stuff from nsSubDocumentFrame to nsFrameLoader, rev. 1

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 406748 [details] [diff] [review]
Refactor the docshell stuff from nsSubDocumentFrame to nsFrameLoader, rev. 1

Please document the frameloader methods, and either file a followup bug to have a sane way of getting an nsFrameLoader* from a node or put the new stuff on nsIFrameLoader (preferably the former, I think).

Looks good other than that, at least insofar as it should be doing the same thing as before...

Is it worth trying to land the non-e10s parts of this on m-c to ease merging?  Seems like it might be...

Comment 3

[Benjamin Smedberg]

Attachment: mozilla-central version

This is the mozilla-central version which I'll commit when the tree is less tortured.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/projects/electrolysis/rev/878b8862b695

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/79f7ceab9437

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Err, wrong window, sorry. Meant to put this in bug 1368852.