Closed
Bug 523438
Opened 15 years ago
Closed 15 years ago
Make nsFrameLoader* available to content/layout
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
5.60 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
For e10s we're hanging additional methods off of nsFrameLoader. In my initial patches I was static_cast<nsFrameLoader*> from nsIFrameLoader*, but bz suggested that we should just have a getter and avoid the casts. This patch will hang a noscript nsFrameLoader* getter on nsIFrameLoaderOwner.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #407361 -
Flags: review?(bzbarsky)
|
||
Updated•15 years ago
|
Attachment #407361 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 407361 [details] [diff] [review] native nsIFrameLoader.GetFrameLoader, rev. 1 I'd prefer we not NS_IF_ADDREF nsCOMPtrs. Please .get() into a local before addreffing and returning that local?
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ab4333859900
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•