522844 - Stop depending on the incorrect behavior of inDeepTreeWalker::parentNode

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I'd like to fix that behavior and not break DOMi in the process.

I did test that the new code works.  ;)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Shawn Wilsher :sdwilsh]

I just want to make sure - this won't be broken in 3.0 or later builds, right (with this fix)?

Comment 3

[Boris Zbarsky [:bzbarsky]]

It shouldn't be, no.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 406836 [details] [diff] [review]
Fix

We really need to figure out a testing process for DOMi.  r=sdwilsh

Comment 5

[[e-mail]]

Comment on attachment 406836 [details] [diff] [review]
Fix

>       } else
>         break;
[Bah, who wrote this?]

Comment 6

[Boris Zbarsky [:bzbarsky]]

> [Bah, who wrote this?]

Hewitt.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/dom-inspector/rev/ae920516fcef

Comment 8

[[e-mail]]

(In reply to comment #6)
> > [Bah, who wrote this?]
> Hewitt.
[My question was supposed to be rhetorical.]