522875 - [Migration Assistant] "Use original toolbar" over-populates toolbar

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Joe Sabash [:JoeS1]]

Noticed while testing 223 migration.
TB2 profile and running current TB3 nightly.

STR:
Select the "use original toolbar" option.
On a display resolution of 1024x768 the vertical scrollbar disappears.
This lack of vertical scrollbar persists in the threadpane.

Backing one toolbar item out with customization restores the toolbar.
This is not very discoverable for the average user, so marking major sev.

Comment 1

[Joe Sabash [:JoeS1]]

This seems to happen only with "icons beside text" which is the default.
All other customization options work fine.

Comment 2

[Joe Sabash [:JoeS1]]

Managed to get DOMI running.
The computed syle of messengerWindow has a width of 1199px
Hence a good chunk of the screen is out of site in 1024x768 res.

Comment 3

[Joe Sabash [:JoeS1]]

Attachment: messengerWindow stretched beyond available screen

Screenshot of the problem

Comment 4

[rsx11m]

It looks like changing the "icon above text" default to "icon beside text" is pushing everything to the right out of the window. Maybe retaining the selected icon/text mode when opting for the old toolbar would be advised to avoid that?

Comment 5

[David Ascher (:davida)]

Blake, your patch about the toolbar will fix this, right?

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Attachment: 1024 original toolbar

Yup, it seems to.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Joe, could you check that tonight's nightly has fixed this problem, and mark it confirmed if it has?

(Or if you feel like getting latest from trunk and building it yourself to test, that would work too.  ;)

Thanks,
Blake.