523145 - Update plugin summary strings to be l10n friendly

Status: RESOLVED FIXED

(Websites :: plugins.mozilla.org, defect)

Description

[Austin King [:ozten]]

The plugin summary at the top left of the table says

$x of $y plugins are $worstDescription

$x and $y are numbers and $worstDescription is things like 
"potentially vulnerable"

An edge case:
1 of 1 plugins are potentially vulnerable

Luckily if there are no "bad" plugins, then the copy says either
"The plugins listed below are up to date" or 
"No plugins were detected"

Comment 1

[Austin King [:ozten]]

If we fix this bug with the current copy, we will have to start using a sprintf JavaScript library, which adds to the page weight. This is because we can't prepare this String in the PHP layer, where we often do sprintf tasks. JavaScript doesn't have a native sprintf function.

Recommend solution: Rewrite the copy to be more friendly to dynamic display and L10n Strings.

Comment 2

[Wil Clouser [:clouserw]]

> 
> $x of $y plugins are $worstDescription
> 

That won't work for L10n anyway, so I think rewriting is the right choice.

If you need an sprintf() JS lib, AMO uses one you can have.

Comment 4

[Kohei Yoshino]

So why you guys leave this issue for 8 months? I hope you'll consider l10n/l12y more than extending support for other browsers :(

Comment 5

[Pascal Chevrel:pascalc]

Should be rewritten in a more simple way IMO, like:

Number of vulnerable plugins wih no update: 3
Number of vulnerable plugins: 5
Number of potentially vulnerable plugins: 2

I don't think the "x of y" indication is really useful to the end users as he sees the page with all the colored boxes indicating the status displayed, but if we want to keep it we could have :

Number of vulnerable plugins wih no update: 1 out of 5

In that last case, Pfs_internal[12]="of"; should be updated with "%s out of %s" and a js sprintf library should be used, but that seems overkill to me and not adding any real value to the page.

Comment 6

[Ryan Doherty (:rdoherty)]

Attachment: Updated strings

Even simpler strings! I don't think we should have a string for 'vulnerable with no updates', the plugin will be marked vulnerable and bug 565398 should handle the rest.

Comment 7

[Pascal Chevrel:pascalc]

Ryan, can you land these string changes to plugincheck.js please ? thanks

Comment 8

[Ryan Doherty (:rdoherty)]

Just to clarify: the strings in attachment 455308 [details] need to be added to the existing strings in plugincheck.js for l10n.

Comment 9

[Austin King [:ozten]]

Current Strings:
/* At the top of the table is an overall summary about the "worst"
   plugin situation you have. Examples:
   1 of 14 plugins are vulnerable with no update available
     or
   1 of 2 plugins are potentially vulnerable */
Pfs_internal[12] = "of"

Pfs_internal[13] = "plugins are vulnerable wih no update available"
Pfs_internal[14] = "plugins are vulnerable"
Pfs_internal[15] = "plugins are potentially vulnerable"


New Strings:

Pfs_internal[12] -- removed, no numbers added to the copy.

Pfs_internal[13] = "Out of date plugins:"
Pfs_internal[14] = "Vulnerable plugins:"
Pfs_internal[15] = "Potentially vulnerable plugins:"

making changes, please correct me if I've misunderstood.

Comment 10

[Austin King [:ozten]]

Updated copy, removed string 12" on trunk.

Sending        js/plugincheck.js
Sending        js/plugincheck_badge.js
Transmitting file data ..
Committed revision 69957.

Comment 11

[Austin King [:ozten]]

Okay, no issues reported... ready for test.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> Created attachment 468149 [details]
> Screenshot

Is the above correct?