523358 - toolbar customizations aren't shown with "File > Open > Saved Message"

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Reader UI, defect)

Description

[[:Aureliano Buendía]]

I have custumize my main toolbar adding differents items to default items (that are "get mail", "write", "address book" and "tag").

When I open a saved message via menu-->File-->Open-->saved messages...
TB display the message in a window that show only the default toolbar item ("get mail", "write", "address book" and "tag").

It's deliberate?

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

It would be helpful to know whether this bug exists in Thunderbird 2 also; ideally tested using a fresh profile.

Comment 2

[Phil Ringnalda (:philor)]

I'd certainly think it does, since opening a saved .eml opens it in the standalone window, which has always been a separate windowtype with a separate toolbar that's customized separately.

Comment 3

[[:Aureliano Buendía]]

Attachment: regression?

(In reply to comment #1)
> It would be helpful to know whether this bug exists in Thunderbird 2 also;
> ideally tested using a fresh profile.

Test TB 2 and I have the expected behavior: the two toolbars are the same as in attached screenshot.

To mark as regression?

Comment 4

[[:Aureliano Buendía]]

Test result:

1. 2009-09-07-03 work
2. 2009-09-13-03 don't work

Comment 5

[Ludovic Hirlimann [:Usul]]

Candidates for regression http://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-09-07&enddate=2009-09-13 :
 * Bug 499989 - dmose
 * Bug 465269 - blake
 * Bug 474523 - Bryan

But its difficult to narrow down as so many things went in the tree in those six days.

Comment 6

[[:Aureliano Buendía]]

Better analysys:

2009-09-10-09  work
2009-09-10-03 don't work

Candidates for regression
http://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-09-09&enddate=2009-09-10

Comment 7

[[:Aureliano Buendía]]

(In reply to comment #6)
> Better analysys:
> 
> 2009-09-10-09  work
> 2009-09-10-03 don't work
Sorry for the mistake is:

2009-09-09-03 Work
2009-09-10-03 Don't Work

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

After looking through the more obvious candidates that landed in the range linked to in comment 6, and not seeing anything jump out at me, I'm now wondering if this is somehow related to the gloda search toolbar change that showed up in the big merge that happened on that day.

Before spending too much time on this bug, I think it would be useful to decide what behavior we think is actually the desired one.  I can understand Aureliano's surprise, since the toolbars (in their default configuration) seem to be identical except for the presence/lack of the search box.  

I'm having a hard time imagining this bug being a blocker even if it is a regression (which it only is if the change was unintentional).  clarkbw/davida/asuth: was such a change made intentionally?

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Not an intentional change.

Comment 10

[Phil Ringnalda (:philor)]

Not a reproducible change, either.

Toolbar customization is stored in localstore.rdf with the key, the rdf:about, being the chrome URI for the window plus the id of the toolbar.

Saved emails are opened in the standalone window, messageWindow.xul. The "main toolbar" is in messenger.xul.

If in Tb2 I create a new profile, set up an email account, save an .eml, then in the main 3pane window I customize the toolbar and remove a couple of buttons so I can recognize it, then right-click a message and choose "open in new window" to open the standalone message window, customize the toolbar there and remove two different icons (because the two I removed from the 3pane are still there in the standalone window, as expected because it's a different window), close that window, and then open the .eml that I saved, I get just what I would expect and just what I get in Tb3: it opens in the standalone window, so I get my customizations that were stored for messageWindow.xul.

Aureliano: are you seeing this "regression" in a new profile, or only in an old profile that you've been using for a while, long enough that you  might have forgotten that you separately customized both the 3pane and the standalone window to have the same things in them?

Comment 11

[[:Aureliano Buendía]]

(In reply to comment #10)
> Aureliano: are you seeing this "regression" in a new profile, or only in an old
> profile that you've been using for a while, long enough that you  might have
> forgotten that you separately customized both the 3pane and the standalone
> window to have the same things in them?

Both.

Comment 12

[Phil Ringnalda (:philor)]

Sorry, I probably asked that the wrong way. If you

1. In Tb2, create a new profile
2. Customize the toolbar in the 3pane, and remove the back and forward buttons
3. Open a saved email, or right click and Open In New Window

Do you see the back and forward buttons still there in the toolbar for the standalone window?

Comment 13

[[:Aureliano Buendía]]

(In reply to comment #12)
> Sorry, I probably asked that the wrong way. If you
> 
> 1. In Tb2, create a new profile
> 2. Customize the toolbar in the 3pane, and remove the back and forward buttons
> 3. Open a saved email, or right click and Open In New Window
> 
> Do you see the back and forward buttons still there in the toolbar for the
> standalone window?

Yes I see back and forward buttons in the toolbar for the standalone window.

Comment 14

[Phil Ringnalda (:philor)]

Not a regression, then. You could change this into an enhancement request to have it work the way you thought it did, but there's probably no point in doing that, since the only reasonable way to do that would be to use a single XUL window for both the 3pane and the standalone window, which someone might do for another reason, but I don't think anyone would do it just to have shared toolbar customization.

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to comment #2)
> I'd certainly think it does, since opening a saved .eml opens it in the
> standalone window, which has always been a separate windowtype with a
> separate toolbar that's customized separately.

aureliano, ludo, do we have separate litmus tests for standalone toolbar?

Comment 16

[Ludovic Hirlimann [:Usul]]

Not that I can remember of.

Comment 17

[Wayne Mery (:wsmwk)]

I don't believe this reproduces with v115