523708 - Move to 32px size for bookmarks, awesomebar, urlbar and search provider buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

In an effort to:
* Use a more common image size
* Larger is more visible
* Scale better since it's usually 16 -> 32

we are going to try using 32px sizes (set in CSS) for the hildon and wince/high themes

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Oups! It missed the search providers size in browser-high for wince

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 408765 [details] [diff] [review]
Patch


>diff -r 16a176ddd28c themes/wince/browser-high.css

>+.autocomplete-item-label > image,
>+.bookmark-item-label > image {
>+  width: 32px;
>+  height: 32px;
>+  margin: 0mm 2.5mm 0mm 2mm;

It would be nicer if we could 'margin' in wince/browser.css

>+}
>+
>+.autocomplete-item-url,
>+.bookmark-item-url {
>+  margin: 0;
>+  margin-right: 2mm;
>+  margin-left: 13.5mm;
>+}

It would be nicer if we could keep 'margin' and 'margin-right' in wince/browser.css

margin-left might be better if it was a mix of padding-left/margin-left using 'px' and 'mm', like we do for hildon.

>diff -r 16a176ddd28c themes/wince/browser-low.css

>+.autocomplete-item-label > image,
>+.bookmark-item-label > image {
>+  width: 24px;
>+  height: 24px;
>+  margin: 0mm 2.5mm 0mm 2mm;
>+}
>+
>+.autocomplete-item-url,
>+.bookmark-item-url {
>+  margin: 0;
>+  margin-right: 2mm;
>+  margin-left: 11.5mm;
>+}

Same here

>diff -r 16a176ddd28c themes/wince/browser.css

>@@ -265,17 +265,17 @@ placeitem > .bookmark-manage > image {
>   width: 24px;
>   height: 24px;
>   max-width: 24px;
>   max-height: 24px;
>   margin: 1.5mm 2.5mm 0mm 2mm;
> }

What is this part? I see 24px

Very close. We can get this into Beta 5

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Address comments

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/f22edbef9e4a

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091029 Namoroka/3.7a1pre Fennec/1.0b5pre