Move to 32px size for bookmarks, awesomebar, urlbar and search provider buttons

VERIFIED FIXED in fennec1.0b5

Status

Fennec Graveyard
Bookmarks
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: vingtetun)

Tracking

Trunk
fennec1.0b5
x86
Mac OS X

Details

(Whiteboard: [polish])

Attachments

(1 attachment, 2 obsolete attachments)

In an effort to:
* Use a more common image size
* Larger is more visible
* Scale better since it's usually 16 -> 32

we are going to try using 32px sizes (set in CSS) for the hildon and wince/high themes
Blocks: 517525
(Reporter)

Updated

8 years ago
Duplicate of this bug: 524621
Whiteboard: [polish]
Created attachment 408763 [details] [diff] [review]
Patch
Assignee: nobody → 21
Attachment #408763 - Flags: review?(mark.finkle)
Created attachment 408765 [details] [diff] [review]
Patch

Oups! It missed the search providers size in browser-high for wince
Attachment #408763 - Attachment is obsolete: true
Attachment #408765 - Flags: review?(mark.finkle)
Attachment #408763 - Flags: review?(mark.finkle)
Comment on attachment 408765 [details] [diff] [review]
Patch


>diff -r 16a176ddd28c themes/wince/browser-high.css

>+.autocomplete-item-label > image,
>+.bookmark-item-label > image {
>+  width: 32px;
>+  height: 32px;
>+  margin: 0mm 2.5mm 0mm 2mm;

It would be nicer if we could 'margin' in wince/browser.css

>+}
>+
>+.autocomplete-item-url,
>+.bookmark-item-url {
>+  margin: 0;
>+  margin-right: 2mm;
>+  margin-left: 13.5mm;
>+}

It would be nicer if we could keep 'margin' and 'margin-right' in wince/browser.css

margin-left might be better if it was a mix of padding-left/margin-left using 'px' and 'mm', like we do for hildon.

>diff -r 16a176ddd28c themes/wince/browser-low.css

>+.autocomplete-item-label > image,
>+.bookmark-item-label > image {
>+  width: 24px;
>+  height: 24px;
>+  margin: 0mm 2.5mm 0mm 2mm;
>+}
>+
>+.autocomplete-item-url,
>+.bookmark-item-url {
>+  margin: 0;
>+  margin-right: 2mm;
>+  margin-left: 11.5mm;
>+}

Same here

>diff -r 16a176ddd28c themes/wince/browser.css

>@@ -265,17 +265,17 @@ placeitem > .bookmark-manage > image {
>   width: 24px;
>   height: 24px;
>   max-width: 24px;
>   max-height: 24px;
>   margin: 1.5mm 2.5mm 0mm 2mm;
> }

What is this part? I see 24px

Very close. We can get this into Beta 5
Attachment #408765 - Flags: review?(mark.finkle) → review-
Created attachment 408847 [details] [diff] [review]
Patch

Address comments
Attachment #408765 - Attachment is obsolete: true
Attachment #408847 - Flags: review?(mark.finkle)
(Reporter)

Updated

8 years ago
Attachment #408847 - Flags: review?(mark.finkle) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/f22edbef9e4a
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091029 Namoroka/3.7a1pre Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
You need to log in before you can comment on or make changes to this bug.