523780 - Can not drag the first search engine in the listbox of Search Engine Manager

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091021 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091021 Namoroka/3.6b2pre ID:20091021050746

When I sort search engines,
I can not drag the first search engine in the listbox of Search Engine Manager

Reproducible: Always

Steps to Reproduce:
1.Start Namoroka with new profile
2.Click search engine icon and select 'Manage Search Engines…' in the dropdown.
3.Drag the first search engine(Google) in the listbox

Actual Results:  
Could not drag.

Expected Results:  
Can drag.

The bug happens on trunk build also
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091021 Minefield/3.7a1pre ID:20091021043213

Comment 1

[Alice0775 White]

This issue dissolves by modifying content\browser\search\engineManager.js as follows

function onDragEngineStart(event) {
  var selectedIndex = gEngineView.selectedIndex;
-  if (selectedIndex > 0) {
+  if (selectedIndex > -1) {
    event.dataTransfer.setData(ENGINE_FLAVOR, selectedIndex.toString());
    event.dataTransfer.effectAllowed = "move";
  }
}

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regression from the new D&D API which has been implemented in bug 456106.

Alice, would you be able to create a real patch against the trunk source?

Comment 3

[Alice0775 White]

(In reply to comment #2)
> Alice, would you be able to create a real patch against the trunk source?
Sorry, I am not familiar with source tree.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Would you mind to get the knowledge? There are some simple steps involved which are described in detail on MDC: https://developer.mozilla.org/en/Creating_a_patch

Comment 5

[Alice0775 White]

(In reply to comment #4)
> Would you mind to get the knowledge? There are some simple steps involved which
> are described in detail on MDC:
> https://developer.mozilla.org/en/Creating_a_patch
PleasePlease ask other person.

Comment 6

[Neil Deakin]

Attachment: patch as above

Is there a test for the search engine dialog?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> Is there a test for the search engine dialog?

Not that I'm aware of. I only know about the tests in the folder below which doesn't test the engine. Ryan, can you help?

http://mxr.mozilla.org/mozilla1.9.1/source/browser/components/search/test/

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 411129 [details] [diff] [review]
patch as above

(In reply to comment #6)
> Created an attachment (id=411129) [details]
> patch as above
> 
> Is there a test for the search engine dialog?

Nope!

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #8)
> > Is there a test for the search engine dialog?
> 
> Nope!

Let's flag for a request. Meanwhile I will add it to Litmus.

Comment 10

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/bd0b08574d1a

Comment 11

[Alice0775 White]

This issue is not fixed yet in Firefox3.6.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.2pre) Gecko/20100218 Namoroka/3.6.2pre ID:20100218052130

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right, it's not fixed for 3.6 but this is tracked by the approval request. So lets close this bug.

Neil, is your patch ready for asking approval1.9.2.2?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a2pre) Gecko/20100221 Minefield/3.7a2pre ID:20100221031108

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The following Litmus test has been updated to cover that particular regression:
https://litmus.mozilla.org/show_test.cgi?id=10233

(In reply to comment #12)
> Neil, is your patch ready for asking approval1.9.2.2?

Neil, any update or wont we be able to fix it on 1.9.2 due to regulations?

Comment 15

[Neil Deakin]

I tested the patch and it works fine. Ask for approval if this is desired but probably isn't worth it at this point.