Closed Bug 523936 Opened 15 years ago Closed 13 years ago

xpcshell-tests: Random Test Failure in test_browserGlue_distribution.js

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: sdwilsh, Unassigned)

References

()

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-in-places])

Attachments

(2 files)

WINNT 5.2 mozilla-central test opt everythingelse [testfailed] Started 12:54, finished 13:25
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256241288.1256243074.31586.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256449668.1256451668.22590.gz
OS X 10.5.2 mozilla-central test opt everythingelse on 2009/10/24 22:47:48
This is quite common on the Windows debug unittest box:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256828903.1256834271.3562.gz
WINNT 5.2 mozilla-central test debug everythingelse on 2009/10/29 08:08:23  
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1256851066.1256856998.5404.gz
WINNT 5.2 mozilla-central test debug everythingelse on 2009/10/29 14:17:46  
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
Marco - do you think you could tackle this?
i'll take a look, but it's a strange failure.
the first one is different too...
Assignee: nobody → mak77
the only thing i can think of actually is that the customization complete notification is fired too early. that can only happen if something runs in the middle of the bookmarks customization, but since it's a sync operation i can't see how.
The failure is in various point when checking the items in the menu/toolbar, some item is missing, like if it has not yet been added when the test checks.

For now i've only find that the test wrongly fire places-init-complete twice, that should not impact on success though since we stop observing after the first notification.
could be that the unioned query that reads the toolbar/menu contents fails due to bug 507790 and skips some child. We could try marking this as a random failing query and see, if it does not fail anymore was that.
hm, but actually we follow a different path in the test, checking directly with the bookmarks service, so now i doubt that would help.
Attached patch cleanupSplinter Review
this fixed a typo and removes the useless notification.
So far i've not found anything that could help with this failure, i really don't see how this could fail that way.
notice i ran the test in loop for a thousands times in debug mode on both a real machine and a VM, without seeing any failure, and that does not help.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1257163937.1257166119.28355.gz
OS X 10.5.2 mozilla-central test opt everythingelse on 2009/11/02 04:12:17
i pushed the cleanup since it's a trivial change
http://hg.mozilla.org/mozilla-central/rev/e6ecc37f467c
i don't think it will change anything relative this random failure.
Summary: Random Test Failure (test_browserGlue_distribution.js ) → xpcshell-tests: Random Test Failure in test_browserGlue_distribution.js
Whiteboard: [orange]
Comment #12 and comment #15 both report this problem on OS X.
OS: Windows XP → All
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258191434.1258193739.30752.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/11/14 01:37:14
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258413557.1258416513.31262.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/11/16 15:19:17
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258526166.1258528692.5674.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/11/17 22:36:06
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258656981.1258662146.21384.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/11/19 10:56:21
s: moz2-darwin9-slave09
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1259849036.1259851348.6133.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/03 06:03:56

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
OS X 10.5.2 mozilla-central opt test everythingelse [testfailed] Started 11:32, finished 12:13
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1259868757.1259871161.10155.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1260540290.1260542565.30867.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/11 06:04:50
s: moz2-darwin9-slave11
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1260532841.1260535390.9329.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/11 04:00:41  
s: moz2-darwin9-slave13
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1260741340.1260743871.24682.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/13 13:55:40
s: moz2-darwin9-slave16
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261011963.1261014578.5277.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/16 17:06:03
s: moz2-darwin9-slave07
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261086606.1261090288.18621.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/17 13:50:06
s: moz2-darwin9-slave09
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261153204.1261155638.5057.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/18 08:20:04
s: moz2-darwin9-slave02
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261202651.1261204979.31089.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/18 22:04:11
s: moz2-darwin9-slave17
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
Depends on: 536435
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261575195.1261578291.31754.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261825957.1261828430.366.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/26 03:12:37
s: moz2-darwin9-slave12
Error says: "Getting Started == Toolbar Link Before - See following stack:"
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262164682.1262167153.12033.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/30 01:18:02
s: moz2-darwin9-slave09
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262194053.1262199620.27484.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2009/12/30 09:27:33
s: win32-slave37
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262218893.1262221414.11078.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2009/12/30 16:21:33
s: moz2-darwin9-slave02
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262257053.1262262631.9478.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2009/12/31 02:57:33
s: win32-slave33
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262294461.1262300749.23262.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2009/12/31 13:21:01
s: win32-slave40
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262486260.1262493290.19626.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2010/01/02 18:37:40
s: win32-slave06
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262501486.1262503857.2367.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2010/01/02 22:51:26
s: moz2-darwin9-slave15
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262800528.1262810388.16426.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2010/01/06 09:55:28
s: win32-slave05
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262931503.1262937227.17113.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2010/01/07 22:18:23
s: win32-slave32
Attached patch patch v1.0Splinter Review
oh, this is embarassing, parseBookmarksSection is an helper, so it should not fire the notification, otherwise we could notify in the middle of import.
Attachment #420879 - Flags: review?(dietrich)
Comment on attachment 420879 [details] [diff] [review]
patch v1.0

Well, now this makes sense.  Can we enable the test we disabled too please (can't recall which one of these tests it was)
Attachment #420879 - Flags: review?(dietrich) → review+
(In reply to comment #44)
> (From update of attachment 420879 [details] [diff] [review])
> Well, now this makes sense.  Can we enable the test we disabled too please
> (can't recall which one of these tests it was)

that's already enabled since i was getting some logging out of it, unfortunatly this fix will only fix test_browserGlue_distribution.js failures. I hope to find the remaining issue soon.
ok, let's hope this is enough, resolving.
http://hg.mozilla.org/mozilla-central/rev/537a710037d4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
this failed right on my push, but, the failure is more then interesting. The moz_bookmarks table shows a duplicate with parent 2 and position 0, so looks like there is a bug when inserting a bookmark at index 0, based on runs the selected bookmark could be one of the 2 with the same position, so the test can fail or success. I'll look at that now, it will also need a unit test in case.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263131166.1263133558.28927.gz

*** Printing data from moz_bookmarks:
id	type	fk	parent	position	title	keyword_id	folder_type	dateAdded	lastModified	
1	2	NULL	0	0		NULL	NULL	1263132525237437	1263132525238265	
2	2	NULL	1	0	Bookmarks Menu	NULL	NULL	1263132525237915	1263132525350460	
3	2	NULL	1	1	Bookmarks Toolbar	NULL	NULL	1263132525238036	1263132525357979	
4	2	NULL	1	2	Tags	NULL	NULL	1263132525238152	1263132525239069	
5	2	NULL	1	3	Unsorted Bookmarks	NULL	NULL	1263132525238265	1263132525256942	
6	1	1	2	0	Get Bookmark Add-ons	NULL	NULL	1263132525258708	1263132525284423	
7	1	2	3	1	Getting Started	NULL	NULL	1263132525285582	1263132525285902	
8	2	NULL	3	2	Latest Headlines	NULL	NULL	1263132525286059	1263132525286697	
9	3	NULL	2	1	NULL	NULL	NULL	1263132525286781	1263132525286781	
10	2	NULL	2	2	Mozilla Firefox	NULL	NULL	1263132525286872	1263132525289656	
11	1	3	10	0	Help and Tutorials	NULL	NULL	1263132525287072	1263132525287775	
12	1	4	10	1	Customize Firefox	NULL	NULL	1263132525287949	1263132525288620	
13	1	5	10	2	Get Involved	NULL	NULL	1263132525288795	1263132525289482	
14	1	6	10	3	About Us	NULL	NULL	1263132525289656	1263132525290315	
15	1	7	2	0	Menu Link Before	NULL	NULL	1263132525346206	1263132525346206	
16	1	7	2	4	Menu Link After	NULL	NULL	1263132525350460	1263132525350460	
17	1	7	3	0	Toolbar Link Before	NULL	NULL	1263132525354586	1263132525354586	
18	1	7	3	3	Toolbar Link After	NULL	NULL	1263132525357979	1263132525357979
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263313845.1263316386.27828.gz
OS X 10.5.2 mozilla-central opt test everythingelse on 2010/01/12 08:30:45
s: moz2-darwin9-slave12
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
JS frame :: /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/head.js :: do_throw :: line 202
JS frame :: /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/head.js :: do_check_eq :: line 232
JS frame :: /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js :: continue_test :: line 114
JS frame :: /builds/slave/mozilla-central-macosx-opt-unittest-everythingelse/build/xpcshell/head.js :: anonymous :: line 96
TEST-INFO | (xpcshell/head.js) | exiting test
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263401112.1263408447.20579.gz
OS X 10.5.2 mozilla-central debug test everythingelse on 2010/01/13 08:45:12
s: moz2-darwin9-slave07
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-everythingelse/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263524055.1263525808.27661.gz
WINNT 5.2 mozilla-central debug test xpcshell on 2010/01/14 18:54:15  
s: win32-slave15
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\test_browser_places\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
hm, this had a pause, now started again being frequent. sometimes the failure is due to a missing bookmark, sometimes due to bookmarks having the same parent and position.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264095998.1264098952.9923.gz
WINNT 5.2 mozilla-central debug test xpcshell on 2010/01/21 09:46:38
s: win32-slave32
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264816715.1264817631.25972.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/01/29 17:58:35
s: moz2-darwin9-slave11
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265090493.1265091504.16461.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/02/01 22:01:33  
s: moz2-darwin9-slave22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265372863.1265373933.30377.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/02/05 04:27:43  
s: moz2-darwin9-slave23
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1266920357.1266921557.14481.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/02/23 02:19:17
s: moz2-darwin9-slave24
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268431706.1268433171.1449.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/12 14:08:26
s: bm-xserve17
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268470518.1268471976.28999.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/13 00:55:18
s: bm-xserve18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268527951.1268529601.6147.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/13 16:52:31
s: moz2-darwin9-slave16
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268588709.1268590688.19829.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/14 10:45:09
s: moz2-darwin9-slave16

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268658320.1268660094.11279.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/15 06:05:20
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268782931.1268784069.29390.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/16 16:42:11
s: moz2-darwin9-slave22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268782931.1268784069.29390.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/16 16:42:11
s: moz2-darwin9-slave22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268962001.1268963691.7522.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/18 18:26:41
s: moz2-darwin9-slave23
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269107681.1269110474.17352.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/20 10:54:41
s: moz2-darwin9-slave19

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Getting Started == Toolbar Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269115795.1269116758.32044.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/20 13:09:55
s: moz2-darwin9-slave10

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-opt-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269315101.1269316156.10085.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/22 20:31:41
The latest logs still show bookmarks with duped position values, but i've not found any code path that could create those.  If this can really happen it would be a quite important bug to fix.  If anyone with Places knowledge has ideas, i'm open to suggestions.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269350778.1269351828.19929.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/23 06:26:18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269426593.1269427972.3741.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/24 03:29:53
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269450347.1269451686.20682.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/24 10:05:47
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269613875.1269615873.7440.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/26 07:31:15  
s: moz2-darwin9-slave11
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269777061.1269778043.3643.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/28 04:51:01
s: moz2-darwin9-slave16
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270009256.1270010286.5174.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/03/30 21:20:56
s: moz2-darwin9-slave23
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270046743.1270050105.1540.gz
WINNT 5.2 mozilla-central debug test xpcshell on 2010/03/31 07:45:43
s: win32-slave26
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270058702.1270060741.2396.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/03/31 11:05:02
s: moz2-darwin9-slave09
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270122698.1270123730.3298.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/04/01 04:51:38
s: moz2-darwin9-slave21
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270140047.1270141059.2504.gz
OS X 10.5.2 mozilla-central opt test xpcshell on 2010/04/01 09:40:47
s: moz2-darwin9-slave24
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270264487.1270266698.25038.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/02 20:14:47
s: moz2-darwin9-slave43
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270298408.1270301021.20844.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/03 05:40:08
s: moz2-darwin9-slave19
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270407521.1270410118.29167.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/04 11:58:41
s: moz2-darwin9-slave24
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270418465.1270420755.16468.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/04 15:01:05
s: moz2-darwin9-slave02
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270442680.1270444301.26783.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/04 21:44:40  
TEST-PASS | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_corrupt_nobackup_default.js | test passed
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
  >>>>>>>
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
JS frame :: /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/head.js :: do_throw :: line 257
JS frame :: /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/head.js :: do_check_eq :: line 287
JS frame :: /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js :: continue_test :: line 120
JS frame :: /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/head.js :: anonymous :: line 224
T
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270481975.1270484258.6067.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 08:39:35
s: moz2-darwin9-slave12

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270487069.1270488585.19776.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 10:04:29
s: bm-xserve19

Other info same as in comment #93.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270495314.1270496173.12232.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test xpcshell on 2010/04/05 12:21:54
s: talos-r3-snow-016

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-snowleopard-opt-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-snowleopard-opt-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270505391.1270507496.14240.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 15:09:51
s: talos-r3-leopard-015

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270505386.1270507650.14753.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 15:09:46
s: moz2-darwin9-slave13
Same failure lines as in comment 96.
And for that matter,
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270485951.1270488593.19794.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 09:45:51
s: moz2-darwin9-slave20
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270513172.1270515156.3824.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 17:19:32
s: talos-r3-leopard-003
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270515285.1270517577.9799.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 17:54:45
s: talos-r3-leopard-027
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270525347.1270527163.32681.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 20:42:27
s: talos-r3-leopard-017

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270527103.1270529037.4887.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 21:11:43
s: talos-r3-leopard-019

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270526476.1270529089.4996.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 21:01:16
s: moz2-darwin9-slave19

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270527504.1270529568.6213.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 21:18:24
s: talos-r3-leopard-009
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270528243.1270529873.7075.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 21:30:43
s: bm-xserve09

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270528267.1270530410.8133.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 21:31:07
s: talos-r3-leopard-033
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270531916.1270534256.17787.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 22:31:56
s: talos-r3-leopard-012

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270532610.1270534156.17561.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 22:43:30
s: bm-xserve16
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270533589.1270535595.21175.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 22:59:49
s: talos-r3-leopard-026
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270539055.1270541227.6068.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 00:30:55
s: talos-r3-leopard-022
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270539023.1270541718.7907.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/06 00:30:23
s: moz2-darwin9-slave20
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270561523.1270563770.27844.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/06 06:45:23
s: moz2-darwin9-slave38
Get Bookmark Add-ons == Menu Link Before:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270535812.1270538060.27510.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/05 23:36:52
s: talos-r3-leopard-038

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270537818.1270539750.420.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 00:10:18
s: talos-r3-leopard-040

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270537051.1270539396.31526.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/05 23:57:31
s: moz2-darwin9-slave02

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270544560.1270546671.26303.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 02:02:40
s: talos-r3-leopard-024

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270545398.1270547405.29223.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test xpcshell on 2010/04/06 02:16:38
s: talos-r3-snow-008

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270545316.1270547566.29693.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 02:15:16
s: talos-r3-leopard-006

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270545275.1270546940.27594.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/06 02:14:35
s: bm-xserve11

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270562864.1270564639.30336.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 07:07:44
s: talos-r3-leopard-028
FWIW, scrolling back through tbpl for a few days, it looks like the frequency of this on Mac debug went up sometime on Friday April 2.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270581902.1270584008.23707.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 12:25:02
s: talos-r3-leopard-017
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
(In reply to comment #110)
> FWIW, scrolling back through tbpl for a few days, it looks like the frequency
> of this on Mac debug went up sometime on Friday April 2.

There was a tracemonkey merge that day. Nothing else looked related at first glance.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270586103.1270588815.10200.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/06 13:35:03
s: talos-r3-leopard-022
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270627802.1270630117.26727.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/07 01:10:02
s: moz2-darwin9-slave02

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270628092.1270630297.27441.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/07 01:14:52
s: talos-r3-leopard-020
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270624710.1270627116.19009.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/07 00:18:30
s: talos-r3-leopard-039
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270624708.1270627332.19617.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/07 00:18:28
s: moz2-darwin9-slave24
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270632886.1270635173.14346.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/07 02:34:46
s: talos-r3-leopard-020
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270712821.1270715079.29270.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/08 00:47:01
s: moz2-darwin9-slave16
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270775529.1270777722.26636.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/08 18:12:09
s: talos-r3-leopard-028
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270881148.1270883058.27443.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/09 23:32:28
s: talos-r3-leopard-024
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270881146.1270883413.28091.gz
OS X 10.5.2 mozilla-central debug test xpcshell on 2010/04/09 23:32:26
s: moz2-darwin9-slave11
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-central-macosx-debug-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | -1 != -1 - See following stack:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270919716.1270921666.3784.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test xpcshell on 2010/04/10 10:15:16
s: talos-r3-leopard-012

(and a whole bunch that wound up in bug 545323 since tbplbot was misfiring)
Hrm, distribution.js doesn't seem to make it's changes in a transaction, which could cause problems if other things are happening at the same time.

In the latest failure, there's no "before menu item" item at all, and nothing in the log indicating distribution customizations failed.
Filed bug 559103 to get distribution.js to do it's bookmark customizations inside a transaction.
Talked with sdwilsh, disabled the test until we figure it out.

http://hg.mozilla.org/mozilla-central/rev/d287e7a7b449
Apparently I disabled the test wrong, because it caused a crash. FTR, it didn't crash locally! Change backed out:

http://hg.mozilla.org/mozilla-central/rev/db22a5554a5e
(In reply to comment #266)
> Hrm, distribution.js doesn't seem to make it's changes in a transaction, which
> could cause problems if other things are happening at the same time.
> 
> In the latest failure, there's no "before menu item" item at all, and nothing
> in the log indicating distribution customizations failed.

That should not make a difference (also our transactions are not exclusive, thus something could still happen in the middle), i think we avoided a batch here because we are adding a minimum number of bookmarks (and only once), thus there is probably not the need to rebuild all complex queries.

This is crazy and pretty strange, for example if you look up to some log you can find entries in moz_bookmarks with the same position value, i've not found a code path that could cause that.
Missing entries could make me think we notify too early, but again i can't see what could interrupt the bookmarks addition code (that is sync).

This failure worries me, i'll dedicate some time to it today, i hope to be able to reproduce it at least once in a VM.
Blocks: 559354
second try to disable test, the crash dietrich saw probably worth investigations, i have no idea where it could come from (and it could be still there then!), btw, i did not early return in cleanup method since i want to eventually cleanup previous not-clobbered runs, so i just check if file exists.
http://hg.mozilla.org/mozilla-central/rev/e3d9d2edb159
i think the crash (that is actually due to the storage close db assertion) is mainly due to bug 529821, since we shutdown so late, nsPlacesDBFlush tries to init history service at/after xpcom-shutdown.
Whiteboard: [orange] → [orange][test_browserGlue_distribution.js disabled on central]
Anybody willing, feel free to work/report discoveries on these failures
Assignee: mak77 → nobody
Status: REOPENED → NEW
OS X 10.5.2 mozilla-1.9.2 opt test xpcshell on 2010/05/13 09:48:41
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1273769321.1273769764.28336.gz

OS X 10.5.2 mozilla-1.9.2 opt test xpcshell on 2010/05/13 10:50:03
s: moz2-darwin9-slave40
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1273773003.1273773403.13222.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1277433649.1277434409.28874.gz
OS X 10.5.2 mozilla-1.9.2 opt test xpcshell on 2010/06/24 19:40:49
s: moz2-darwin9-slave36

TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-1.9.2-macosx-opt-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/mozilla-1.9.2-macosx-opt-unittest-xpcshell/build/xpcshell/tests/test_browser_places/unit/test_browserGlue_distribution.js | Get Bookmark Add-ons == Menu Link Before - See following stack:
Whiteboard: [orange][test_browserGlue_distribution.js disabled on central] → [orange][test_browserGlue_distribution.js disabled on central][fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/68571c323401
Status: NEW → RESOLVED
Closed: 15 years ago13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][test_browserGlue_distribution.js disabled on central][fixed-in-places] → [orange][fixed-in-places]
Target Milestone: Firefox 3.7a1 → Firefox 6
Whiteboard: [orange][fixed-in-places] → [fixed-in-places]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: