Closed Bug 536435 Opened 10 years ago Closed 10 years ago

Remove bookmarks service dangerous usage of UNION ALL

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- ?
status1.9.1 --- ?

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(2 files)

Attached patch patch v1.0Splinter Review
This query does not suffer bug 507790, and explain tells me it uses about 84 steps, against 152 of the previous (tested with 3.6.21), so it should even be faster.
It is obviously already tested by current bookmarks tests, and could reduce oranges.
Attachment #418883 - Flags: review?(sdwilsh)
Depends on: 507790
Comment on attachment 418883 [details] [diff] [review]
patch v1.0

r=sdwilsh

Do we get to remove any tests from the list of tests we disable sync for with this fix?
Attachment #418883 - Flags: review?(sdwilsh) → review+
(In reply to comment #1)
> Do we get to remove any tests from the list of tests we disable sync for with
> this fix?

yes i'm collecting list of tests that could now be fixed, and will reenable them, to check what happens.
i will reenable these:

test_annotations.js
test_tagging.js
test_405938_restore_queries.js
test_423515_forceCopyShortcuts.js
test_448584.js
test_browserGlue_smartBookmarks.js

a couple of them are using other queries and i can't ensure they won't start to fail again, but in such a case i can just re-mark them.
Attached patch tests re-enableSplinter Review
Assignee: nobody → mak77
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/37bb58815455
http://hg.mozilla.org/mozilla-central/rev/59db8924376a

ok let's see how this behaves. i'm going to annotate all re-enabled oranges now...
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Blocks: 512692
Blocks: 509426
Blocks: 504643
Blocks: 512273
Blocks: 510219
Blocks: 523936
Blocks: 534417
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.