536435 - Remove bookmarks service dangerous usage of UNION ALL

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

Attachment: patch v1.0

This query does not suffer bug 507790, and explain tells me it uses about 84 steps, against 152 of the previous (tested with 3.6.21), so it should even be faster.
It is obviously already tested by current bookmarks tests, and could reduce oranges.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 418883 [details] [diff] [review]
patch v1.0

r=sdwilsh

Do we get to remove any tests from the list of tests we disable sync for with this fix?

Comment 2

[Marco Bonardo [:mak]]

(In reply to comment #1)
> Do we get to remove any tests from the list of tests we disable sync for with
> this fix?

yes i'm collecting list of tests that could now be fixed, and will reenable them, to check what happens.

Comment 3

[Marco Bonardo [:mak]]

i will reenable these:

test_annotations.js
test_tagging.js
test_405938_restore_queries.js
test_423515_forceCopyShortcuts.js
test_448584.js
test_browserGlue_smartBookmarks.js

a couple of them are using other queries and i can't ensure they won't start to fail again, but in such a case i can just re-mark them.

Comment 4

[Marco Bonardo [:mak]]

Attachment: tests re-enable

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/37bb58815455
http://hg.mozilla.org/mozilla-central/rev/59db8924376a

ok let's see how this behaves. i'm going to annotate all re-enabled oranges now...