Closed Bug 524026 Opened 14 years ago Closed 14 years ago

Fix "Warning: package error or possible missing or unnecessary file: bin/gksvggdiplus.dll (packages, 56)"

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
seamonkey2.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

(Av1a) Don't package obsolete file [Checkin: Comment 4]
1.81 KB, patch
kairo
: review+
kairo
: approval-seamonkey2.0.1-
Details | Diff | Splinter Review 
This file existed in Gecko 1.8.x only.

Bug 495612 added it to 'removed-files.in',
but missed to remove it from 'packages'.
Flags: in-testsuite-
Fix warning on trunk and 2.0.1 too.
Attachment #407934 - Flags: review?(kairo)
Attachment #407934 - Flags: approval-seamonkey2.0.1?
Av1, plus actually removing the file for '#ifndef MOZ_STATIC_BUILD' too.
Attachment #407934 - Attachment is obsolete: true
Attachment #407970 - Flags: review?(kairo)
Attachment #407970 - Flags: approval-seamonkey2.0.1?
Attachment #407934 - Flags: review?(kairo)
Attachment #407934 - Flags: approval-seamonkey2.0.1?
Comment on attachment 407970 [details] [diff] [review]
(Av1a) Don't package obsolete file
[Checkin: Comment 4]

I don't see a need to land this on 1.9.1, we can live with a bogus warning.
Attachment #407970 - Flags: review?(kairo)
Attachment #407970 - Flags: review+
Attachment #407970 - Flags: approval-seamonkey2.0.1?
Attachment #407970 - Flags: approval-seamonkey2.0.1-
Comment on attachment 407970 [details] [diff] [review]
(Av1a) Don't package obsolete file
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/1bbcbe25856e
Attachment #407970 - Attachment description: (Av1a) Don't package obsolete file → (Av1a) Don't package obsolete file [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1256329759.1256335574.4468.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2009/10/23 13:29:19

V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.