Closed
Bug 495612
Opened 15 years ago
Closed 15 years ago
make packages current and nicer for static, update removed-files
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
41.89 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
There are some slight adjustments to do to make packages files current, a few ifdefs to add so that static builds produce less noise, and a removed-files update for the static builds (probably also ifdef'd).
Assignee | ||
Comment 1•15 years ago
|
||
Some notes while researching what I find in the package-compare diffs:
- sessionstore.xpt doesn't exist because we have this info in suitecommon.xpt.
- necko_wifi.xpt was added to Mozilla/FF in bug 479898, we forgot to add it with network geolocation provider.
- mozlcms seems to not exist anywhere, may be an old remnant.
- msgbsutl.dll seems to be linked into static mail and from what I see we don't support non-static mail in our package files (unix doesn't have libmsgbsutil.so).
- res/entityTables/ and res/fonts/ are included with a star, don't need explicit entries in the packages file.
- nsProgressDialog.js _could_be dead, Firefox isn't packaging it, but Neil says it *might* still be used by FTP upload (if that would work). Not touch it in this bug for now, we need to investigate that elsewhere.
- helperAppDlg.xpt isn't actually generated anywhere.
- chromelist.txt has been dead for a while
- Not sure why a few components were kept as special entries out of normal order, that was useless.
- suite.dll is apparently NOT linked into the static binary right now, probably need to file a followup (same for libsuite.so).
- wlltvwrs.dll is dead
- xpinstal.dll is also not linked into the static binary (same for libxpinstall.so).
- A few other I would have expected (like xpcom) are also not linked into the main static binary.
- regxpcom doesn't need to be shipped any more.
- Not sure if we still need to keep [xpcom] as a separate section, but leaving as that would need installer changes as well, I guess. Could just empty that section and leave it to a followup to remove it from the file and the installer.
- Some unexplained differences in order between unix and windows, I cared to make them more similar.
- libdbusservice.so isn't linked into the static binary (same for libmozgnome.so and libnkgnomevfs.so).
- neither is libimgicon.so? (Windows version is!) - same for libjsd.so
Assignee | ||
Comment 2•15 years ago
|
||
- there is no mailnews.xpt
Assignee | ||
Comment 3•15 years ago
|
||
This does all the work, including everything I commented on here before.
I haven't tested Windows, Linux looks good in both shared and static config. removed-files can unfortunately only be tested really well with auto-update MARs with it inside being applied (tries to remove any files listed there before applying the update).
Updated•15 years ago
|
Attachment #380637 -
Flags: review?(neil) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•