Created attachment 408161 [details] [diff] [review] A patch to only disable the password, and not clear it. While I was testing bug 491202, I noticed that the password box was behaving strangely when I hit the start over link. Some debugging revealed that it was being cleared, IMHO incorrectly, leading to us showing passwords of blank, and possibly trying to test them, I think. Here's the patch to remove "password" from the list of things that get cleared and disabled, and add it to the list of things that get disabled. With this, it seems to work much more as I would expect. Since it's such a small change to the code, there's a very small risk of it breaking anything, and since it's a fairly confusing bug if you hit start over, I'ld like to slide the fix in to rc1. Thanks, Blake.
I think we would block a little bit for this...
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Attachment #408161 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 408161 [details] [diff] [review] A patch to only disable the password, and not clear it. ah, looks OK.
Whiteboard: [patch up, needs r philor]
Attachment #408161 - Flags: review?(philringnalda) → review+
Whiteboard: [patch up, needs r philor] → [no l10n impact][patch up, has r/sr]
Whiteboard: [no l10n impact][patch up, has r/sr] → [no l10n impact][ready to land]
Landed as http://hg.mozilla.org/comm-central/rev/ca8733580f2a and http://hg.mozilla.org/releases/comm-1.9.1/rev/a7b71303cc92 (Also, those were my first two commits!)
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [no l10n impact][ready to land] → [no l10n impact]
You need to log in before you can comment on or make changes to this bug.