52457 - autocomplete not active in urlbar *only* for modern theme

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Tracy Walker [:tracy]]

commercial builds:
windows classic: 2000-09-13-06-M18
linux classic: 2000-09-13-06-M18

autocomplete not active

Comment 1

[Stephen P. Morse]

Autocomplete is not autofill (yes, I know it's confusing).

Comment 2

[lchiang]

cc: paw and claudius.  Can we get this confirmed and assigned to the right
engineer?  cc: ducarroz. Is this yours?

Comment 3

[lchiang]

Actually, this may be due to text input problem outlined in
http://bugzilla.mozilla.org/show_bug.cgi?id=52459.  Can you confirm ducarroz?

Comment 4

[Doron Rosenberg (IBM)]

over to xp apps

Comment 5

[Jean-Francois Ducarroz]

Can you be more precise about what doesn't work and where? In url bar or in 
email address when composing a message? Have you check your pref to be sure 
Autocomplete is on (there is one pref for message compose, and it maybe have one 
for URL)

Comment 6

[Tracy Walker [:tracy]]

this is on browser URL completion.  Mail address completion is active and 
working. I don't see a pref choice for the URL autocomplete.  anybody know about 
this?

Comment 7

[Jean-Francois Ducarroz]

Radha is suppose to add the pref for ULR autocomplete and has the fix in her 
tree but its probably no checked in yet. As it's only a URL bar problem, Radha 
is the right owner for this bug.

Comment 8

[johng]

nav triage team:
+, P1

Comment 9

[Radha on family leave (not reading bugmail)]

There is a pref for urlbar autocomplete. It is enabled by default. I see 
autocomplete working as of today's 4 pm build. Marking "Worksforme"

Comment 10

[Luis Villa]

a) I can't find the pref in any of the "preferences" menus with the Modern skin.
b) using the latest Linux build (2000091408) I still don't get autocomplete.
Given that my opinion doesn't amount to much, but it definitely does not WFM.

Comment 11

[Radha on family leave (not reading bugmail)]

I do not have the UI checked in yet. But as I have mentioned in my previous 
comments, the pref(browser.urlbar.autocomplete.enabled) is true by default. So, 
autocomplete by default works. Once I check in the UI, you will be able to 
enable/disable it.

Comment 12

[Luis Villa]

I'm not saying that it is or isn't on by default (though I cannot find
browser.urlbar.autocomplete.enabled anywhere in a clean from scratch .mozilla.)
What I'm saying is that whether or not is is on by default, it does not work at
all in the newest Linux builds (now tested on 2000091421). So, either there is a
problem and the preference is not turned on by default as you claim (possible)
or it is broken (also possible.) Either way, I have confirmation from
#mozillazine that it is broken for other Linux users as well, so /something/ is
wrong and ought to be fixed. If this is just a matter of "something to be
checked in later" than WFM is not the correct designation, and it should be
re-marked correctly.

Comment 13

[James Green]

*** Bug 52779 has been marked as a duplicate of this bug. ***

Comment 14

[James Green]

Still no pref in 2000091421 with fresh ~/.mozilla, but sounds like this this
should be on by default. Doesn't work for me so reopening.

Comment 15

[R.K.Aa.]

bringing over snippet of comment from 52779:
"Autocomplete on modern skin doesnt appear to work at all.
Auto complete in Classic doesnt work on substring match"

Comment 16

[Tracy Walker [:tracy]]

autocomplete works fien on Mac commercial build 2000-09-15-04-M18

it does not work at all on Linux commercial build 2000-09-15-06-M18

Comment 17

[Tracy Walker [:tracy]]

this also doesn't work on windows commercial build 2000-09-15-08-M18

Comment 18

[Claudius Gayle]

radha, it must be something with your local tree, autocomplete definitely broke with
yesterday's (09/14/2000) builds (Linux and Win) -- they were fine with the day before's
builds (09/13/2000). And, yes, for some reason the skin makes a difference (works better
in Classic)

Comment 19

[Radha on family leave (not reading bugmail)]

cc'ing ben. Thre pref is in all.js. Does all.js exist in commercial builds. Is 
it someother file in commercial builds? How can a skin affect the urlbar's 
behavior?

Comment 20

[Tracy Walker [:tracy]]

still seeing on commercial build for windows 2000-09-18-06-M18
and linux 2000-09-18-06-M18 (note:  I now see prefs choice and by default it is 
checked on)

Comment 21

[Radha on family leave (not reading bugmail)]

Does disabling and enabling the prefs make any change in the behavior?

Comment 22

[Luis Villa]

Toggling the button doesn't appear to change anything for me (Linux, latest
nightly.) 

Comment 23

[Tracy Walker [:tracy]]

autocomplete working on linux commercial build 2000-09-19-06-M18

it is still inactive on windows commercial build 2000-09-19-06-M18

Comment 24

[Radha on family leave (not reading bugmail)]

The problem seems to be only in modern theme. blue and classic work. Actually I 
don't get any notification in the OnStartLookup() method from the autocomplete 
widget for modern theme. maybe the widget is inactive. 

JFD, can you throw some light here? Thanks,

Comment 25

[Jean-Francois Ducarroz]

I'll take a look at it...

Comment 26

[clayton]

Not a stop ship.

Comment 27

[Jus]

Using lastnights build This is NOT working correctly under classic. The
substring match does not work!

Comment 28

[Blake Ross]

*** Bug 53339 has been marked as a duplicate of this bug. ***

Comment 29

[Eric S. Smith]

My experience agrees w. Jus' (2000091908 on NT):

Modern skin: no autocomplete on URL bar
Blue and Classic skins: some autocomplete -- bugz does not autocomplete, but
http://bugz does correctly autocomplete to http://bugzilla.mozilla.org/ (among
others).

I assume that bugz -> http://bugzilla.mozilla.org/ would be an instance of
substring matching.  Whatever it's called, it doesn't happen.

Comment 30

[Radha on family leave (not reading bugmail)]

I took out substring matching, since lot of people complained about the ">>" 
that was showing up in substring matching. QA seems to think autocomplete works 
better now. So, I'm not planning to change the behavior at this time. Please 
open a separate bug if you think this is a serious fallout in the feature.

Comment 31

[WD]

Eric, on my system (2000091920) if I type in "bugz" in the URL box, it does 
autocomplete to "http://bugzilla.mozilla.org"          This is with the Classic 
skin, BTW.

Comment 32

[Jean-Francois Ducarroz]

If remove the id of the url text field, autocomplete works again. Looks like we 
a have a css rule for the id "urlbar" that cause the problem...

Comment 33

[Jean-Francois Ducarroz]

looks like the following css rule is the cause of the problem (in 
navigator.css):

#urlbar
  {
    -moz-binding		  : 
url(chrome://global/content/xulBindings.xml#textfield);
  }
 
But I don't what it means and if we really need it. Other themes don't have this 
rule!

Comment 34

[Radha on family leave (not reading bugmail)]

Ben can you throw some light on this? Thanks,

Comment 35

[Jean-Francois Ducarroz]

cc'ing nbhatla as he is the one who add this rule.

Comment 36

[Jean-Francois Ducarroz]

*if* we really need this rule, it should be:

-moz-binding: url(chrome://global/content/autocomplete.xml#autocomplete);

Comment 37

[Jus]

So we lost a great piece of functionality from the skin when some people
disliked substring match. Fantastic... On a more positive note, How do I add it
back in to the modern skin. Or at least tell me the date the change went in and
Ill find it my self.
Another question, I cant seem to see a mention in n.p.m.ui of the functionality
change to autocomplete (the removal of substring), was it ever posted?

Comment 38

[Radha on family leave (not reading bugmail)]

The behavior of the autocomplete functionality (not the UI part) is independant 
of the theme. So, if you change it, it is going to affect all skins. I would 
love to have the substring feature. It can be added with little more work to 
xpfe/components/urlbarhistory/src/nsUrlbarHistory.cpp::SearchCache(). I don't 
have cycles for it right now. Please look in lxr.mozilla.org for last changes to 
this file.

Comment 39

[R.K.Aa.]

the last change to nsUrlbarHistory.cpp was the convertion from PROGID's to
CONTRACTID's on the 13th. The file as such seems correct.

Comment 40

[Radha on family leave (not reading bugmail)]

The substring changes in ver 1.9 of nsurlbarHistory.cpp.

Comment 41

[Radha on family leave (not reading bugmail)]

JFD, can you send me the exact patch that you have. I tried to use the fix you 
have proposed and I still don't see autocomplete enabled. Thanks,

Comment 42

[Jean-Francois Ducarroz]

Attachment: Patch #1, fix the binding

Comment 43

[Jean-Francois Ducarroz]

Attachment: Patch #2, remove the binding rule

Comment 44

[Jean-Francois Ducarroz]

I've just posted both possible fixes. I personnaly prefere the second one where I totally remove the offending css 
rule instead of fixing the wrong binding. I let you to choose which one you want to apply.

Comment 45

[Tracy Walker [:tracy]]

seeing on windows commercial build 2000-09-22-08-M18

classic skin now also

Comment 46

[Radha on family leave (not reading bugmail)]

JF, I think something was goofed up in my tree last night. I see this working 
with today's update. I also like to remove the binding instead of patching it. I 
will check that in. Thanks,

Comment 47

[R.K.Aa.]

*** Bug 53852 has been marked as a duplicate of this bug. ***

Comment 48

[Ben Goodger (use ben at mozilla dot org for email)]

nominating for RTM, radha already has a patch. Let's not have this mis-managed
into oblivion. We can't have this sort of crap in the 'default' skin for NS6.

Comment 49

[Tracy Walker [:tracy]]

now seeing on Mac in classic skin too. build 2000-09-25-11-M18

Comment 50

[Peter Trudelle]

PDT marking nsbeta3-, nominating for rtm

Comment 51

[don]

Marking "rtm+" so Radha can at least get this into the trunk and hopefully into
RTM later.

Comment 52

[Tracy Walker [:tracy]]

working now on commercial trunk builds:
windows 2000-09-26-06-M18
linux 2000-09-26-06-M18
mac 2000-09-25-04-M18

Comment 53

[Radha on family leave (not reading bugmail)]

This is fixed in trunk.

Comment 54

[Tracy Walker [:tracy]]

verified fixed with branch builds also

windows 2000-09-27-11-MN6
linux 2000-09-27-10-MN6
mac 2000-09-27-11-MN6

Comment 55

[Luis Villa]

I hate to shake things up again, but it is broken again in the modern skin under
Linux. It worked for several hours this afternoon (works on 2000092708) but is
now broken again with 2000092710. I've moved .mozilla, re-downloaded, etc., and
no luck.
BTW, I'm reopening this bug instead of filing a new one because it appears to
have attracted the notice of the people who might have broken it. Sorry if that
is not quite the proper procedure.

Comment 56

[Luis Villa]

Sorry for the additional spam, everyone. I have some confirmations that it
wasn't working last night, but it is working again with 2000092721, so I'm going
to close it yet again. Sorry again for all the spam.

Comment 57

[Tracy Walker [:tracy]]

I'll reopen... seeing on windows commercial branch build 2000-09-28-08-MN6

Comment 58

[Radha on family leave (not reading bugmail)]

This bug is a rtm+ bug, nit a nsbeta3++ bug. That means that I can check this in 
only in the trunk. The status board also says that the fix has been checked only 
to the trunk. THis will get in to the branch after beta3 release.

Comment 59

[Tracy Walker [:tracy]]

per Rahda, marking fixed....sorry for the confusion.  

Comment 60

[Koike Kazuhiko]

This bug is not fixed on Win98 2000092808.

BTW,"for modern theme" in the summary field should be restored.

Comment 61

[Radha on family leave (not reading bugmail)]

resummarising

Comment 62

[Radha on family leave (not reading bugmail)]

Why is this re-opened again? [e-mail] re-openen with no explanation. 
What is the problem now?

Comment 63

[WD]

With 2000092908 (branch and trunk) on Win98, autocomplete does not work with the 
Modern Theme.
2000092908 on Redhat 6.1 oddly enough *does* work.

Comment 64

[Radha on family leave (not reading bugmail)]

Is location bar autocompletion enabled? Please check this in pref-> Smart 
browsing panel.

Comment 65

[WD]

Yes.   Autocomplete is enabled.
It works fine in Classic and Blue skins for me.   Just not Modern.
If I switch from Modern to Classic, then autcomplete starts working 
immediately...  no other changes.

Comment 66

[Luis Villa]

I am, unfortunately, seeing this too (again.) I understand that this is not an
easy process for everyone involved, but is it too much to ask that changes to
the skin that affect this be more thoroughly tested? By my count, since the
feature was first turned on, it has now been broken three times and fixed twice.
These kinds of regressions aren't pleasant for those of us trying to follow
nightlies and be helpful in that way.

Comment 67

[Koike Kazuhiko]

Win32 build 2000100120 on Win98 works fine.

Comment 68

[Michael La Guardia]

Marking needinfo.  Claudius, if you've sufficiently recovered from the burger
challenge, could you confirm is this is fixed yet?

Comment 69

[Mike Pinkerton (not reading bugmail)]

FYI, this still doesn't work with the final candidate Mac bits (9/29/00). Don't
resolve this bug, please!

Again, works just dandy in classic, not at all in modern.

Comment 70

[don]

PDT folks, the fix is on the trunk (not on the branch, Mr. Pink).  Obviously we
already have the approvals.  Can Radha please get this upgraded to a "++"?

Comment 71

[Phil Peterson]

PDT marking [rtm need info] since code reviewers are not listed in the bug. Who
reviewed?

Comment 72

[Jean-Francois Ducarroz]

Has I wrote the fix, I cannot be the reviewer. I think radah should be the 
reviewer and ben the super reviewer.

Comment 73

[Radha on family leave (not reading bugmail)]

Looking thro' the cvs logs when the fix was put in to the trunk reviewer & 
approver was ben. I also tried out the fix before I got ben's approval. So, 
r=ben/radha a=ben

Comment 74

[don]

Plus!  Now reviewed and approved.  PDT, please double plus this.

Comment 75

[Phil Peterson]

PDT marking [rtm++]

Comment 76

[Radha on family leave (not reading bugmail)]

Fixed in the branch too.

Comment 77

[Luis Villa]

It is broken yet again on the modern theme on Linux, and has been for at least
two days. Re-opening. 

Comment 78

[Koike Kazuhiko]

Win32 build 2000100520 doesn't work.

Comment 79

[Stephan Jaensch]

Neither with Linux 10-05-09. Seems like it regressed once more...

Comment 80

[Doron Rosenberg (IBM)]

*** Bug 55620 has been marked as a duplicate of this bug. ***

Comment 81

[Radha on family leave (not reading bugmail)]

I would like some input from you QA. Thanks,

Comment 82

[tor]

hewitt mentioned in #mozilla last week that he knew why this broke.

Comment 83

[Tom Mraz]

Still broken in 2000100908-M18. Oh no!

Comment 84

[Joe Hewitt (gone)]

I checked the fix for this one in today.

Comment 85

[Gilles Durys]

With build 2000100920 Mtrunk, it's kind of semi-broken.
Auto complete works with url *typed* in the url field, not with the ones loaded
using a bookmark.

Comment 86

[Radha on family leave (not reading bugmail)]

Autocomplete currently works only with the ones typed in. Bookmarks and urls 
visited thro' link clicks are in autocomplete list yet. That is not the scope of 
this bug. I already have a bug for link clicks notn auto-completable. Please 
open a new bug for bookmarked urls not getting to autocomplete list.

hewitt, can you tell me about the fix you had put in? What was teh problem?

Comment 87

[Radha on family leave (not reading bugmail)]

OOps! I meant, "link clicks and Bookmarks are *not* in autocomplete list yet". 
Marking this fixed again based on hewitt's comments. 

Comment 88

[Claudius Gayle]

where did hewitt check a fix into? I'm looking at the 2000101008 branch builds
and autocomplete works fine with both the modern and classic skins. Adding vtrunk keyword.

VERIFIED Fixed on BRANCH with 2000101008 builds.

Comment 89

[Tracy Walker [:tracy]]

verified fixed on friday 13th commercial builds:
windows 2000-10-13-06-Mtrunk & 2000-10-13-09-MN6
linux 2000-10-13-06-Mtrunk & 2000-10-13-09-MN6
mac 2000-10-13-08-Mtrunk & 2000-10-13-10-MN6

Comment 90

[Asa Dotzler [:asa]]

Removing vtrunk keyword to pull this off the needs verifying on trunk radar (and
becasue these keywords will go away soon)

Comment 91

[R.K.Aa.]

This does NOT work on linux SEA 2000-110121 (and hasn't for some while.)

Tested it as root with classic skin, and as normal user with newmod skin.
None of them work.
The autocomplete dropdown box appears - alternatives listed - but clicking
either does nothing at all.

Comment 92

[sairuh (rarely reading bugmail)]

autocomplete doesn't seem to work with 3rd party themes, aat least in Orbit. i'm
adding relnote-devel here --but if there's another more appropriate bug where
this should be mentioned, do lemme know. thx!