Closed Bug 524682 Opened 10 years ago Closed 10 years ago

comm-central should pull Chatzilla from hg rather than CVS

Categories

(MailNews Core :: Build Config, defect, major)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: fixed-seamonkey2.0.3)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #482686 +++
Flags: in-testsuite-
Depends on: 484205
Sorry, this does not depend on bug 524654 as just having an empty existing repo doesn't help us much, and it doesn't block bug 475011 because ChatZilla can move its development to hg without depending on us using that repo - it's the other way round, we depend on their source being there to switch over.
I'll wait with review until bug 475011 is fixed and ChatZilla code is actually there.
No longer blocks: 475011
Depends on: 475011
No longer depends on: 524654
(In reply to comment #2)
> I'll wait with review until bug 475011 is fixed and ChatZilla code is actually
> there.

Tested fine with now loaded CZ repo.
Attachment #408725 - Flags: review?(kairo)
Attachment #408725 - Flags: review?(gozer)
Attachment #408725 - Flags: review+
Comment on attachment 408725 [details] [diff] [review]
(Av1) Just like Venkman
[Checkin: Comment 5]

Looks good to me, but I'd like a second look at it from someone who's better at python - gozer, could you do that?
Attachment #408725 - Flags: review?(gozer) → review+
Comment on attachment 408725 [details] [diff] [review]
(Av1) Just like Venkman
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/e245eb08c4ba


"approval-seamonkey2.0.1=?":
No risk, Follow new CZ trunk repo.
Attachment #408725 - Attachment description: (Av1) Just like Venkman → (Av1) Just like Venkman [Checkin: Comment 5]
Attachment #408725 - Flags: approval-seamonkey2.0.1?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 408725 [details] [diff] [review]
(Av1) Just like Venkman
[Checkin: Comment 5]

This unfortunately is somewhat more critical on the comm-1.9.1 branch, as it requires changes to the build automation for the releases machinery.
I've talked to gozer, and we agreed that we should hold landing this on 1.9.1 off until Thunderbird 3.0 has been done. In practice, this probably means that we'll do it once I'm back from vacation, when I can also look into getting our buildbot factories fixed for it.
Blocks: 534422
Comment on attachment 408725 [details] [diff] [review]
(Av1) Just like Venkman
[Checkin: Comment 5]

From what I see, this patch doesn't apply as-is to the 1.9.1 branch (and 2.0.1 has been cut already), so minusing this particular patch.

Could you please attach a version that applies to the 1.9.1 branch? I'd like to have this in, esp. in conjuction with bug 534422.
Attachment #408725 - Flags: approval-seamonkey2.0.1? → approval-seamonkey2.0.1-
Av1, with comment 8 suggestion(s).
Attachment #417353 - Flags: approval-seamonkey2.0.2?
Comment on attachment 417353 [details] [diff] [review]
(Bv1-191) Just like Venkman
[Checkin: Comment 12]

Looks good, just want to have bug 534422 ready so build machines don't need more special hacks
Attachment #417353 - Flags: approval-seamonkey2.0.2? → approval-seamonkey2.0.2+
Comment on attachment 417353 [details] [diff] [review]
(Bv1-191) Just like Venkman
[Checkin: Comment 12]

a=me but please don't land, I'd like to have this in a single commit with bug 534422 so that no build machines (whatever they are pulling right now) might pull a newer chatzilla just to go back later.
Attachment #417353 - Attachment description: (Bv1-191) Just like Venkman → (Bv1-191) Just like Venkman [Checkin: Comment 12]
Blocks: 537461
Blocks: 614294
You need to log in before you can comment on or make changes to this bug.