524800 - Clicking the Website link in feed article message header does nothing (NS_ERROR_MALFORMED_URI)

Status: VERIFIED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Vlado Valastiak [:wladow]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5pre) Gecko/20091027 Shredder/3.0pre

- open Shredder's feed reader and load any article
- click the Website link in message header
- it should be opened in a web browser, but nothing happens

Error console says:

Error: uncaught exception: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIMessenger.launchExternalURL]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: chrome://communicator/content/utilityOverlay.js :: openUILink :: line 296"  data: no]

Works fine in 20091026.

Comment 1

[ovidiu]

window:
20091026 works
20091027 does not
20091028 does not
it was just introduced that new multi line header text wrapping (or so), maybe related...



click on a website link in the msg header (nothing happens):

Error: uncaught exception: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIMessenger.launchExternalURL]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: chrome://communicator/content/utilityOverlay.js :: openUILink :: line 296"  data: no]

rclick and copy link (does not copy)

Error: uncaught exception: [Exception... "Could not convert JavaScript argument arg 0 [nsIObserverService.removeObserver]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://messenger/content/search.xml ::  :: line 294"  data: no]

Comment 2

[Mark Banner (:standard8)]

Regression from bug 489609. Looks like the mail-headerfield binding changed where it stored the text, but the mail-urlfield didn't. This scares me in case there are other subtle locations where this has changed.

Comment 3

[Ben Bucksch (:BenB)]

Fix is trivial. The binding mail-urlfield inherits from mail-headerfield, and directly accessed attributes/properties of the textbox. We just need to change it to use .headerValue instead of .value.

At least I think so. I'll attach a prototype patch. I can't test it at the moment, because I am not using the feed reader, so the patch may not work.

> This scares me in case there are other subtle locations where this has changed.

I looked for any other XBL widgets which inherit from mail-headerfield, and found none.

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Fix, v1, untested

As said, may not work, but if so, needs only minor adjustments.

Comment 5

[Vlado Valastiak [:wladow]]

Doesn't work, this.headerValue is undefined.

Comment 6

[Ben Bucksch (:BenB)]

Attachment: Fix, v2

This works for me. It simply adapts .value -> .textContent (and <label> -> <description>, because we now set .textContent).

Better would be to:
- use .headerValue, but I don't know how to get to the XBL widget from the contained <description> object - .parentNode didn't work.
- maybe simply remove the inheritance, as only one line (the headerValue property) is inherited.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 408969 [details] [diff] [review]
Fix, v2

>+++ b/mail/base/content/mailWidgets.xml
>-      <xul:label onclick="if (event.button != 2) openUILink(event.target.value, event);"
>+      <xul:description onclick="if (event.button != 2) openUILink(event.target.textContent, event);"

You could split this on to two lines.  Or not.  Whatever.

Other than that, and I don't even really count that, it looks good to me.

Later,
Blake.

Comment 8

[Ben Bucksch (:BenB)]

Attachment: Fix, v3 - whitespace changes only

Comment 9

[Vlado Valastiak [:wladow]]

Ok, this seems to be working fine.

The bug is marked as blocking‑thunderbird3+, you don't need another approval, I think.

Comment 10

[Ben Bucksch (:BenB)]

Comment on attachment 409111 [details] [diff] [review]
Fix, v3 - whitespace changes only

Oh, right.

http://hg.mozilla.org/comm-central/rev/9761dee74d12
http://hg.mozilla.org/releases/comm-1.9.1/rev/27c3a3bf741c

Comment 11

[Ben Bucksch (:BenB)]

FIXED

Comment 12

[Bill Burns]

This is not working on 20091029 nightly.  The "website" link on RSS feed messages does nothing when clicked, and right-click "Copy Link Location" leaves the clipboard empty.
WinXP SP3.

Comment 13

[Ben Bucksch (:BenB)]

Yes? Because I just fixed it less than an hour before you commented, and the your build doesn't have the fix yet?

Comment 15

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1.5pre) Gecko/20091030 Shredder/3.0pre