524978 - Form Fill jumps content to the top left on OkCupid

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b2pre) Gecko/20091027 Namoroka/3.6b2pre Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091027 Namoroka/3.7a1pre Fennec/1.0b5pre

Steps to Reproduce:
1. Go to www.okcupid.com
2. Fill out the form on the first page and click "Next"
3. Click on either the zip code or email address field
4. Type in one or more letters

Actual Results:
The content pane will pan to the top left

Expected Results:
The content pane shouldn't move

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I've seen this happen on other websites too (bugzilla as example). I think this is relate to scroll position or something like that because I can see a scroll event happening when typing a letter which cause the UI to redraw at position 0,0

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

also matchage.com when typing the age in the text field

Comment 3

[[:Aleksej]]

Happens (at okcupid.com and matchage.com) with
both 1.9.2 and trunk nightlies 20091125 on linux-i686.

At matchage.com, it doesn't happen every time with the 1.9.2 nightly.

Comment 4

[Aakash Desai [:aakashd]]

I see this on bugzilla's frontpage when typing text into the "Quick Search" below the large button images. This probably needs to block.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> I see this on bugzilla's frontpage when typing text into the "Quick Search"
> below the large button images. 

Seeing this too

> This probably needs to block.

agreed

In fact this bug should be resolved when bug 500700 will be resolved. 
I've kept this bug opened just to remenber it also affects the Form Assistant.

Comment 7

[Aakash Desai [:aakashd]]

dupe v.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: dirty patch

Because there is a reflow when you enter a letter on the keyboard and because the real browser scrollbox position is at 0,0 we handle it thought handlePageScroll.

This patch fix that but it also means that we're going to handle page scroll events when while the form assistant is opened.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Ben, this bug is the real bug which correspond to 527187 which is a blocker (and a dup of this one)

Comment 10

[Benjamin Stover (:stechz)]

Comment on attachment 416653 [details] [diff] [review]
Patch

>+  _ignorePageScroll: false,
>+  ignorePageScroll: function ignorePageScroll(aIgnoreScroll) {
>+    this._ignorePageScroll = aIgnoreScroll;
>+  },

Oh noes :( I'm pretty certain there is no other way to do this, so you get an r+.  Fixes the problem for me on okcupid.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Ben I have filled bug 533970 for the bug you found during the test for this patch

Comment 13

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mobile-browser/rev/03cfe0e88a8d

Comment 14

[Aakash Desai [:aakashd]]

Content window does not jump on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091214 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091214 Firefox/3.7a1pre Fennec/1.0b5