525124 - Double Clicking in a Blank Space Opens the Advanced Property Editor

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5pre) Gecko/20091024 Ubuntu/9.04 (jaunty) Firefox/3.5.2
Build Identifier: 3.0pre

I'm totally unsure if this is just me, but in case it's not, doing the following opens the advanced property editor:
1. Write yourself an HTML message that includes a couple paragraphs (or use one you've already got) 
2. Reply to that message
3. In the blank space next to one of the paragraphs in the reply text, double click
4. For me, this selects some quantity of text, then opens the Advanced Property Editor

Reproducible: Always



Expected Results:  
I wouldn't expect this to open the advanced property editor...

Comment 1

[Ludovic Hirlimann [:Usul]]

I see it too, but your are trying to edit the quote.

Michael what do you expect from the double click ?

Bryan Thoughts ?

Comment 2

[[e-mail]]

I would expect selection to occur, similar to how it does when responding to plaintext messages. 

Double clicking on text (as opposed to a blank space) in the reply to an HTML message does NOT open the Advanced Property Editor. It only happens when clicking on a blank space.

Even as an advanced TB user, I almost never will need the Advanced Property Editor.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Yuck, sounds like odd composer bugs to me.

Comment 4

[Wayne Mery (:wsmwk)]

do you still see this?
i don't see this on windows trunk.

Comment 5

[Wayne Mery (:wsmwk)]

I recant - this reproduces. current trunk
(Lissner seems to be gone)

Comment 6

[[e-mail]]

I'm here, and I'm now running nightly TB. I can't currently reproduce, but I'm pretty sure I ran into this recently, so it's still around.

Comment 7

[Jb Piacentino]

I confirm this is still always reproducible in TB 7 in the following cases:

- double click on a blank line within a signature paragraph. In the following signature example, 
1.     Thanks
2.     
3.     Jb
double click on line #2 selects the whole signature and pops a 'Advanced Property Editor', showing 'Current attributes for: <div>' (HTML attribute is of moz-signature class)

- Set a line style to 'Paragraph', and double click 'close to the right hand side of the line'. Again, the whole line is selected and the 'Advanced Property Editor', pops, showing 'Current attributes for: <p>' 

- double click in a table cell

I would expect the double click to only select the word below the cursor. 

The Advanced Property Editor should be reachable through right-click, or equivalent on Mac or Linux

Comment 8

[quinn.brendan]

I am able to reproduce this issue in TB 8.0 on MAC as well.

Comment 9

[dcostebug]

I also get this annoying issue:

In a *HTML* mail composer window, if I double or triple click to the right of the rightmost char of any line (empty or not), the complete paragraph is selected and a popup appears asking for the adv attributes (with 3 tabs : HTML attr/integ style/Javascript events)

In that same HTML composition window, double or triple clicking *on* any actual character (space or letter) gives the right behaviour, the same as in a non-HTML composition window:
double click selects the underlying word
triple click selects the underlying paragraph

Comment 10

[Geoff Goas]

Issue occurs on TB 17.0 for Linux

Comment 11

[Keith Hanlan]

The broken mouse excuse is not valid. This happens for me on multiple Windows 7 platforms with multiple mice including a brand new mouse. All these mice work perfectly fine with all other applications - only TB has this infuriating behaviour. And it does not require that I double click on whitespace. Typically it happens when I am changing the font of individual words and need to highlight them before I reach for the font menu. I am using TB 22.0.

Comment 12

[Greg Allen]

me too. Mousepad on laptop. thunderbird 17.0.6

Comment 13

[Dana Lee Ling]

TB 24.1.0 on Windows 8.0 too. Toshiba laptop with sensitive mousepad, heavy clumsy hands, forces me to turn off mousepad when composing to avoid accidental double-tap on blank, opening the advanced properties editor. Nothing in advanced config editor suggests a way to disable this. Only the triple-click select paragraph can be disabled.

Comment 14

[Diamond Tiara]

TB 12 on XP pro. double-clicking while composing a new message pops up APE dialog.
TB 24.2 on xubuntu does it as well on a completely different account.

Regardless Intellimouse explorer, Logiutech VX Nano, G400 and Wacom Intuos the problem is not linkedd to anything from the mouse's hardware and windows/linux/versions aren't to be incriminated.
People and customers I know using win7 have this problem and tells me they want to go back to Outlook.
Sending emails without HTML formatting is not an acceptable solution.
Reinistalling everything and giving up years of archived e-mails is even less of an acceptable solution for the people with that.

This is not a bug, it is an unwanted feature.

Find a fix to disable this thing that get people insane.

Comment 15

[Jeffrey]

I am seeing this problem on TB 27.0b1 too.

Comment 16

[Magnus Melin [:mkmelin]]

Probably http://mxr.mozilla.org/comm-central/source/editor/ui/composer/content/ComposerCommands.js#3055

Comment 17

[hobo jo]

Im going to add a Me Too here.
Surely this is not a "feature" and if so can there PLEASE be a way to turn this OFF, Its so time wasting and so so annoying having this pop up each time I double click the line that i want select.

DBL clicking a blank line, either deliberately or accidentally, IMHO, should just select the line, not open this editor that I never use.
I humbly ask that the TB developers to please incorporate a way to disable this thing before I kill myself!

Comment 18

[Andrew]

It happens to me, too. TB 24.3.0 on Windows 7 64bit

Comment 19

[Sniglet]

It is SO ANNOYING. I can hardly edit my email without going to the stupid advanced properties. Please, someone figure how to turn it off. Can I go back to a previous version of Tbird or has this monster existed all along? I'm using 24.4.0 with Win 7 Pro.

Comment 20

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

It does seem unexpected behavior to me

Comment 21

[Joe Sabash [:JoeS1]]

I think there is something more to consider here. Double click in a blank area within a Div calls the advanced edit, but also focuses the editor on that div. I can't see how you could call the advanced editor on the element (div) that you wanted to edit if this behavior gets changed.I realize that not many really use the advanced editor, but it is a handy way to insert inline styles without using an  extension to edit the raw html.

Comment 22

[Geoff Goas]

then the advanced editor should be on the right click menu, not the result of a double click. the existing behavior is counter-intuitive.

Comment 23

[[e-mail]]

Comment on attachment 8402296 [details] [diff] [review]
proposed fix

Unfortunately this appears to break the "Advanced Properties" menuitem.

Comment 24

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

The Advanced Properties dialog menu enabling/disabling seems to be flakey (to put it nicely!) but that's not this bug... this patch skips opening the dialog for body and p.

Comment 25

[[e-mail]]

Attachment: Compromise

This keeps the old double-click behaviour for show all tags mode, but for normal editing it uses rangeParent/Offset which counts clicks in the blank space at the end of a line as part of the text.

Comment 26

[Magnus Melin [:mkmelin]]

Comment on attachment 8402695 [details] [diff] [review]
Compromise

Review of attachment 8402695 [details] [diff] [review]:
-----------------------------------------------------------------

While I like the idea, I don't see any improvement. My test case is that in thunderbird I write this in html compose mode:

test

test

Then if you dblclick between the tests the editor (still) pops up. I think that is similar to what people complain about in this bug.

Comment 27

[[e-mail]]

Strange; I don't see that at all. Which element are you getting the editor for?

Comment 28

[Joe Sabash [:JoeS1]]

(In reply to [e-mail] from comment #25)
> Created attachment 8402695 [details] [diff] [review]
> Compromise
> 
> This keeps the old double-click behaviour for show all tags mode, but for
> normal editing it uses rangeParent/Offset which counts clicks in the blank
> space at the end of a line as part of the text.

Unfortunately, TB doesn't have a show all tags mode AFAIK

Comment 29

[Magnus Melin [:mkmelin]]

(In reply to [e-mail] from comment #27)
> Strange; I don't see that at all. Which element are you getting the editor
> for?

It's pops up the editor for <body>

Comment 30

[[e-mail]]

Attachment: Fixed patch

Ah, I see the problem now, the <br> is confusing it.

(Interestingly double-clicking between a pair of <br> nodes selects the paragraph.)

Comment 31

[Magnus Melin [:mkmelin]]

Comment on attachment 8404197 [details] [diff] [review]
Fixed patch

Review of attachment 8404197 [details] [diff] [review]:
-----------------------------------------------------------------

Yep this works! Would be good to add additional comments in the code though

Comment 32

[Ian Neal]

Comment on attachment 8404197 [details] [diff] [review]
Fixed patch

Seems to fix the issue.
Trying to do Advanced Properties on <a href="" rel="nofollow">link</a> fails silently. Not sure if this related or a separate problem.

Comment 33

[[e-mail]]

Pushed comm-central changeset 107302e430f1.

I typoed the bug number though :-(

Comment 34

[Jorg K (CEST = GMT+2)]

Comment on attachment 8402391 [details] [diff] [review]
proposed fix, v2

Landed as part of bug 1143744:
https://hg.mozilla.org/comm-central/rev/862885de2876

At the same time backed out changeset 107302e430f1 due to various regressions.