525232 - make use of golden colored attachment icon in message header list on Aero

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: This use a golden color for the attachment icon

It would be neat to have the attachment icons used in the aero theme use the same color.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 409089 [details] [diff] [review]
This use a golden color for the attachment icon

This looks good to me.  Thanks!

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 409089 [details] [diff] [review]
This use a golden color for the attachment icon

Well, if that's what you guys want to do, I can't really argue with the code :)

Comment 3

[Andreas Nilsson (:andreasn)]

Comment on attachment 409089 [details] [diff] [review]
This use a golden color for the attachment icon

lets see if this can go into 3.0 now that this got both review and ui-r.The change is rather small.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/8023c4962735
http://hg.mozilla.org/releases/comm-1.9.1/rev/0d6045093c0f

Comment 5

[Thomas Stache]

Attachment: screenshot of UI with patch

Are you sure this was a good idea? The new golden attachment clip icon is very distracting, especially if you happen to have many mails with attachments.

I think this really jumps out and reduces legibility of the thread pane, forcing the eye into "columnar mode" instead along the rows (as intended with the zebra stripes).

I'm not sure why this design was chosen especially for Aero, I don't have the impression that my Vista desktop is so about "bling"....